.NET 9 compilation

ThadHouse · ThadHouse · commit 906b612dbc7a · 2024-11-17T16:26:04.000-08:00
diff --git a/.editorconfig b/.editorconfig
@@ -51,6 +51,7 @@ dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
 dotnet_style_prefer_auto_properties = true:silent
 dotnet_style_prefer_conditional_expression_over_assignment = true:silent
 dotnet_style_prefer_conditional_expression_over_return = true:silent
+dotnet_style_namespace_match_folder = true:silent
 ###############################
 # Naming Conventions          #
 ###############################
@@ -92,6 +93,8 @@ csharp_style_deconstructed_variable_declaration = true:suggestion
 csharp_prefer_simple_default_expression = true:suggestion
 csharp_style_pattern_local_over_anonymous_function = true:suggestion
 csharp_style_inlined_variable_declaration = true:suggestion
+csharp_style_namespace_declarations = file_scoped
+csharp_style_prefer_primary_constructors= false:silent
 ###############################
 # C# Formatting Rules         #
 ###############################
diff --git a/codehelp/CodeHelpers.Test/LogGenerator/LogGeneratorTest.cs b/codehelp/CodeHelpers.Test/LogGenerator/LogGeneratorTest.cs
@@ -1,7 +1,6 @@
 namespace CodeHelpers.Test.LogGenerator;
 
 using System.Text;
-using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp.Testing;
 using Microsoft.CodeAnalysis.Testing;
 using Microsoft.CodeAnalysis.Text;
diff --git a/codehelp/CodeHelpers.Test/LogGenerator/LogGeneratorTestVb.cs b/codehelp/CodeHelpers.Test/LogGenerator/LogGeneratorTestVb.cs
@@ -1,7 +1,6 @@
 namespace CodeHelpers.Test.LogGenerator;
 
 using System.Text;
-using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.Testing;
 using Microsoft.CodeAnalysis.Text;
 using Microsoft.CodeAnalysis.VisualBasic.Testing;
diff --git a/codehelp/CodeHelpers/IndentedStringBuilder.cs b/codehelp/CodeHelpers/IndentedStringBuilder.cs
@@ -1,5 +1,4 @@
 using System.Text;
-using Microsoft.CodeAnalysis;
 
 namespace WPILib.CodeHelpers;
 
diff --git a/codehelp/CodeHelpers/LogGenerator/LogAttributeInfo.cs b/codehelp/CodeHelpers/LogGenerator/LogAttributeInfo.cs
@@ -2,7 +2,6 @@
 using System.Text;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
-using Microsoft.CodeAnalysis.PooledObjects;
 using Stereologue;
 
 namespace WPILib.CodeHelpers.LogGenerator;
diff --git a/codehelp/CodeHelpers/LogGenerator/LoggableType.cs b/codehelp/CodeHelpers/LogGenerator/LoggableType.cs
@@ -4,7 +4,6 @@
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Text;
 using WPILib.CodeHelpers.LogGenerator.Analyzer;
-using static WPILib.CodeHelpers.IndentedStringBuilder;
 
 namespace WPILib.CodeHelpers.LogGenerator;
 
diff --git a/codehelp/CodeHelpers/LogGenerator/SourceGenerator/LogGeneratorVb.cs b/codehelp/CodeHelpers/LogGenerator/SourceGenerator/LogGeneratorVb.cs
@@ -1,5 +1,4 @@
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.VisualBasic.Syntax;
 
 namespace WPILib.CodeHelpers.LogGenerator.SourceGenerator;
diff --git a/codehelp/CodeHelpers/ParameterlessStructs/Analyzer/ParameterlessStructDiagnostics.cs b/codehelp/CodeHelpers/ParameterlessStructs/Analyzer/ParameterlessStructDiagnostics.cs
@@ -3,8 +3,6 @@ namespace WPILib.CodeHelpers.ParameterlessStructs.Analyzer;
 #pragma warning disable RS2008 // Enable analyzer release tracking
 
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.Diagnostics;
-using WPILib.CodeHelpers;
 
 public static class ParameterlessStructDiagnostics
 {
diff --git a/codehelp/CodeHelpers/SymbolExtensions.cs b/codehelp/CodeHelpers/SymbolExtensions.cs
@@ -1,5 +1,4 @@
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.CSharp.Syntax;
 
 namespace WPILib.CodeHelpers;
 
diff --git a/codehelp/CodeHelpers/TypeDeclarationModel.cs b/codehelp/CodeHelpers/TypeDeclarationModel.cs
@@ -1,5 +1,4 @@
 using System.Collections.Immutable;
-using System.Text;
 using Microsoft.CodeAnalysis;
 
 namespace WPILib.CodeHelpers;
diff --git a/dev/desktopDev/Program.cs b/dev/desktopDev/Program.cs
@@ -1,15 +1,10 @@
 using System;
 using System.IO;
 using System.Linq;
-using System.Runtime.InteropServices;
 using System.Text.Json;
-using CsCore;
-using CsCore.Raw;
 using UnitsNet.NumberExtensions.NumberToAngle;
 using WPIHal.Natives.Simulation;
 using WPIMath.Geometry;
-using WPIUtil;
-using WPIUtil.Natives;
 using WPIUtil.Serialization.Struct;
 
 namespace DesktopDev;
diff --git a/src/hal/CANStreamMessage.cs b/src/hal/CANStreamMessage.cs
@@ -16,7 +16,11 @@ public struct CANStreamMessage
     [System.Runtime.CompilerServices.InlineArray(8)]
     public struct DataBuffer
     {
+#pragma warning disable IDE0044 // Add readonly modifier
+#pragma warning disable IDE0051 // Remove unused private members
         private byte _element0;
+#pragma warning restore IDE0051 // Remove unused private members
+#pragma warning restore IDE0044 // Add readonly modifier
     }
 }
 
@@ -42,6 +46,10 @@ public CANMessage(ReadOnlySpan<byte> buffer, ulong timestamp)
     [InlineArray(8)]
     public struct DataBuffer
     {
+#pragma warning disable IDE0044 // Add readonly modifier
+#pragma warning disable IDE0051 // Remove unused private members
         private byte _element0;
+#pragma warning restore IDE0051 // Remove unused private members
+#pragma warning restore IDE0044 // Add readonly modifier
     }
 }
diff --git a/src/hal/JoystickAxis.cs b/src/hal/JoystickAxis.cs
@@ -11,13 +11,21 @@ public readonly struct JoystickAxes
     [System.Runtime.CompilerServices.InlineArray(NumJoystickAxes)]
     public struct AxesBuffer
     {
+#pragma warning disable IDE0044 // Add readonly modifier
+#pragma warning disable IDE0051 // Remove unused private members
         private float _element0;
+#pragma warning restore IDE0051 // Remove unused private members
+#pragma warning restore IDE0044 // Add readonly modifier
     }
 
     [System.Runtime.CompilerServices.InlineArray(NumJoystickAxes)]
     public struct RawBuffer
     {
+#pragma warning disable IDE0044 // Add readonly modifier
+#pragma warning disable IDE0051 // Remove unused private members
         private byte _element0;
+#pragma warning restore IDE0051 // Remove unused private members
+#pragma warning restore IDE0044 // Add readonly modifier
     }
     private readonly short m_count;
     private readonly AxesBuffer m_axes;
diff --git a/src/hal/JoystickDescriptor.cs b/src/hal/JoystickDescriptor.cs
@@ -34,7 +34,9 @@ public struct NativeJoystickDescriptor
         [System.Runtime.CompilerServices.InlineArray(256)]
         public struct NameBuffer
         {
+#pragma warning disable IDE0044 // Add readonly modifier
             private byte _element0;
+#pragma warning restore IDE0044 // Add readonly modifier
 
             public readonly unsafe string FromNullTerminatedString()
             {
@@ -49,7 +51,11 @@ public readonly unsafe string FromNullTerminatedString()
         [System.Runtime.CompilerServices.InlineArray(12)]
         public struct AxesTypeBuffer
         {
+#pragma warning disable IDE0044 // Add readonly modifier
+#pragma warning disable IDE0051 // Remove unused private members
             private byte _element0;
+#pragma warning restore IDE0051 // Remove unused private members
+#pragma warning restore IDE0044 // Add readonly modifier
 
             public readonly unsafe int[] FromRawBytes(int length)
             {
diff --git a/src/hal/JoystickPOVs.cs b/src/hal/JoystickPOVs.cs
@@ -11,7 +11,11 @@ public readonly struct JoystickPOVs
     [System.Runtime.CompilerServices.InlineArray(NumJoystickPOVs)]
     public struct PovsBuffer
     {
+#pragma warning disable IDE0044 // Add readonly modifier
+#pragma warning disable IDE0051 // Remove unused private members
         private short _element0;
+#pragma warning restore IDE0051 // Remove unused private members
+#pragma warning restore IDE0044 // Add readonly modifier
     }
 
     private readonly short m_count;
diff --git a/src/hal/Natives/Simulation/HalAccelerometerData.cs b/src/hal/Natives/Simulation/HalAccelerometerData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalAddressableLEDData.cs b/src/hal/Natives/Simulation/HalAddressableLEDData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_ConstBufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
diff --git a/src/hal/Natives/Simulation/HalAnalogGyroData.cs b/src/hal/Natives/Simulation/HalAnalogGyroData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalAnalogInData.cs b/src/hal/Natives/Simulation/HalAnalogInData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalAnalogOutData.cs b/src/hal/Natives/Simulation/HalAnalogOutData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalAnalogTriggerData.cs b/src/hal/Natives/Simulation/HalAnalogTriggerData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalCTREPCMData.cs b/src/hal/Natives/Simulation/HalCTREPCMData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalDIOData.cs b/src/hal/Natives/Simulation/HalDIOData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalDigitalPWMData.cs b/src/hal/Natives/Simulation/HalDigitalPWMData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalDutyCycleData.cs b/src/hal/Natives/Simulation/HalDutyCycleData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalEncoderData.cs b/src/hal/Natives/Simulation/HalEncoderData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalNotifierData.cs b/src/hal/Natives/Simulation/HalNotifierData.cs
@@ -1,7 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
-using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
 
diff --git a/src/hal/Natives/Simulation/HalPWMData.cs b/src/hal/Natives/Simulation/HalPWMData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalPowerDistributionData.cs b/src/hal/Natives/Simulation/HalPowerDistributionData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalREVPHData.cs b/src/hal/Natives/Simulation/HalREVPHData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalRelayData.cs b/src/hal/Natives/Simulation/HalRelayData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/HalSPIAccelerometerData.cs b/src/hal/Natives/Simulation/HalSPIAccelerometerData.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
diff --git a/src/hal/Natives/Simulation/NotifyListener.cs b/src/hal/Natives/Simulation/NotifyListener.cs
@@ -1,8 +1,3 @@
-using System.Runtime.CompilerServices;
-using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
-using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
-
 namespace WPIHal.Natives.Simulation;
 
 public static unsafe partial class HalNotifyListener
diff --git a/src/hal/Natives/Simulation/Reset.cs b/src/hal/Natives/Simulation/Reset.cs
@@ -1,7 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
-using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
 
diff --git a/src/newcommands/Command.cs b/src/newcommands/Command.cs
@@ -1,5 +1,3 @@
-using System;
-using System.Collections.Generic;
 using CommunityToolkit.Diagnostics;
 using WPIUtil.Sendable;
 
diff --git a/src/newcommands/ConditionalCommand.cs b/src/newcommands/ConditionalCommand.cs
@@ -6,7 +6,9 @@ public class ConditionalCommand : Command
 {
     private readonly Command m_onTrue;
     private readonly Command m_onFalse;
+#pragma warning disable IDE0052 // Remove unread private members
     private readonly Func<bool> m_condition;
+#pragma warning restore IDE0052 // Remove unread private members
 
     public ConditionalCommand(Command onTrue, Command onFalse, Func<bool> condition)
     {
diff --git a/src/newcommands/DeferredCommand.cs b/src/newcommands/DeferredCommand.cs
@@ -6,8 +6,10 @@ public class DeferredCommand : Command
 {
     private readonly Command m_nullCommand = new PrintCommand("[DeferredCommand] Supplied command was null!");
 
+#pragma warning disable IDE0052 // Remove unread private members
     private readonly Func<Command> m_supplier;
     private Command m_command;
+#pragma warning restore IDE0052 // Remove unread private members
 
     public DeferredCommand(Func<Command> supplier, HashSet<ISubsystem> requirements)
     {
diff --git a/src/ntcore/ConnectionInfo.cs b/src/ntcore/ConnectionInfo.cs
@@ -1,8 +1,9 @@
 using System.Runtime.InteropServices;
 using System.Runtime.InteropServices.Marshalling;
+using NetworkTables.Natives;
 using WPIUtil.Marshal;
 
-namespace NetworkTables.Natives;
+namespace NetworkTables;
 
 [NativeMarshalling(typeof(ConnectionInfoMarshaller))]
 [StructLayout(LayoutKind.Auto)]
diff --git a/src/ntcore/NetworkTable.cs b/src/ntcore/NetworkTable.cs
@@ -1,6 +1,5 @@
 using System.Collections.Concurrent;
 using NetworkTables.Handles;
-using NetworkTables.Natives;
 
 namespace NetworkTables;
 
diff --git a/src/ntcore/TopicInfo.cs b/src/ntcore/TopicInfo.cs
@@ -1,9 +1,10 @@
 using System.Runtime.InteropServices;
 using System.Runtime.InteropServices.Marshalling;
 using NetworkTables.Handles;
+using NetworkTables.Natives;
 using WPIUtil.Marshal;
 
-namespace NetworkTables.Natives;
+namespace NetworkTables;
 
 [NativeMarshalling(typeof(TopicInfoMarshaller))]
 [StructLayout(LayoutKind.Auto)]
diff --git a/src/stereologue/Attributes.cs b/src/stereologue/Attributes.cs
@@ -1,5 +1,3 @@
-using System;
-
 namespace Stereologue;
 
 [AttributeUsage(AttributeTargets.Property | AttributeTargets.Method | AttributeTargets.Field, Inherited = false, AllowMultiple = false)]
diff --git a/src/stereologue/LogType.cs b/src/stereologue/LogType.cs
@@ -1,5 +1,3 @@
-using System;
-
 namespace Stereologue;
 
 [Flags]
diff --git a/src/stereologue/Stereologuer.cs b/src/stereologue/Stereologuer.cs
@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using Google.Protobuf.WellKnownTypes;
 using NetworkTables;
 using WPIUtil.Logging;
 using WPIUtil.Serialization.Protobuf;
@@ -18,7 +17,9 @@ private Stereologuer() { }
 
     public static Stereologuer Logger { get; } = new();
 
+#pragma warning disable IDE0060 // Remove unused parameter
     public void Setup(string name, bool fileOnly, bool lazyLogging)
+#pragma warning restore IDE0060 // Remove unused parameter
     {
         rootPath = name;
         FileOnly = fileOnly;
diff --git a/src/wpilibsharp/DataLogManager.cs b/src/wpilibsharp/DataLogManager.cs
diff --git a/src/wpilibsharp/DriverStation.cs b/src/wpilibsharp/DriverStation.cs
diff --git a/src/wpilibsharp/IterativeRobotBase.cs b/src/wpilibsharp/IterativeRobotBase.cs
diff --git a/src/wpilibsharp/Notifier.cs b/src/wpilibsharp/Notifier.cs
diff --git a/src/wpilibsharp/RobotBase.cs b/src/wpilibsharp/RobotBase.cs
diff --git a/src/wpilibsharp/RobotController.cs b/src/wpilibsharp/RobotController.cs
diff --git a/src/wpilibsharp/Simulation/AddressableLEDSim.cs b/src/wpilibsharp/Simulation/AddressableLEDSim.cs
diff --git a/src/wpilibsharp/Simulation/CallbackStore.cs b/src/wpilibsharp/Simulation/CallbackStore.cs
diff --git a/src/wpilibsharp/Watchdog.cs b/src/wpilibsharp/Watchdog.cs
diff --git a/src/wpimath/MathSharedStore.cs b/src/wpimath/MathSharedStore.cs
diff --git a/src/wpiutil/Concurrent/Event.cs b/src/wpiutil/Concurrent/Event.cs
diff --git a/src/wpiutil/Concurrent/Synchronization.cs b/src/wpiutil/Concurrent/Synchronization.cs
diff --git a/src/wpiutil/Logging/DataLog.cs b/src/wpiutil/Logging/DataLog.cs
diff --git a/src/wpiutil/Natives/SynchronizationNative.cs b/src/wpiutil/Natives/SynchronizationNative.cs
diff --git a/src/wpiutil/Serialization/Struct/Parsing/Parser.cs b/src/wpiutil/Serialization/Struct/Parsing/Parser.cs

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`using System.Text;`
`2`		`-using Microsoft.CodeAnalysis;`
`3`	`2`
`4`	`3`	`namespace WPILib.CodeHelpers;`
`5`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`using Microsoft.CodeAnalysis;`
`2`		`-using Microsoft.CodeAnalysis.CSharp.Syntax;`
`3`	`2`	`using Microsoft.CodeAnalysis.VisualBasic.Syntax;`
`4`	`3`
`5`	`4`	`namespace WPILib.CodeHelpers.LogGenerator.SourceGenerator;`
Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,6 @@ namespace WPILib.CodeHelpers.ParameterlessStructs.Analyzer;`
`3`	`3`	`#pragma warning disable RS2008 // Enable analyzer release tracking`
`4`	`4`
`5`	`5`	`using Microsoft.CodeAnalysis;`
`6`		`-using Microsoft.CodeAnalysis.Diagnostics;`
`7`		`-using WPILib.CodeHelpers;`
`8`	`6`
`9`	`7`	`public static class ParameterlessStructDiagnostics`
`10`	`8`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`using System.Collections.Immutable;`
`2`		`-using System.Text;`
`3`	`2`	`using Microsoft.CodeAnalysis;`
`4`	`3`
`5`	`4`	`namespace WPILib.CodeHelpers;`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,11 @@ public struct CANStreamMessage`
`16`	`16`	`[System.Runtime.CompilerServices.InlineArray(8)]`
`17`	`17`	`public struct DataBuffer`
`18`	`18`	`{`
	`19`	`+#pragma warning disable IDE0044 // Add readonly modifier`
	`20`	`+#pragma warning disable IDE0051 // Remove unused private members`
`19`	`21`	`private byte _element0;`
	`22`	`+#pragma warning restore IDE0051 // Remove unused private members`
	`23`	`+#pragma warning restore IDE0044 // Add readonly modifier`
`20`	`24`	`}`
`21`	`25`	`}`
`22`	`26`
`@@ -42,6 +46,10 @@ public CANMessage(ReadOnlySpan<byte> buffer, ulong timestamp)`
`42`	`46`	`[InlineArray(8)]`
`43`	`47`	`public struct DataBuffer`
`44`	`48`	`{`
	`49`	`+#pragma warning disable IDE0044 // Add readonly modifier`
	`50`	`+#pragma warning disable IDE0051 // Remove unused private members`
`45`	`51`	`private byte _element0;`
	`52`	`+#pragma warning restore IDE0051 // Remove unused private members`
	`53`	`+#pragma warning restore IDE0044 // Add readonly modifier`
`46`	`54`	`}`
`47`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,13 +11,21 @@ public readonly struct JoystickAxes`
`11`	`11`	`[System.Runtime.CompilerServices.InlineArray(NumJoystickAxes)]`
`12`	`12`	`public struct AxesBuffer`
`13`	`13`	`{`
	`14`	`+#pragma warning disable IDE0044 // Add readonly modifier`
	`15`	`+#pragma warning disable IDE0051 // Remove unused private members`
`14`	`16`	`private float _element0;`
	`17`	`+#pragma warning restore IDE0051 // Remove unused private members`
	`18`	`+#pragma warning restore IDE0044 // Add readonly modifier`
`15`	`19`	`}`
`16`	`20`
`17`	`21`	`[System.Runtime.CompilerServices.InlineArray(NumJoystickAxes)]`
`18`	`22`	`public struct RawBuffer`
`19`	`23`	`{`
	`24`	`+#pragma warning disable IDE0044 // Add readonly modifier`
	`25`	`+#pragma warning disable IDE0051 // Remove unused private members`
`20`	`26`	`private byte _element0;`
	`27`	`+#pragma warning restore IDE0051 // Remove unused private members`
	`28`	`+#pragma warning restore IDE0044 // Add readonly modifier`
`21`	`29`	`}`
`22`	`30`	`private readonly short m_count;`
`23`	`31`	`private readonly AxesBuffer m_axes;`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,9 @@ public struct NativeJoystickDescriptor`
`34`	`34`	`[System.Runtime.CompilerServices.InlineArray(256)]`
`35`	`35`	`public struct NameBuffer`
`36`	`36`	`{`
	`37`	`+#pragma warning disable IDE0044 // Add readonly modifier`
`37`	`38`	`private byte _element0;`
	`39`	`+#pragma warning restore IDE0044 // Add readonly modifier`
`38`	`40`
`39`	`41`	`public readonly unsafe string FromNullTerminatedString()`
`40`	`42`	`{`
`@@ -49,7 +51,11 @@ public readonly unsafe string FromNullTerminatedString()`
`49`	`51`	`[System.Runtime.CompilerServices.InlineArray(12)]`
`50`	`52`	`public struct AxesTypeBuffer`
`51`	`53`	`{`
	`54`	`+#pragma warning disable IDE0044 // Add readonly modifier`
	`55`	`+#pragma warning disable IDE0051 // Remove unused private members`
`52`	`56`	`private byte _element0;`
	`57`	`+#pragma warning restore IDE0051 // Remove unused private members`
	`58`	`+#pragma warning restore IDE0044 // Add readonly modifier`
`53`	`59`
`54`	`60`	`public readonly unsafe int[] FromRawBytes(int length)`
`55`	`61`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,11 @@ public readonly struct JoystickPOVs`
`11`	`11`	`[System.Runtime.CompilerServices.InlineArray(NumJoystickPOVs)]`
`12`	`12`	`public struct PovsBuffer`
`13`	`13`	`{`
	`14`	`+#pragma warning disable IDE0044 // Add readonly modifier`
	`15`	`+#pragma warning disable IDE0051 // Remove unused private members`
`14`	`16`	`private short _element0;`
	`17`	`+#pragma warning restore IDE0051 // Remove unused private members`
	`18`	`+#pragma warning restore IDE0044 // Add readonly modifier`
`15`	`19`	`}`
`16`	`20`
`17`	`21`	`private readonly short m_count;`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-using System;`
`2`		`-using System.Collections.Generic;`
`3`	`1`	`using CommunityToolkit.Diagnostics;`
`4`	`2`	`using WPIUtil.Sendable;`
`5`	`3`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,9 @@ public class ConditionalCommand : Command`
`6`	`6`	`{`
`7`	`7`	`private readonly Command m_onTrue;`
`8`	`8`	`private readonly Command m_onFalse;`
	`9`	`+#pragma warning disable IDE0052 // Remove unread private members`
`9`	`10`	`private readonly Func<bool> m_condition;`
	`11`	`+#pragma warning restore IDE0052 // Remove unread private members`
`10`	`12`
`11`	`13`	`public ConditionalCommand(Command onTrue, Command onFalse, Func<bool> condition)`
`12`	`14`	`{`