Capability start/stop error handling

[jihoonl]

In the start_app logic,

start_app logic immediately returns failure response when it gets exception while enabling required capabilities. But it does not stop capabilities that are already started before getting into exception.

https://github.com/robotics-in-concert/rocon_app_platform/blob/hydro-devel/rocon_app_manager/src/rocon_app_manager/rapp_manager.py#L471-L498

[bit-pirate]

You are correct. Good catch. I'll tackle it ASAP.

Out of curiosity, did you actually run into this issue or did you just notice the missing logic?

[jihoonl]

just noticed. You might want to fix it sometime next week. rapp manager is under development now...

[bit-pirate]

Reminder for myself:

Possible solutions:

• Track successfully started capabilities
• Just stop all capabilities

[bit-pirate]

Possible solutions:

Track successfully started capabilities
Just stop all capabilities

Decided to implement the latter.

[stonier]

Still not merged, but code is still lying around in caps_start_stop_fix branch should we need to push this in at some point.