fix: address code review issues and rename to agent-ready

robotlearning123 · claude · robotlearning123 · commit 656525c72c2e · 2026-01-24T10:58:40.000-05:00
Code review fixes: - Replace CODEOWNERS placeholder with @robotlearning123 - Fix AGENTS.md placeholder text and add code block language - Remove brackets from ESLint/Prettier in CONTRIBUTING.md - Update factory_compat.yaml: 9→10 pillars, add multi-language build manifest - Add language tags to README.md fenced code blocks - Fix file-exists.ts: use null check for empty file handling - Fix github-workflow.ts: correct branch matching for all-branches triggers - Fix markdown.ts: dynamic padding for badge alignment - Harden regex.ts ReDoS detection with per-group stack tracking - Fix templates/AGENTS.md code block language - Fix test fixture README.md: npm run dev → npm run test - Fix subagent.ts: track natural completion vs hitting turn limit - Fix ollama.ts: buffer partial JSON lines across stream chunks - Fix sandbox/index.ts: add cwd validation to runDirect, prevent double-resolve Rename agent-readiness → agent-ready: - Update package.json name and repository URLs - Update all documentation references - Update source code comments and config files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
diff --git a/agent-readiness/.devcontainer/devcontainer.json b/agent-readiness/.devcontainer/devcontainer.json
@@ -1,5 +1,5 @@
 {
-  "name": "agent-readiness",
+  "name": "agent-ready",
   "image": "mcr.microsoft.com/devcontainers/typescript-node:20",
   "features": {
     "ghcr.io/devcontainers/features/git:1": {}
diff --git a/agent-readiness/.github/CODEOWNERS b/agent-readiness/.github/CODEOWNERS
@@ -1,18 +1,18 @@
-# Code ownership for agent-readiness
+# Code ownership for agent-ready
 # See https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
 
 # Default owners for everything in the repo
-* @{{GITHUB_USERNAME}}
+* @robotlearning123
 
 # Documentation
-/docs/ @{{GITHUB_USERNAME}}
-*.md @{{GITHUB_USERNAME}}
+/docs/ @robotlearning123
+*.md @robotlearning123
 
 # CI/CD configuration
-/.github/ @{{GITHUB_USERNAME}}
+/.github/ @robotlearning123
 
 # Source code
-/src/ @{{GITHUB_USERNAME}}
+/src/ @robotlearning123
 
 # Tests
-/test/ @{{GITHUB_USERNAME}}
+/test/ @robotlearning123
diff --git a/agent-readiness/AGENTS.md b/agent-readiness/AGENTS.md
@@ -4,7 +4,7 @@ This file provides instructions for AI agents working with this codebase.
 
 ## Project Overview
 
-agent-readiness is a [brief description of your project].
+agent-ready is a CLI tool that scans repositories for AI agent readiness, evaluating maturity across 10 pillars with 5 levels (L1-L5) using the Factory Agent Readiness model.
 
 ## Getting Started
 
@@ -39,10 +39,13 @@ npm run build
 
 ## Codebase Structure
 
-```
+```text
 src/
-├── index.ts          # Entry point
-├── [describe key directories]
+├── index.ts          # CLI entry point
+├── checks/           # Check implementations (file_exists, github_workflow, etc.)
+├── engine/           # Core scanning engine
+├── output/           # Output formatters (JSON, Markdown)
+└── utils/            # Shared utilities (regex, file cache, path validation)
 ```
 
 ## Key Conventions
diff --git a/agent-readiness/CONTRIBUTING.md b/agent-readiness/CONTRIBUTING.md
@@ -1,4 +1,4 @@
-# Contributing to agent-readiness
+# Contributing to agent-ready
 
 Thank you for your interest in contributing! This document provides guidelines and steps for contributing.
 
@@ -36,8 +36,8 @@ Please be respectful and constructive in all interactions.
 
 ```bash
 # Clone your fork
-git clone https://github.com/YOUR_USERNAME/agent-readiness.git
-cd agent-readiness
+git clone https://github.com/YOUR_USERNAME/agent-ready.git
+cd agent-ready
 
 # Install dependencies
 npm install
@@ -51,7 +51,7 @@ npm run dev
 
 ## Code Style
 
-- We use [ESLint/Prettier] for code formatting
+- We use ESLint and Prettier for code formatting
 - Run `npm run lint` before committing
 - Follow existing patterns in the codebase
 
diff --git a/agent-readiness/FACTORY_COMPARISON.md b/agent-readiness/FACTORY_COMPARISON.md
@@ -1,6 +1,6 @@
 # Factory Agent Readiness Comparison
 
-This document compares our agent-readiness implementation with [Factory's official Agent Readiness Model](https://docs.factory.ai/web/agent-readiness/overview).
+This document compares our agent-ready implementation with [Factory's official Agent Readiness Model](https://docs.factory.ai/web/agent-readiness/overview).
 
 ## Executive Summary
 
diff --git a/agent-readiness/README.md b/agent-readiness/README.md
@@ -1,10 +1,10 @@
-# agent-readiness
+# agent-ready
 
-Factory-compatible repo maturity scanner CLI tool that evaluates repositories against the **9 Pillars / 5 Levels** model and outputs actionable readiness reports for AI agents.
+Factory-compatible repo maturity scanner CLI tool that evaluates repositories against the **10 Pillars / 5 Levels** model and outputs actionable readiness reports for AI agents.
 
 ## Features
 
-- **9 Pillars Assessment**: Documentation, Code Style, Build, Testing, Security, Observability, Environment, CI/CD, Monorepo
+- **10 Pillars Assessment**: Documentation, Code Style, Build, Testing, Security, Observability, Environment, CI/CD, Monorepo, Task Discovery
 - **5 Maturity Levels**: L1 (Minimal) → L5 (Optimal)
 - **80% Gating Rule**: Levels achieved when ≥80% of checks pass AND all required checks pass
 - **Extensible Profiles**: YAML-based check definitions
@@ -63,7 +63,7 @@ npm run dev -- init --dry-run
 
 ### Terminal Output
 
-```
+```text
 Agent Readiness Report
 ──────────────────────────────────────────────────
 Repository: owner/repo
@@ -107,7 +107,7 @@ Action Items
 }
 ```
 
-## The 9 Pillars / 5 Levels Model
+## The 10 Pillars / 5 Levels Model
 
 ### Pillars
 
@@ -122,6 +122,7 @@ Action Items
 | **Environment** | .env.example templates |
 | **CI/CD** | GitHub workflows, triggers, actions |
 | **Monorepo** | Workspace configuration |
+| **Task Discovery** | Issue templates, PR templates |
 
 ### Levels
 
@@ -199,8 +200,8 @@ npm run build
 
 ## Project Structure
 
-```
-agent-readiness/
+```text
+agent-ready/
 ├── src/
 │   ├── index.ts              # CLI entry
 │   ├── types.ts              # Type definitions
diff --git a/agent-readiness/docker-compose.yml b/agent-readiness/docker-compose.yml
@@ -21,7 +21,7 @@ services:
   #   environment:
   #     POSTGRES_USER: dev
   #     POSTGRES_PASSWORD: dev_password
-  #     POSTGRES_DB: agent-readiness
+  #     POSTGRES_DB: agent-ready
   #   ports:
   #     - "5432:5432"
   #   volumes:
diff --git a/agent-readiness/package-lock.json b/agent-readiness/package-lock.json
diff --git a/agent-readiness/package.json b/agent-readiness/package.json
@@ -1,5 +1,5 @@
 {
-  "name": "agent-readiness",
+  "name": "agent-ready",
   "version": "0.1.0",
   "description": "Factory-compatible repo maturity scanner for AI agent readiness",
   "type": "module",
@@ -34,11 +34,11 @@
   },
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/robotlearning123/agent-readiness.git"
+    "url": "git+https://github.com/robotlearning123/agent-ready.git"
   },
-  "homepage": "https://github.com/robotlearning123/agent-readiness#readme",
+  "homepage": "https://github.com/robotlearning123/agent-ready#readme",
   "bugs": {
-    "url": "https://github.com/robotlearning123/agent-readiness/issues"
+    "url": "https://github.com/robotlearning123/agent-ready/issues"
   },
   "keywords": [
     "ai",
diff --git a/agent-readiness/profiles/factory_compat.yaml b/agent-readiness/profiles/factory_compat.yaml
@@ -1,11 +1,11 @@
 # Factory-Compatible Agent Readiness Profile
-# Evaluates repositories against the 9 Pillars / 5 Levels model
+# Evaluates repositories against the 10 Pillars / 5 Levels model
 
 name: factory_compat
 version: "1.0.0"
 description: >
   Default profile for evaluating repository maturity for AI agent readiness.
-  Based on the 9 Pillars model with 5 maturity levels (L1-L5).
+  Based on the 10 Pillars model with 5 maturity levels (L1-L5).
 
 checks:
   # =============================================================================
@@ -175,14 +175,42 @@ checks:
   # PILLAR: Build System (build)
   # =============================================================================
 
-  - id: build.package_json
-    name: Package manifest
-    description: package.json exists with build scripts
-    type: file_exists
+  - id: build.manifest
+    name: Build manifest
+    description: Repository has a primary build manifest
+    type: any_of
     pillar: build
     level: L1
     required: true
-    path: package.json
+    checks:
+      - id: build.package_json
+        name: package.json
+        type: file_exists
+        pillar: build
+        level: L1
+        required: false
+        path: package.json
+      - id: build.pyproject
+        name: pyproject.toml
+        type: file_exists
+        pillar: build
+        level: L1
+        required: false
+        path: pyproject.toml
+      - id: build.cargo_toml
+        name: Cargo.toml
+        type: file_exists
+        pillar: build
+        level: L1
+        required: false
+        path: Cargo.toml
+      - id: build.makefile
+        name: Makefile
+        type: file_exists
+        pillar: build
+        level: L1
+        required: false
+        path: Makefile
 
   - id: build.scripts
     name: Build scripts defined
diff --git a/agent-readiness/src/checks/file-exists.ts b/agent-readiness/src/checks/file-exists.ts
@@ -60,7 +60,7 @@ export async function executeFileExists(
   // Check content against regex
   const content = await readFileCached(filePath, context.file_cache);
 
-  if (!content) {
+  if (content === null) {
     return {
       check_id: check.id,
       check_name: check.name,
diff --git a/agent-readiness/src/checks/github-workflow.ts b/agent-readiness/src/checks/github-workflow.ts
@@ -129,13 +129,15 @@ function checkForEvent(
   requiredBranches?: string[]
 ): boolean {
   // String trigger: on: push
+  // Per GitHub docs, this triggers on ALL branches (no filter = all branches)
   if (typeof triggers === 'string') {
-    return triggers === event && !requiredBranches;
+    return triggers === event;
   }
 
   // Array trigger: on: [push, pull_request]
+  // Per GitHub docs, this triggers on ALL branches (no filter = all branches)
   if (Array.isArray(triggers)) {
-    return triggers.includes(event) && !requiredBranches;
+    return triggers.includes(event);
   }
 
   // Object trigger: on: { push: { branches: [main] } }
@@ -148,17 +150,23 @@ function checkForEvent(
     }
 
     // Event present but null (e.g., on: { push: })
+    // Per GitHub docs, no branches key means ALL branches
     if (eventConfig === null) {
-      return !requiredBranches;
+      return true;
     }
 
-    // No branch requirements
+    // No branch requirements from the check
     if (!requiredBranches) {
       return true;
     }
 
-    // Check branches
-    const configBranches = eventConfig.branches || [];
+    // No branches key in config means all branches (satisfies any requirement)
+    const configBranches = eventConfig.branches;
+    if (!configBranches || configBranches.length === 0) {
+      return true;
+    }
+
+    // Check that required branches are in the config's branch filter
     return requiredBranches.every((branch) => configBranches.includes(branch));
   }
 
diff --git a/agent-readiness/src/index.ts b/agent-readiness/src/index.ts
@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 /**
- * agent-readiness CLI entry point
+ * agent-ready CLI entry point
  *
  * Factory-compatible repo maturity scanner for AI agent readiness
  */
diff --git a/agent-readiness/src/output/markdown.ts b/agent-readiness/src/output/markdown.ts
@@ -71,11 +71,20 @@ function printLevelBadge(result: ScanResult): void {
   const level = result.level || 'none';
   const colorFn = LEVEL_COLORS[level];
   const levelName = result.level || 'Not Achieved';
+  const scoreStr = `Score: ${result.overall_score}%`;
+  const levelStr = `Level: ${levelName}`;
+
+  // Calculate padding for consistent alignment (inner width = 47 chars)
+  const innerWidth = 47;
+  const levelPadLeft = Math.floor((innerWidth - levelStr.length) / 2);
+  const levelPadRight = innerWidth - levelStr.length - levelPadLeft;
+  const scorePadLeft = Math.floor((innerWidth - scoreStr.length) / 2);
+  const scorePadRight = innerWidth - scoreStr.length - scorePadLeft;
 
   const badge = `┌─────────────────────────────────────────────────┐
 │                                                 │
-│          ${colorFn(`Level: ${levelName}`)}                          │
-│          ${chalk.dim(`Score: ${result.overall_score}%`)}                            │
+│${' '.repeat(levelPadLeft)}${colorFn(levelStr)}${' '.repeat(levelPadRight)}│
+│${' '.repeat(scorePadLeft)}${chalk.dim(scoreStr)}${' '.repeat(scorePadRight)}│
 │                                                 │
 └─────────────────────────────────────────────────┘`;
 
diff --git a/agent-readiness/src/types.ts b/agent-readiness/src/types.ts
@@ -1,5 +1,5 @@
 /**
- * Core type definitions for agent-readiness scanner
+ * Core type definitions for agent-ready scanner
  */
 
 // Cache interface compatible with both Map and LRUCache
diff --git a/agent-readiness/src/utils/regex.ts b/agent-readiness/src/utils/regex.ts
diff --git a/agent-readiness/templates/AGENTS.md b/agent-readiness/templates/AGENTS.md
diff --git a/agent-readiness/test/fixtures/standard-repo/README.md b/agent-readiness/test/fixtures/standard-repo/README.md
diff --git a/src/agents/subagent.ts b/src/agents/subagent.ts
diff --git a/src/providers/ollama.ts b/src/providers/ollama.ts
diff --git a/src/sandbox/index.ts b/src/sandbox/index.ts

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "name": "agent-readiness",`
	`2`	`+ "name": "agent-ready",`
`3`	`3`	`"image": "mcr.microsoft.com/devcontainers/typescript-node:20",`
`4`	`4`	`"features": {`
`5`	`5`	`"ghcr.io/devcontainers/features/git:1": {}`