Skip to content

Commit 9fcf688

Browse files
committed
Harden XMLSecurityDSig types after PHPStan analysis.
Narrow XPath results to DOMElement before attribute access, correct related PHPDocs, and guard failed queries so static analysis and runtime failure paths stay consistent.
1 parent cb3800a commit 9fcf688

2 files changed

Lines changed: 203 additions & 165 deletions

File tree

CHANGELOG.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,10 @@ Improvements:
124124
- Update parameter type in XMLSecurityDSig::addReference() and addRefInternal()
125125
- Tighten XMLSecEnc PHPDoc types for algorithm allowlists, references, and
126126
encrypt/decrypt return values
127+
- Harden XMLSecurityDSig DOM handling for static analysis: require DOMElement
128+
before attribute access on XPath results, correct locateSignature /
129+
reference / staticAdd509Cert PHPDocs, guard failed XPath queries and missing
130+
SignatureMethod nodes, and remove dead null comparisons
127131

128132
Bug Fixes:
129133
- Compact signature template (XMLSecurityDSig 'stripWhitespace' option) removes

0 commit comments

Comments
 (0)