php 8.0 is minimum allowed version (#271)

* php 8.0 is minimum allowed version

Author: robrichards

.github/workflows/ci.yml

@@ -3,50 +3,21 @@ name: Tests
 on: [push, pull_request]
 
 jobs:
-  tests-legacy:
-    name: PHP ${{ matrix.php-versions }} Tests
-    runs-on: ${{ matrix.operating-system }}
-    strategy:
-      matrix:
-        operating-system: ['ubuntu-latest']
-        php-versions: ['5.6']
-
-    steps:
-      - uses: shivammathur/setup-php@v2
-        with:
-          php-version: ${{ matrix.php-versions }}
-          extensions: openssl
-          tools: phpunit:4.8
-
-      - uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
 
-      - name: Install Composer packages
-        uses: ramsey/composer-install@v3
-
-      - name: Run tests
-        run: phpunit --coverage-clover clover.xml tests
-
-      - uses: codecov/codecov-action@v2
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          files: ./clover.xml
-
-  tests-older:
+  tests-eol:
     name: PHP ${{ matrix.php-versions }} Tests
     runs-on: ${{ matrix.operating-system }}
     strategy:
       matrix:
         operating-system: ['ubuntu-latest']
-        php-versions: ['7.0', '7.1']
+        php-versions: ['8.0', '8.1']
 
     steps:
       - uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php-versions }}
           extensions: openssl
-          tools: phpunit:6.5
+          tools: phpunit/phpunit:9.6
 
       - uses: actions/checkout@v3
         with:
@@ -63,20 +34,20 @@ jobs:
           token: ${{ secrets.CODECOV_TOKEN }}
           files: ./clover.xml
 
-  tests-old:
+  tests-support:
     name: PHP ${{ matrix.php-versions }} Tests
     runs-on: ${{ matrix.operating-system }}
     strategy:
       matrix:
         operating-system: ['ubuntu-latest']
-        php-versions: ['7.2', '7.3', '7.4']
+        php-versions: ['8.2', '8.3']
 
     steps:
       - uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php-versions }}
           extensions: openssl
-          tools: phpunit:8.5
+          tools: phpunit/phpunit:9.6
 
       - uses: actions/checkout@v3
         with:
@@ -99,7 +70,7 @@ jobs:
     strategy:
       matrix:
         operating-system: ['ubuntu-latest']
-        php-versions: ['8.0', '8.1']
+        php-versions: ['8.4', '8.5']
 
     steps:
       - uses: shivammathur/setup-php@v2

README.md

@@ -6,14 +6,15 @@ The author of xmlseclibs is Rob Richards.
 
 # Branches
 Master is currently the only actively maintained branch.
-* master/3.1: Added AES-GCM support requiring 7.1+
+* master: requires PHP version 8.0+
+* 3.1: Added AES-GCM support requiring 7.1+
 * 3.0: Removes mcrypt usage requiring 5.4+ (5.6.24+ recommended for security reasons)
 * 2.0: Contains namespace support requiring 5.3+
 * 1.4: Contains auto-loader support while also maintaining backwards compatiblity with the older 1.3 version using the xmlseclibs.php file. Supports PHP 5.2+
 
 # Requirements
 
-xmlseclibs requires PHP version 5.4 or greater. **5.6.24+ recommended for security reasons**
+xmlseclibs requires PHP version 8.0 or greater.
 
 
 ## How to Install

composer.json

@@ -15,7 +15,7 @@
     }
   },
   "require": {
-    "php": ">= 5.6.1",
+    "php": ">= 8.0",
     "ext-openssl": "*",
     "phpseclib/phpseclib": "~3.0"
   }

src/XMLSecurityKey.php

@@ -440,9 +440,6 @@ private function encryptSymmetric($data)
         $this->iv = openssl_random_pseudo_bytes(openssl_cipher_iv_length($this->cryptParams['cipher']));
         $authTag = null;
         if(in_array($this->cryptParams['cipher'], ['aes-128-gcm', 'aes-192-gcm', 'aes-256-gcm'])) {
-            if (version_compare(PHP_VERSION, '7.1.0') < 0) {
-                throw new Exception('PHP 7.1.0 is required to use AES GCM algorithms');
-            }
             $authTag = openssl_random_pseudo_bytes(self::AUTHTAG_LENGTH);
             $encrypted = openssl_encrypt($data, $this->cryptParams['cipher'], $this->key, OPENSSL_RAW_DATA, $this->iv, $authTag);
         } else {
@@ -469,9 +466,6 @@ private function decryptSymmetric($data)
         $data = substr($data, $iv_length);
         $authTag = null;
         if(in_array($this->cryptParams['cipher'], ['aes-128-gcm', 'aes-192-gcm', 'aes-256-gcm'])) {
-            if (version_compare(PHP_VERSION, '7.1.0') < 0) {
-                throw new Exception('PHP 7.1.0 is required to use AES GCM algorithms');
-            }
             // obtain and remove the authentication tag
             $offset = 0 - self::AUTHTAG_LENGTH;
             $authTag = substr($data, $offset);

tests/saml/saml-decrypt.phpt

@@ -5,12 +5,6 @@ Basic Decryption
 require(dirname(__FILE__) . '/../../xmlseclibs.php');
 use RobRichards\XMLSecLibs\XMLSecEnc;
 
- // Travis not honoring SKIPIF
- if (version_compare(PHP_VERSION, '7.1.0') < 0) {
-	print "KYzsRqRzQY5qp+bv9T8bHA/AvsI=\n";
-	exit;
- }
-
 /* When we need to locate our own key based on something like a key name */
 function locateLocalKey($objKey) {
 	/* In this example the key is identified by filename */

tests/xml-sign-sha256-rsa-sha256.phpt

@@ -1,7 +1,5 @@
 --TEST--
 Signature RSA SHA256
---SKIPIF--
-<?php if (version_compare(PHP_VERSION, '5.3.0', '<')) die('SKIP Requires PHP version 5.3.0 or newer.'); ?>
 --FILE--
 <?php
 require(dirname(__FILE__) . '/../xmlseclibs.php');

tests/xmlsec-decrypt.phpt

@@ -25,12 +25,6 @@ foreach ($arTests AS $testName=>$testFile) {
 	$output = NULL;
 	print "$testName: ";
 
-	// Skip AES tests is PHP < 7.1.0
-	if ((substr($testName, 0, 3) === "AES") && (version_compare(PHP_VERSION, '7.1.0') < 0)) {
-		print "Passed\n";
-		continue;
-	}
-
 	$doc->load(dirname(__FILE__) . "/$testFile");
 
 	try {

tests/xmlsec-encrypt-aes-gmc.phpt

@@ -19,11 +19,6 @@ foreach ($arTests AS $testName=>$testParams) {
 	}
 
 	print "$testName: ";
-	// Travis not honoring SKIPIF
-	if (version_compare(PHP_VERSION, '7.1.0') < 0) {
-		print "EncryptedData\n";
-		continue;
-	}
 
 	$dom = new DOMDocument();
 	$dom->load(dirname(__FILE__) . '/basic-doc.xml');

tests/xmlsec-verify-rsa-sha256.phpt

@@ -1,7 +1,5 @@
 --TEST--
 Verify RSA SHA256
---SKIPIF--
-<?php if (version_compare(PHP_VERSION, '5.3.0', '<')) die('SKIP Requires PHP version 5.3.0 or newer.'); ?>
 --FILE--
 <?php
 require(dirname(__FILE__) . '/../xmlseclibs.php');