Skip to content

Commit 50cafa6

Browse files
authored
Update upstream agent to 2.24.0-SNAPSHOT (signalfx#2572)
* Update upstream agent to 2.24.0-SNAPSHOT * update licenses * Hopefully fix declarative config used check * Hopefully fix declarative config used check
1 parent 43a46ed commit 50cafa6

File tree

7 files changed

+13
-16
lines changed

7 files changed

+13
-16
lines changed

custom/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ dependencies {
88
compileOnly("io.opentelemetry.semconv:opentelemetry-semconv-incubating")
99
compileOnly("io.opentelemetry.instrumentation:opentelemetry-instrumentation-api")
1010
compileOnly("io.opentelemetry.instrumentation:opentelemetry-resources")
11+
compileOnly("io.opentelemetry.instrumentation:opentelemetry-declarative-config-bridge")
1112
compileOnly("io.opentelemetry.javaagent:opentelemetry-javaagent-extension-api")
1213
compileOnly("io.opentelemetry.javaagent:opentelemetry-javaagent-tooling")
1314
compileOnly("io.opentelemetry.javaagent:opentelemetry-javaagent-internal-logging-simple")

custom/src/main/java/com/splunk/opentelemetry/servicename/ServiceNameChecker.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@
2020
import static io.opentelemetry.sdk.autoconfigure.AutoConfigureUtil.getResource;
2121

2222
import com.google.auto.service.AutoService;
23-
import io.opentelemetry.api.incubator.config.ConfigProvider;
24-
import io.opentelemetry.api.incubator.config.GlobalConfigProvider;
2523
import io.opentelemetry.javaagent.tooling.BeforeAgentListener;
24+
import io.opentelemetry.sdk.autoconfigure.AutoConfigureUtil;
2625
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
2726
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
2827
import io.opentelemetry.sdk.resources.Resource;
@@ -52,7 +51,7 @@ public void beforeAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredOpenTelemet
5251
ConfigProperties config = getConfig(autoConfiguredOpenTelemetrySdk);
5352
Resource resource = getResource(autoConfiguredOpenTelemetrySdk);
5453
if (serviceNameNotConfigured(config, resource)) {
55-
if (isDeclarativeConfigInUse()) {
54+
if (AutoConfigureUtil.isDeclarativeConfig(autoConfiguredOpenTelemetrySdk)) {
5655
logWarn.accept(
5756
"The service.name resource attribute is not set. Your service is unnamed and will be difficult to identify.\n"
5857
+ " Set your service name in '.resource.attributes' node, or specify appropriate resource detector in the configuration YAML file.");
@@ -78,8 +77,4 @@ static boolean serviceNameNotConfigured(ConfigProperties config, Resource resour
7877
&& !resourceAttributes.containsKey(ServiceAttributes.SERVICE_NAME.getKey())
7978
&& "unknown_service:java".equals(resource.getAttribute(ServiceAttributes.SERVICE_NAME));
8079
}
81-
82-
private static boolean isDeclarativeConfigInUse() {
83-
return !GlobalConfigProvider.get().equals(ConfigProvider.noop());
84-
}
8580
}

custom/src/main/java/io/opentelemetry/sdk/autoconfigure/AutoConfigureUtil.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
import io.opentelemetry.api.incubator.config.ConfigProvider;
2222
import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
23+
import io.opentelemetry.instrumentation.config.bridge.ConfigPropertiesBackedConfigProvider;
2324
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
2425
import io.opentelemetry.sdk.resources.Resource;
2526
import java.util.logging.Logger;
@@ -46,7 +47,7 @@ public static ConfigProperties getConfig(AutoConfiguredOpenTelemetrySdk sdk) {
4647
}
4748

4849
public static boolean isDeclarativeConfig(AutoConfiguredOpenTelemetrySdk sdk) {
49-
return sdk.getConfigProvider() != null;
50+
return !(sdk.getConfigProvider() instanceof ConfigPropertiesBackedConfigProvider);
5051
}
5152

5253
@Nullable

dependencyManagement/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ plugins {
44

55
val otelVersion = "1.57.0"
66
val otelAlphaVersion = otelVersion.replaceFirst("(-SNAPSHOT)?$".toRegex(), "-alpha$1")
7-
val otelInstrumentationVersion = "2.23.0"
7+
val otelInstrumentationVersion = "2.24.0-SNAPSHOT"
88
val otelInstrumentationAlphaVersion = otelInstrumentationVersion.replaceFirst("(-SNAPSHOT)?$".toRegex(), "-alpha$1")
99
val otelContribAlphaVersion = "1.52.0-alpha"
1010

instrumentation/jdbc/src/main/java/com/splunk/opentelemetry/instrumentation/jdbc/SqlCommenterInitializer.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@
1717
package com.splunk.opentelemetry.instrumentation.jdbc;
1818

1919
import com.google.auto.service.AutoService;
20+
import io.opentelemetry.api.GlobalOpenTelemetry;
2021
import io.opentelemetry.context.propagation.TextMapPropagator;
22+
import io.opentelemetry.instrumentation.api.incubator.config.internal.DeclarativeConfigUtil;
2123
import io.opentelemetry.instrumentation.api.incubator.semconv.db.internal.SqlCommenterBuilder;
22-
import io.opentelemetry.javaagent.bootstrap.internal.AgentInstrumentationConfig;
2324
import io.opentelemetry.javaagent.bootstrap.internal.sqlcommenter.SqlCommenterCustomizer;
2425

2526
@AutoService(SqlCommenterCustomizer.class)
@@ -30,8 +31,8 @@ public class SqlCommenterInitializer implements SqlCommenterCustomizer {
3031
@Override
3132
public void customize(SqlCommenterBuilder sqlCommenterBuilder) {
3233
sqlCommenterBuilder.setEnabled(
33-
AgentInstrumentationConfig.get()
34-
.getBoolean("otel.instrumentation.splunk-jdbc.enabled", false));
34+
DeclarativeConfigUtil.getInstrumentationConfig(GlobalOpenTelemetry.get(), "splunk-jdbc")
35+
.getBoolean("enabled", false));
3536
sqlCommenterBuilder.setPropagator(
3637
(connection, executed) -> {
3738
// note that besides jdbc this applies to r2dbc and other data access apis that upstream

licenses/licenses.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
# splunk-otel-javaagent
33
## Dependency License Report
4-
_2025-12-18 12:57:18 EET_
4+
_2026-01-07 08:08:24 EET_
55
## Apache License, Version 2.0
66

77
**1** **Group:** `com.squareup.okhttp3` **Name:** `okhttp` **Version:** `5.3.2`
@@ -92,7 +92,7 @@ _2025-12-18 12:57:18 EET_
9292
> - **POM Project URL**: [https://github.com/open-telemetry/opentelemetry-java-contrib](https://github.com/open-telemetry/opentelemetry-java-contrib)
9393
> - **POM License**: Apache License, Version 2.0 - [https://www.apache.org/licenses/LICENSE-2.0](https://www.apache.org/licenses/LICENSE-2.0)
9494
95-
**23** **Group:** `io.opentelemetry.instrumentation` **Name:** `opentelemetry-instrumentation-bom-alpha` **Version:** `2.23.0-alpha`
95+
**23** **Group:** `io.opentelemetry.instrumentation` **Name:** `opentelemetry-instrumentation-bom-alpha` **Version:** `2.24.0-alpha-SNAPSHOT`
9696
> - **POM Project URL**: [https://github.com/open-telemetry/opentelemetry-java-instrumentation](https://github.com/open-telemetry/opentelemetry-java-instrumentation)
9797
> - **POM License**: Apache License, Version 2.0 - [https://www.apache.org/licenses/LICENSE-2.0](https://www.apache.org/licenses/LICENSE-2.0)
9898

testing/agent-test-extension/src/main/java/com/splunk/opentelemetry/testing/IgnoredTestTypesConfigurer.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,11 @@
1919
import com.google.auto.service.AutoService;
2020
import io.opentelemetry.javaagent.extension.ignore.IgnoredTypesBuilder;
2121
import io.opentelemetry.javaagent.extension.ignore.IgnoredTypesConfigurer;
22-
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
2322

2423
@AutoService(IgnoredTypesConfigurer.class)
2524
public class IgnoredTestTypesConfigurer implements IgnoredTypesConfigurer {
2625
@Override
27-
public void configure(IgnoredTypesBuilder builder, ConfigProperties config) {
26+
public void configure(IgnoredTypesBuilder builder) {
2827
// we don't want to instrument auto-generated mocks
2928
builder
3029
.ignoreClass("org.mockito")

0 commit comments

Comments
 (0)