Skip to content

Commit f4f9a8d

Browse files
committed
fix: remove createCRUDBuilder
1 parent 39393a3 commit f4f9a8d

File tree

5 files changed

+6
-38
lines changed

5 files changed

+6
-38
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ You can also control optional outputs from the generator:
9292

9393
- **--skip-types**: Skip generating table `Row[]` type exports.
9494
- **--skip-builder**: Skip generating the query `createBuilder` export.
95-
- **--skip-crud**: Skip generating the CRUD mutator `createCRUDBuilder` export.
9695
- **--skip-declare**: Skip generating the module augmentation for default types in Zero.
9796
- **--enable-legacy-mutators**: Enable legacy CRUD mutators (sets `enableLegacyMutators` to `true` in the generated schema).
9897
- **--enable-legacy-queries**: Enable legacy CRUD queries (sets `enableLegacyQueries` to `true` in the generated schema).

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "drizzle-zero",
3-
"version": "0.17.0-canary.1",
3+
"version": "0.17.0-canary.2",
44
"description": "Generate Zero schemas from Drizzle ORM schemas",
55
"type": "module",
66
"scripts": {

src/cli/index.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ export interface GeneratorOptions {
6161
jsFileExtension?: boolean;
6262
skipTypes?: boolean;
6363
skipBuilder?: boolean;
64-
skipCrud?: boolean;
6564
skipDeclare?: boolean;
6665
enableLegacyMutators?: boolean;
6766
enableLegacyQueries?: boolean;
@@ -79,7 +78,6 @@ async function main(opts: GeneratorOptions = {}) {
7978
jsFileExtension,
8079
skipTypes,
8180
skipBuilder,
82-
skipCrud,
8381
skipDeclare,
8482
enableLegacyMutators,
8583
enableLegacyQueries,
@@ -152,7 +150,6 @@ async function main(opts: GeneratorOptions = {}) {
152150
jsExtensionOverride: jsFileExtension ? 'force' : 'auto',
153151
skipTypes: Boolean(skipTypes),
154152
skipBuilder: Boolean(skipBuilder),
155-
skipCrud: Boolean(skipCrud),
156153
skipDeclare: Boolean(skipDeclare),
157154
enableLegacyMutators: Boolean(enableLegacyMutators),
158155
enableLegacyQueries: Boolean(enableLegacyQueries),
@@ -204,7 +201,6 @@ function cli() {
204201
)
205202
.option('--skip-types', 'Skip generating table Row[] type exports', false)
206203
.option('--skip-builder', 'Skip generating the builder export', false)
207-
.option('--skip-crud', 'Skip generating the CRUD builder export', false)
208204
.option(
209205
'--skip-declare',
210206
'Skip generating the module augmentation for default types in Zero',
@@ -234,7 +230,6 @@ function cli() {
234230
jsFileExtension: command.jsFileExtension,
235231
skipTypes: command.skipTypes,
236232
skipBuilder: command.skipBuilder,
237-
skipCrud: command.skipCrud,
238233
skipDeclare: command.skipDeclare,
239234
enableLegacyMutators: command.enableLegacyMutators,
240235
enableLegacyQueries: command.enableLegacyQueries,

src/cli/shared.ts

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ export function getGeneratedSchema({
1717
jsExtensionOverride = 'auto',
1818
skipTypes = false,
1919
skipBuilder = false,
20-
skipCrud = false,
2120
skipDeclare = false,
2221
enableLegacyMutators = false,
2322
enableLegacyQueries = false,
@@ -31,7 +30,6 @@ export function getGeneratedSchema({
3130
jsExtensionOverride?: 'auto' | 'force' | 'none';
3231
skipTypes?: boolean;
3332
skipBuilder?: boolean;
34-
skipCrud?: boolean;
3533
skipDeclare?: boolean;
3634
enableLegacyMutators?: boolean;
3735
enableLegacyQueries?: boolean;
@@ -568,30 +566,6 @@ export function getGeneratedSchema({
568566
});
569567
}
570568

571-
// Add CRUD builder export
572-
if (!skipCrud) {
573-
zeroSchemaGenerated.addImportDeclaration({
574-
moduleSpecifier: '@rocicorp/zero',
575-
namedImports: [{name: 'createCRUDBuilder'}],
576-
});
577-
578-
const crudVariable = zeroSchemaGenerated.addVariableStatement({
579-
declarationKind: VariableDeclarationKind.Const,
580-
isExported: true,
581-
declarations: [
582-
{
583-
name: 'crud',
584-
initializer: `createCRUDBuilder(${schemaObjectName})`,
585-
},
586-
],
587-
});
588-
589-
crudVariable.addJsDoc({
590-
description:
591-
'\nRepresents the CRUD builder.\nThis type is auto-generated from your Drizzle schema definition.',
592-
});
593-
}
594-
595569
// Add module augmentation for default types
596570
if (!skipDeclare) {
597571
zeroSchemaGenerated.addStatements(writer => {

tests/cli.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ describe('getGeneratedSchema', () => {
137137
// You should NOT make any changes in this file as it will be overwritten.
138138
139139
import type { Row } from "@rocicorp/zero";
140-
import { createBuilder, createCRUDBuilder } from "@rocicorp/zero";
140+
import { createBuilder } from "@rocicorp/zero";
141141
import type { ZeroCustomType } from "drizzle-zero";
142142
import type { schema as zeroSchema } from "./tests/schemas/one-to-one.zero";
143143
@@ -1048,7 +1048,7 @@ describe('getGeneratedSchema', () => {
10481048

10491049
// Check for @rocicorp/zero imports
10501050
expect(generatedSchema).toContain(
1051-
'import { createBuilder, createCRUDBuilder } from "@rocicorp/zero";',
1051+
'import { createBuilder } from "@rocicorp/zero";',
10521052
);
10531053
expect(generatedSchema).toContain(
10541054
'import type { Row } from "@rocicorp/zero";',
@@ -1213,7 +1213,7 @@ describe('getGeneratedSchema', () => {
12131213

12141214
// Check for all the new imports
12151215
expect(generatedSchema).toContain(
1216-
'import { createBuilder, createCRUDBuilder } from "@rocicorp/zero";',
1216+
'import { createBuilder } from "@rocicorp/zero";',
12171217
);
12181218
expect(generatedSchema).toContain(
12191219
'import type { Row } from "@rocicorp/zero";',
@@ -1255,7 +1255,7 @@ describe('getGeneratedSchema', () => {
12551255

12561256
// Should still include builder export but not Row import when no tables
12571257
expect(generatedSchema).toContain(
1258-
'import { createBuilder, createCRUDBuilder } from "@rocicorp/zero";',
1258+
'import { createBuilder } from "@rocicorp/zero";',
12591259
);
12601260
expect(generatedSchema).not.toContain(
12611261
'import type { Row } from "@rocicorp/zero";',
@@ -1307,7 +1307,7 @@ describe('getGeneratedSchema', () => {
13071307

13081308
// Builder should still be present
13091309
expect(generatedSchema).toContain(
1310-
'import { createBuilder, createCRUDBuilder } from "@rocicorp/zero";',
1310+
'import { createBuilder } from "@rocicorp/zero";',
13111311
);
13121312
expect(generatedSchema).toContain(
13131313
'export const zql = createBuilder(schema);',

0 commit comments

Comments
 (0)