chore: remove timeout argument of wait_termination

It's always zero now that we don't depend on orocos.rb for the remote manager

Author: doudou

lib/syskit/process_managers/in_process/manager.rb

@@ -97,7 +97,7 @@ def create_log_dir(log_dir, time_tag, metadata = {}); end
                 #
                 # Returns a hash that maps deployment names to the Status
                 # object that represents their exit status.
-                def wait_termination(_timeout = nil)
+                def wait_termination
                     dead_processes = {}
                     processes.delete_if do |_, process|
                         next unless process.dead?

lib/syskit/process_managers/ruby_tasks/manager.rb

@@ -75,7 +75,7 @@ def create_log_dir(log_dir, time_tag, metadata = {}); end
                 #
                 # Returns a hash that maps deployment names to the Status
                 # object that represents their exit status.
-                def wait_termination(_timeout = nil)
+                def wait_termination
                     result = terminated_deployments
                     @terminated_deployments = {}
                     result

lib/syskit/process_managers/unmanaged/manager.rb

@@ -106,7 +106,7 @@ def create_log_dir(log_dir, time_tag, metadata = {}); end
                 #
                 # Returns a hash that maps deployment names to the Status
                 # object that represents their exit status.
-                def wait_termination(_timeout = nil)
+                def wait_termination
                     # Verify that the monitor threads are in a good state, and
                     # gather the ones that are actually dead
                     dead_processes = {}

lib/syskit/roby_app/configuration.rb

@@ -654,7 +654,7 @@ def process_server(*args)
             end
 
             ModelOnlyServer = Struct.new :loader do
-                def wait_termination(timeout = 0)
+                def wait_termination
                     []
                 end
 

lib/syskit/runtime/update_deployment_states.rb

@@ -19,7 +19,7 @@ def self.handle_dead_deployments(plan)
             server_config = Syskit.conf.each_process_server_config.to_a
             server_config.each do |config|
                 begin
-                    dead_deployments = config.client.wait_termination(0)
+                    dead_deployments = config.client.wait_termination
                 rescue ::Exception => e
                     deployments = abort_process_server(plan, config)
                     all_dead_deployments.merge(deployments)

test/process_managers/test_unmanaged.rb

@@ -142,8 +142,8 @@ module ProcessManagers
                             .and_raise(RuntimeError)
                         capture_log(process, :fatal) do
                             assert_equal [process],
-                                         process_manager.wait_termination(0).keys
-                            assert_equal({}, process_manager.wait_termination(0))
+                                         process_manager.wait_termination.keys
+                            assert_equal({}, process_manager.wait_termination)
                         end
                     ensure (
                         process_manager.processes[@unmanaged_task_name] = process

test/runtime/test_update_deployment_state.rb

@@ -13,7 +13,7 @@ def initialize
                 @loader = FlexMock.undefined
             end
 
-            def wait_termination(*)
+            def wait_termination
                 dead_processes = @killed_processes
                 @killed_processes = []
                 dead_processes

test/test_deployment.rb

@@ -12,7 +12,7 @@ def initialize
             @loader = FlexMock.undefined
         end
 
-        def wait_termination(*)
+        def wait_termination
             dead_processes = @killed_processes
             @killed_processes = []
             dead_processes