fix: fix links to fragments (#84)

Author: tylerdave

src/rockgarden/content/store.py

@@ -7,7 +7,7 @@
 from typing import TYPE_CHECKING
 
 from rockgarden.content.models import Page
-from rockgarden.urls import get_url
+from rockgarden.urls import get_url, slugify_heading
 
 if TYPE_CHECKING:
     from rockgarden.content.collection import Collection
@@ -121,7 +121,7 @@ def resolve_link(self, link_target: str) -> str | None:
         if page:
             url = get_url(page.slug, self.clean_urls, self.base_path)
             if fragment:
-                url = f"{url}#{fragment}"
+                url = f"{url}#{slugify_heading(fragment)}"
             return url
 
         # Try to resolve as a media file

src/rockgarden/nav/toc.py

@@ -4,6 +4,8 @@
 from dataclasses import dataclass, field
 from html import unescape
 
+from rockgarden.urls import slugify_heading
+
 HEADING_RE = re.compile(r"<(h[2-6])(\s[^>]*)?>(.+?)</\1>", re.DOTALL)
 TAG_RE = re.compile(r"<[^>]+>")
 
@@ -18,14 +20,6 @@ class TocEntry:
     children: list["TocEntry"] = field(default_factory=list)
 
 
-def _slugify(text: str) -> str:
-    """Convert heading text to a URL-friendly slug."""
-    text = text.lower()
-    text = re.sub(r"[^\w\s-]", "", text)
-    text = re.sub(r"[\s]+", "-", text.strip())
-    return text
-
-
 def _strip_tags(html: str) -> str:
     """Remove HTML tags and unescape entities to get plain text."""
     return unescape(TAG_RE.sub("", html).strip())
@@ -78,7 +72,7 @@ def _replace_heading(match: re.Match) -> str:
         if level < min_level or level > max_level:
             # Still inject ID for anchor linking, but don't add to TOC
             text = _strip_tags(inner_html)
-            slug = _slugify(text)
+            slug = slugify_heading(text)
             if not slug:
                 return match.group(0)
             if slug in seen_ids:
@@ -91,7 +85,7 @@ def _replace_heading(match: re.Match) -> str:
             return f'<{tag}{attrs} id="{slug}">{inner_html}</{tag}>'
 
         text = _strip_tags(inner_html)
-        slug = _slugify(text)
+        slug = slugify_heading(text)
         if not slug:
             return match.group(0)
 

src/rockgarden/urls.py

@@ -4,6 +4,18 @@
 from urllib.parse import quote, urlparse
 
 
+def slugify_heading(text: str) -> str:
+    """Convert heading text to a URL-friendly slug.
+
+    Matches the slugification used for heading anchor IDs so that
+    fragment links like ``[[Page#My Heading]]`` resolve correctly.
+    """
+    text = text.lower()
+    text = re.sub(r"[^\w\s-]", "", text)
+    text = re.sub(r"[\s]+", "-", text.strip())
+    return text
+
+
 def normalize_tag(tag: str) -> str:
     """Normalize a tag to a URL-safe slug.
 

tests/test_content_store.py

@@ -46,7 +46,7 @@ def test_section_link(self):
         store = ContentStore([page])
 
         url = store.resolve_link("Chamber of the Stone#Thalador")
-        assert url == "/chamber-of-the-stone/#Thalador"
+        assert url == "/chamber-of-the-stone/#thalador"
 
     def test_section_link_with_spaces(self):
         """Should preserve spaces in section fragment."""
@@ -59,7 +59,7 @@ def test_section_link_with_spaces(self):
         store = ContentStore([page])
 
         url = store.resolve_link("Session Log#Group Vision")
-        assert url == "/session-log/#Group Vision"
+        assert url == "/session-log/#group-vision"
 
     def test_section_link_whitespace_trimmed(self):
         """Should trim whitespace around page name and fragment."""
@@ -72,7 +72,7 @@ def test_section_link_whitespace_trimmed(self):
         store = ContentStore([page])
 
         url = store.resolve_link("Notes  #  Section  ")
-        assert url == "/notes/#Section"
+        assert url == "/notes/#section"
 
     def test_broken_link_returns_none(self):
         """Should return None for non-existent page."""