refactor: improve type safety in test files - Add QuestionNode interface, replace any types, fix formatting

Author: FoggyMtnDrifter

src/components/__tests__/QuestionNode.utils.test.ts

@@ -1,14 +1,21 @@
 import { describe, it, expect } from 'vitest';
+
 import { questionTree } from '../../questions/questions';
 
+interface QuestionNode {
+  id: string;
+  link?: string | null;
+  options?: QuestionNode[];
+}
+
 // Import the utility functions from QuestionNode
 // Since they're not exported, we'll recreate them here for testing
 const findNodeById = (
-  node: any,
+  node: QuestionNode,
   id: string
-): { currentNode: any; parentNode: any | null; optionIndex: number } | null => {
+): { currentNode: QuestionNode; parentNode: QuestionNode | null; optionIndex: number } | null => {
   if (node.options) {
-    const directOptionIndex = node.options.findIndex((option: any) => option.id === id);
+    const directOptionIndex = node.options.findIndex(option => option.id === id);
     if (directOptionIndex !== -1) {
       const targetNode = node.options[directOptionIndex];
       if (targetNode.options) {
@@ -91,7 +98,7 @@ describe('QuestionNode Utilities', () => {
     it('returns random items with roughly even distribution', () => {
       const array = ['a', 'b', 'c'];
       const counts: Record<string, number> = { a: 0, b: 0, c: 0 };
-      
+
       // Run 1000 iterations to test distribution
       for (let i = 0; i < 1000; i++) {
         const result = getRandomItem(array);
@@ -106,4 +113,4 @@ describe('QuestionNode Utilities', () => {
       });
     });
   });
-}); 
+});

src/i18n/__tests__/LanguageContext.test.tsx

@@ -1,8 +1,11 @@
 import { render, screen } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
-import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { describe, it, expect, beforeEach } from 'vitest';
+
 import { useLanguage, setLanguage, languageStore } from '../LanguageContext';
 
+import type { LanguageCode } from '../types';
+
 // Test component that uses the language hook
 const TestComponent = () => {
   const { language, translations } = useLanguage();
@@ -58,6 +61,6 @@ describe('LanguageContext', () => {
   });
 
   it('throws error for unsupported language', () => {
-    expect(() => setLanguage('fr' as any)).toThrow('Unsupported language: fr');
+    expect(() => setLanguage('fr' as LanguageCode)).toThrow('Unsupported language: fr');
   });
-}); 
+});

src/questions/__tests__/questions.test.ts

@@ -1,6 +1,13 @@
 import { describe, it, expect } from 'vitest';
+
 import { questionTree } from '../questions';
 
+interface QuestionNode {
+  id: string;
+  link?: string | null;
+  options?: QuestionNode[];
+}
+
 describe('Question Tree', () => {
   it('has a root node with correct structure', () => {
     expect(questionTree).toHaveProperty('id', 'root');
@@ -17,12 +24,12 @@ describe('Question Tree', () => {
       'documentation',
       'community',
       'testing',
-      'release'
+      'release',
     ]);
   });
 
   it('has valid links for leaf nodes', () => {
-    const validateLinks = (options: any[]) => {
+    const validateLinks = (options: QuestionNode[]) => {
       options.forEach(option => {
         if (option.link) {
           expect(option.link).toMatch(/^https?:\/\//); // Should be a valid URL
@@ -59,7 +66,7 @@ describe('Question Tree', () => {
 
   it('has no duplicate IDs across the tree', () => {
     const ids = new Set<string>();
-    const checkForDuplicates = (options: any[]) => {
+    const checkForDuplicates = (options: QuestionNode[]) => {
       options.forEach(option => {
         expect(ids.has(option.id)).toBe(false);
         ids.add(option.id);
@@ -75,10 +82,10 @@ describe('Question Tree', () => {
   it('has consistent link structure for each category', () => {
     questionTree.options.forEach(category => {
       expect(category.link).toBeNull();
-      category.options.forEach((subOption: any) => {
+      category.options?.forEach(subOption => {
         expect(subOption.link).toBeDefined();
         expect(typeof subOption.link).toBe('string');
       });
     });
   });
-}); 
+});