Fix i18n caching issue by enabling static rendering #245
+126
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Disable localeDetection in middleware to prevent Accept-Language header reading - Add setRequestLocale() to layout and all pages for static rendering - Add generateStaticParams() to layout for pre-generating locale paths - Convert useTranslations to getTranslations in page components - Wrap TabsClient in Suspense boundary for useSearchParams compatibility This fixes the random locale switching issue on Vercel by allowing pages to be statically generated and cached per locale path. See: docs/i18n/caching-and-locale-detection.md 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
This PR will require testing before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
localeDetectionin middleware to preventAccept-Languageheader readingsetRequestLocale()to layout and all pages for static renderinggenerateStaticParams()to layout for pre-generating locale pathsuseTranslationstogetTranslationsin page componentsTabsClientin Suspense boundary foruseSearchParamscompatibilityProblem
Users experience random language switching on page refresh due to the interaction between:
localeDetection: truereading theAccept-Languageheaderheaders()is calledSolution
Disable automatic locale detection and enable static rendering so each locale path (
/download,/zh-TW/download, etc.) is cached independently.Documentation
See
docs/i18n/caching-and-locale-detection.mdfor full technical details.Test plan
X-Vercel-CacheshowsHITon subsequent requests🤖 Generated with Claude Code