Add parsing and interpretation of elimination constraints #21195
+2,330
−1,361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coqbot-app
bot
added
the
needs: full CI
Contributor
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
jrosain
added
the
request: full CI
jrosain
force-pushed
the
elimination-constraints
branch
from
ef9e78a to
69e04cb
Compare
coqbot-app
bot
removed
the
request: full CI
jrosain
added
the
request: full CI
jrosain
force-pushed
the
elimination-constraints
branch
from
69e04cb to
419734b
Compare
coqbot-app
bot
removed
the
request: full CI
Contributor
|
something strange is going on in stdlib_test, the message from https://github.com/rocq-prover/stdlib/blob/e343c58314f5a902e08ec6a211f4e1b5812a8c89/test-suite/output/Fixpoint.v#L123 changed to say |
jrosain
added a commit
to jrosain/rocq
that referenced
this pull request
Nov 26, 2025
jrosain
force-pushed
the
elimination-constraints
branch
from
770ece2 to
12d1e20
Compare
coqbot-app
bot
added
needs: full CI
Contributor
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
jrosain
added a commit
to jrosain/rocq-lsp
that referenced
this pull request
Nov 28, 2025
…ntextSet in PConstraints)
jrosain
added
the
request: full CI
jrosain
added a commit
to jrosain/rocq
that referenced
this pull request
Nov 28, 2025
jrosain
force-pushed
the
elimination-constraints
branch
from
2e9e71c to
27104aa
Compare
coqbot-app
bot
removed
the
request: full CI
jrosain
added
the
request: full CI
jrosain
added a commit
to jrosain/rocq-lsp
that referenced
this pull request
Nov 28, 2025
…ntextSet in PConstraints)
jrosain
added a commit
to jrosain/rocq
that referenced
this pull request
Nov 28, 2025
jrosain
force-pushed
the
elimination-constraints
branch
from
27104aa to
877688b
Compare
coqbot-app
bot
removed
the
request: full CI
mattam82
approved these changes
Nov 28, 2025
Member
mattam82
left a comment
mattam82
left a comment
There was a problem hiding this comment.
I only have minor comments, I think we will need to play with this code and have a few iterations anyway to ensure its correctness. Just one thing, we don't touch the "broken" transitivity closure issue found by @tabareau here, right? If not I think this can be merged.
| | Irrelevant -> Sorts.sprop | ||
| | Relevant when Universe.is_type0 u -> Sorts.set | ||
| | Relevant -> Sorts.make Sorts.Quality.qtype u | ||
| | Relevant -> Sorts.prop |
Member
There was a problem hiding this comment.
The comment above the code becomes misleading if you don't change it. I think the solution is fine, but the comment should reflect it.
| Polymorphic Definition sort'@{s | u |} := Type@{s|u}. | ||
| To help the parser, both `|` in the :n:`@univ_decl` are required. | ||
| To help the parser, both `|` in the :n:`@sort_poly_decl` are required. |
Member
There was a problem hiding this comment.
Isn't this outdated? We have @{s;u} already in this branch no?
Contributor
There was a problem hiding this comment.
this is a note about the old syntax (which is still parsed)
I think it is being handled by the changes in |
Contributor
Member
|
Great! |
Fix refman fix refman more
jrosain
added
the
request: full CI
jrosain
force-pushed
the
elimination-constraints
branch
from
877688b to
dcbdcb9
Compare
coqbot-app
bot
removed
the
request: full CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the parsing of elimination constraints as defined in the RFC rocq-prover/rfcs#111.
In particular, it adds the possibility to have sort-level constraints in definitions:
Definition foo@{s s'; | s -> s'} ...and for global sorts.
Sort s s'. Constraint s -> s'.make doc_gram_rsts.Overlays (to be merged in sync with the upstream PR)