-
Notifications
You must be signed in to change notification settings - Fork 701
Uniformize exact hint resolution with others in eauto. #21373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ppedrot
wants to merge
1
commit into
rocq-prover:master
Choose a base branch
from
ppedrot:factor-eauto-hint-exact
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the equivalent of rocq-prover#21193 for eauto rather than TC eauto. En passant this shows that the code does not respect the transparent state provided by the hint database, since we inconditionally use the default flag argument.
Member
Author
|
@coqbot bench |
Contributor
|
🏁 Bench results: 🐢 Top 25 slow downs┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ TOP 25 SLOW DOWNS │ │ │ │ OLD NEW DIFF %DIFF Ln FILE │ ├──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤ │ 62.2 64.8 2.5915 4.16% 608 coq-fiat-crypto-with-bedrock/rupicola/bedrock2/bedrock2/src/bedrock2Examples/lightbulb.v.html │ │ 7.567 8.52 0.9530 12.59% 1506 coq-vst/floyd/Component.v.html │ │ 15.344 16.181 0.8370 5.45% 1223 coq-vst/floyd/Component.v.html │ │ 2.42 3.20 0.7839 32.41% 607 rocq-stdlib/theories/Zmod/ZmodBase.v.html │ │ 1.61 2.01 0.3965 24.61% 75 rocq-stdlib/theories/Numbers/HexadecimalString.v.html │ │ 0.124 0.510 0.3853 309.93% 270 coq-fiat-crypto-with-bedrock/src/Curves/Montgomery/XZProofs.v.html │ │ 58.4 58.8 0.3842 0.66% 27 coq-fiat-crypto-with-bedrock/src/Rewriter/Passes/ToFancyWithCasts.v.html │ │ 1.51 1.88 0.3697 24.42% 313 rocq-stdlib/theories/Strings/Byte.v.html │ │ 0.607 0.967 0.3597 59.25% 41 rocq-stdlib/theories/ZArith/Zdiv_facts.v.html │ │ 27.0 27.4 0.3349 1.24% 148 coq-fiat-crypto-with-bedrock/src/Bedrock/End2End/X25519/GarageDoorTop.v.html │ │ 20.9 21.2 0.3202 1.53% 479 rocq-metarocq-erasure/erasure/theories/EWcbvEvalCstrsAsBlocksFixLambdaInd.v.html │ │ 28.8 29.1 0.3094 1.07% 145 coq-fiat-crypto-with-bedrock/src/Bedrock/End2End/X25519/GarageDoorTop.v.html │ │ 19.9 20.2 0.2734 1.37% 40 coq-fiat-crypto-with-bedrock/src/PushButtonSynthesis/SolinasReductionReificationCache.v.html │ │ 9.74 10.0 0.2676 2.75% 304 coq-fiat-crypto-with-bedrock/src/Fancy/Montgomery256.v.html │ │ 7.65 7.89 0.2367 3.09% 31 coq-performance-tests-lite/src/pattern.v.html │ │ 0.365 0.595 0.2302 63.06% 11 rocq-stdlib/theories/omega/PreOmega.v.html │ │ 21.2 21.4 0.2301 1.09% 49 coq-fiat-crypto-with-bedrock/src/Curves/Weierstrass/AffineProofs.v.html │ │ 18.7 18.9 0.2275 1.22% 481 coq-verdi-raft/theories/RaftProofs/EndToEndLinearizability.v.html │ │ 0.315 0.532 0.2166 68.74% 11 rocq-stdlib/theories/Sorting/PermutEq.v.html │ │ 0.00204 0.213 0.2112 10361.78% 262 rocq-metarocq-erasure/erasure/theories/Typed/Erasure.v.html │ │ 48.4 48.6 0.2084 0.43% 376 coq-unimath/UniMath/ModelCategories/Generated/LNWFSMonoidalStructure.v.html │ │ 0.131 0.340 0.2083 158.50% 15 rocq-stdlib/theories/FSets/FMapInterface.v.html │ │ 0.381 0.586 0.2052 53.88% 18 rocq-stdlib/theories/FSets/FMapFacts.v.html │ │ 28.8 29.0 0.1944 0.67% 530 coq-fiat-crypto-with-bedrock/src/Bedrock/End2End/X25519/EdwardsXYZT.v.html │ │ 0.000480 0.190 0.1900 39585.42% 124 rocq-metarocq-erasure/erasure/theories/EOptimizePropDiscr.v.html │ └──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘ 🐇 Top 25 speed ups┌────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ TOP 25 SPEED UPS │ │ │ │ OLD NEW DIFF %DIFF Ln FILE │ ├────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤ │ 26.0 23.6 -2.3863 -9.19% 129 coq-fiat-crypto-with-bedrock/src/Curves/Weierstrass/Projective.v.html │ │ 95.5 93.8 -1.7169 -1.80% 20 coq-fiat-crypto-with-bedrock/src/Rewriter/Passes/NBE.v.html │ │ 94.9 93.8 -1.0932 -1.15% 968 coq-performance-tests-lite/src/fiat_crypto_via_setoid_rewrite_standalone.v.html │ │ 237 236 -1.0620 -0.45% 141 coq-fiat-crypto-with-bedrock/src/UnsaturatedSolinasHeuristics/Tests.v.html │ │ 94.8 93.8 -0.9504 -1.00% 999 coq-performance-tests-lite/src/fiat_crypto_via_setoid_rewrite_standalone.v.html │ │ 22.1 21.3 -0.7806 -3.54% 651 rocq-stdlib/theories/Zmod/ZmodBase.v.html │ │ 18.9 18.1 -0.7540 -3.99% 32 coq-performance-tests-lite/src/pattern.v.html │ │ 178 177 -0.6843 -0.39% 233 coq-fiat-crypto-with-bedrock/rupicola/bedrock2/deps/riscv-coq/src/riscv/Proofs/DecodeByExtension.v.html │ │ 134 133 -0.6410 -0.48% 155 coq-fiat-crypto-with-bedrock/src/UnsaturatedSolinasHeuristics/Tests.v.html │ │ 31.5 31.0 -0.5456 -1.73% 12 coq-fourcolor/theories/proof/job254to270.v.html │ │ 1.58 1.18 -0.4017 -25.42% 1142 rocq-stdlib/theories/FSets/FMapAVL.v.html │ │ 47.0 46.6 -0.3966 -0.84% 115 coq-bedrock2/bedrock2/src/bedrock2Examples/full_mul.v.html │ │ 25.0 24.6 -0.3883 -1.55% 12 coq-fourcolor/theories/proof/job503to506.v.html │ │ 29.5 29.2 -0.3754 -1.27% 12 coq-fourcolor/theories/proof/job589to610.v.html │ │ 12.8 12.4 -0.3547 -2.78% 930 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html │ │ 0.449 0.0991 -0.3498 -77.93% 312 rocq-stdlib/theories/Reals/Abstract/ConstructiveAbs.v.html │ │ 31.3 30.9 -0.3366 -1.08% 180 coq-fiat-crypto-with-bedrock/src/Bedrock/Field/Synthesis/Examples/p224_64_new.v.html │ │ 0.515 0.180 -0.3349 -65.01% 592 rocq-stdlib/theories/MSets/MSetAVL.v.html │ │ 31.1 30.8 -0.3342 -1.07% 198 coq-fiat-crypto-with-bedrock/src/Bedrock/Field/Synthesis/Examples/p224_64_new.v.html │ │ 25.5 25.2 -0.3267 -1.28% 12 coq-fourcolor/theories/proof/job535to541.v.html │ │ 31.2 30.9 -0.3250 -1.04% 166 coq-fiat-crypto-with-bedrock/src/Bedrock/Field/Synthesis/Examples/p224_64_new.v.html │ │ 33.2 32.9 -0.3246 -0.98% 12 coq-fourcolor/theories/proof/job439to465.v.html │ │ 26.0 25.7 -0.3181 -1.22% 12 coq-fourcolor/theories/proof/job466to485.v.html │ │ 30.2 29.8 -0.3154 -1.05% 12 coq-fourcolor/theories/proof/job001to106.v.html │ │ 31.3 31.0 -0.3078 -0.98% 214 coq-fiat-crypto-with-bedrock/src/Bedrock/Field/Synthesis/Examples/p224_64_new.v.html │ └────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent of #21193 for eauto rather than TC eauto. En passant this shows that the code does not respect the transparent state provided by the hint database, since we inconditionally use the default flag argument.