Properly declare side-effects in (some) non-proof declarations. #21379
+126
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eclare. This cleans up a longstanding issue with effect deduplication that made no sense whatsoever. The new model has better static invariants, as it separates the first phase where effects are common to the block of constants being defined, and the second phase where we decide whether to inline them on a per-constant regard based on opacity. This code should not change the semantics, it is just a clean-up for now.
Fixes rocq-prover#10959: Anomalies from missing abstract proofs.
ppedrot
added
the
request: full CI
coqbot-app
bot
removed
the
request: full CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a longstanding issue with effect deduplication that made no sense whatsoever. The new model has better static invariants, as it separates the first phase where effects are common to the block of constants being defined, and the second phase where we decide whether to inline them on a per-constant basis depending on opacity.
Fixes #10959: Anomalies from missing abstract proofs.
Not all issues with abstract in defining blocks is solved, see the test file, but this patch is making other fixes possible.