Error handling for kobo attachment urls

Author: tijsziere

main.py

@@ -63,11 +63,20 @@ async def docs_redirect():
 @app.get("/health")
 async def health():
     """Get health of instance."""
-    kobo = requests.get(f"https://kobo.ifrc.org/api/v2")
-    return JSONResponse(
-        status_code=200,
-        content={"kobo-connect": 200, "kobo.ifrc.org": kobo.status_code},
-    )
+    logger.info("Health check initiated")
+    try:
+        kobo = requests.get(f"https://kobo.ifrc.org/api/v2", timeout=10)
+        logger.info(f"Kobo API health check completed with status: {kobo.status_code}")
+        return JSONResponse(
+            status_code=200,
+            content={"kobo-connect": 200, "kobo.ifrc.org": kobo.status_code},
+        )
+    except requests.exceptions.RequestException as e:
+        logger.error(f"Kobo API health check failed: {str(e)}")
+        return JSONResponse(
+            status_code=200,
+            content={"kobo-connect": 200, "kobo.ifrc.org": "unavailable"},
+        )
 
 
 if __name__ == "__main__":

routes/routes121.py

@@ -98,7 +98,14 @@ async def kobo_to_121(
             ):
                 payload[target_field] = kobo_data[kobo_field]
             else:
-                payload[target_field] = attachments[kobo_value_url]["url"]
+                try:
+                    payload[target_field] = attachments[kobo_value_url]["url"]
+                except KeyError:
+                    logger.warning(
+                        f"Could not retrieve attachment URL for field '{target_field}' with value '{kobo_value_url}'",
+                        extra=extra_logs,
+                    )
+                    payload[target_field] = "could not retrieve attachment url from kobo"
 
     payload["referenceId"] = referenceId