Use the value of the Retry-After header when present#47
Open
mschroeder223 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies _getDelay to be passed the DioException and looks for the retry-after header in the response. When its present it attempts to parse it into seconds or an HTTP Date as per https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Retry-After If the header is not present or the header is malformed it falls back to the Duration based on the attempt.
I added test coverage as well using httpbun.com to respond with a 429 and different values of retry-after headers.
I believe this should be backwards compatible.