Add .tagged and .not_tagged methods for resource matcher

Author: kjetilho

README.md

@@ -360,6 +360,13 @@ it { is_expected.to contain_service('keystone').without(
 )}
 ```
 
+You can test if the resource has the expected tags with the `tagged` and
+`not_tagged` methods.
+
+```ruby
+it { is_expected.to contain_service('keystone').tagged('site:cph') }
+```
+
 #### Checking the number of resources
 
 You can test the number of resources in the catalogue with the

lib/rspec-puppet/matchers/create_generic.rb

@@ -20,6 +20,8 @@ def initialize(*args, &block)
         @subscribes = []
         @requires = []
         @befores = []
+        @tagged = []
+        @not_tagged = []
       end
 
       def with(*args, &block)
@@ -60,6 +62,16 @@ def that_comes_before(resource)
         self
       end
 
+      def tagged(resource)
+        @tagged.concat(Array(resource))
+        self
+      end
+
+      def not_tagged(resource)
+        @not_tagged.concat(Array(resource))
+        self
+      end
+
       def method_missing(method, *args, &block)
         if method.to_s =~ /^with_/
           param = method.to_s.gsub(/^with_/, '')
@@ -109,6 +121,8 @@ def matches?(catalogue)
 
           check_params(rsrc_hsh, @expected_params, :should) if @expected_params.any?
           check_params(rsrc_hsh, @expected_undef_params, :not) if @expected_undef_params.any?
+          check_tags(resource, @tagged, :should) if @tagged.any?
+          check_tags(resource, @not_tagged, :not) if @not_tagged.any?
           check_befores(@catalogue, resource) if @befores.any?
           check_requires(@catalogue, resource) if @requires.any?
           check_notifies(@catalogue, resource) if @notifies.any?
@@ -162,6 +176,16 @@ def description
           values = @befores
         end
 
+        if @tagged.any?
+          value_str_prefix = "that is tagged"
+          values = @tagged
+        end
+
+        if @not_tagged.any?
+          value_str_prefix = "that is not tagged"
+          values = @not_tagged
+        end
+
         unless values.empty?
           if values.length == 1
             value_str = " #{value_str_prefix} #{values.first}"
@@ -371,6 +395,25 @@ def check_params(resource, list, type)
           end
         end
       end
+      # @param resource [Puppet::Resource] The resource in the catalog
+      # @param list [Array<String>] The expected tags for the resource
+      # @param type [:should, :not] Whether the given tags should/not be present
+      def check_tags(resource, list, type)
+        case type
+        when :should
+          list.each do |tag|
+            unless resource.tags.include? tag
+              @errors << "#{tag} is not set"
+            end
+          end
+        when :not
+          list.each do |tag|
+            if resource.tags.include? tag
+              @errors << "#{tag} is set"
+            end
+          end
+        end
+      end
     end
   end
 end