Skip to content

Commit 0b04e3e

Browse files
roed314claude
andcommitted
Register test_knowledge.py in CI test census (review fix)
The PR added lmfdb/knowledge/test_knowledge.py but left the Tests workflow asserting exactly 43 test files, so every matrix job failed at the census step before tests ran. Bump the count to 44 and assign the new module to the knowls shard (alongside test_dynamic_knowls.py) in both the proddb and devmirror matrix entries so it is actually run. Verified: replicated census command (find ... | wc -l == 44) passes; matrix_includes.json parses and lists the file in both shards; sage -python -m pytest lmfdb/knowledge/test_knowledge.py -> 4 passed; pyflakes clean. Note: open PR #4 (ai/t07-negative-ranges) applies the same census bump for its own new test file; the second to merge re-bumps to 45 (trivial same-line conflict, intentional). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 35df6c9 commit 0b04e3e

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/matrix_includes.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@
3030
"server": "devmirror"
3131
},
3232
{
33-
"files": "lmfdb/tests/test_dynamic_knowls.py lmfdb/tests/test_root.py lmfdb/tests/test_code_coverage.py lmfdb/hecke_algebras/test_hecke_algebras.py lmfdb/tests/test_homepage.py lmfdb/tests/test_random_redirects.py lmfdb/elliptic_curves/test_ell_curves.py lmfdb/elliptic_curves/test_browse_page.py",
34-
"folders": "elliptic_curves hecke_algebras tests",
33+
"files": "lmfdb/tests/test_dynamic_knowls.py lmfdb/knowledge/test_knowledge.py lmfdb/tests/test_root.py lmfdb/tests/test_code_coverage.py lmfdb/hecke_algebras/test_hecke_algebras.py lmfdb/tests/test_homepage.py lmfdb/tests/test_random_redirects.py lmfdb/elliptic_curves/test_ell_curves.py lmfdb/elliptic_curves/test_browse_page.py",
34+
"folders": "elliptic_curves hecke_algebras knowledge tests",
3535
"server": "proddb"
3636
},
3737
{
38-
"files": "lmfdb/tests/test_dynamic_knowls.py lmfdb/tests/test_root.py lmfdb/tests/test_code_coverage.py lmfdb/hecke_algebras/test_hecke_algebras.py lmfdb/tests/test_homepage.py lmfdb/tests/test_random_redirects.py lmfdb/elliptic_curves/test_ell_curves.py lmfdb/elliptic_curves/test_browse_page.py",
39-
"folders": "elliptic_curves hecke_algebras tests",
38+
"files": "lmfdb/tests/test_dynamic_knowls.py lmfdb/knowledge/test_knowledge.py lmfdb/tests/test_root.py lmfdb/tests/test_code_coverage.py lmfdb/hecke_algebras/test_hecke_algebras.py lmfdb/tests/test_homepage.py lmfdb/tests/test_random_redirects.py lmfdb/elliptic_curves/test_ell_curves.py lmfdb/elliptic_curves/test_browse_page.py",
39+
"folders": "elliptic_curves hecke_algebras knowledge tests",
4040
"server": "devmirror"
4141
},
4242
{

.github/workflows/python-package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ jobs:
9090
- name: checking that we didn't miss any test files
9191
shell: bash -l {0}
9292
# If this fails you need to update the file list above and file count
93-
run: test $(find lmfdb -name 'test_*.py' -or -name '*_test.py' | wc -l) -eq 43
93+
run: test $(find lmfdb -name 'test_*.py' -or -name '*_test.py' | wc -l) -eq 44
9494

9595
- name: Config LMFDB to run tests against proddb
9696
if: matrix.files != 'lint' && matrix.server == 'proddb'

0 commit comments

Comments
 (0)