Address review of active-constraint highlighting

Emit exactly one class attribute per rendered input.  Class names now go
through a first-class `classes` argument on SearchBox, merged with
`advanced` and the `search_*` classes and deduplicated; any class written
into `extra` is merged too, so a tag can no longer end up with two class
attributes (invalid HTML, and browsers discard one of them, which was
making the feature silently fail on the hypergeometric and CMF forms).
The existing `extra=['class=...']` uses migrate to `classes`, and `extra`
is copied rather than shared.

Stop marking presentation-only controls as constraints.  The trace and
Euler tables' `n`, `n_primality` and `view_modp` choose which columns are
displayed, not which rows match, so they are no longer highlighted; this
includes the `n_primality=primes` that set_Trn inserts on every trace
search.  `an_modulo` is contextual, since it only enters the query
through the trace constraints, so `is_constraint` now also accepts a
function of `info`.

Keep `search_active` describing the results on screen.  The JS that
retagged inputs as the user typed is gone, so the highlight no longer
claims a constraint that has not been submitted; the search button's
existing fresh/stale signal still reports that the form was edited.

Mark active checkboxes with a box-shadow ring rather than an outline, so
the keyboard focus indicator survives, in a darker shade with usable
contrast, and tint text inputs with background-color so the shorthand
does not reset a background image.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: roed314

lmfdb/classical_modular_forms/main.py

@@ -1019,6 +1019,18 @@ def trace_postprocess(res, info, query):
     return res
 def space_trace_postprocess(res, info, query):
     return trace_postprocess(res, info, query, True)
+def an_modulo_is_constraint(info):
+    """
+    Whether the ``an_modulo`` input is restricting which results are shown.
+
+    The modulus enters the query only through the trace constraints, which it
+    turns from equalities into congruences.  Without any trace constraints it
+    just controls whether the traces that are displayed are reduced (together
+    with ``view_modp``), so it should not be marked as an active constraint.
+    """
+    an_constraints = info.get('an_constraints') or ''
+    return bool(an_constraints.strip())
+
 def process_an_constraints(info, query, qfield='traces', nshift=None):
     q = info.get('an_modulo','').strip()
     if q:
@@ -1593,7 +1605,8 @@ def __init__(self):
 
         weight_quantifier = ParityMod(
             name='weight_parity',
-            extra=['class="simult_select"', 'onchange="simult_change(event);"'])
+            classes=["simult_select"],
+            extra=['onchange="simult_change(event);"'])
 
         weight = TextBoxWithSelect(
             name='weight',
@@ -1605,7 +1618,8 @@ def __init__(self):
 
         character_quantifier = ParityMod(
             name='char_parity',
-            extra=['class="simult_select"', 'onchange="simult_change(event);"'])
+            classes=["simult_select"],
+            extra=['onchange="simult_change(event);"'])
 
         character = TextBoxWithSelect(
             name='char_label',
@@ -1757,18 +1771,22 @@ def __init__(self):
 
         results = CountBox()
 
+        # The columns shown in the trace table, and how their entries are
+        # displayed, do not affect which newforms match the search
         trace_coldisplay = TextBox(
             name='n',
             label='Columns to display',
             example='1-40',
-            example_span='3,7,19, 40-90')
+            example_span='3,7,19, 40-90',
+            is_constraint=False)
 
         trace_primality = SelectBox(
             name='n_primality',
             label='Show',
             options=[('', 'primes only'),
                      ('prime_powers', 'prime powers'),
-                     ('all', 'all')])
+                     ('all', 'all')],
+            is_constraint=False)
 
         trace_an_constraints = TextBox(
             name='an_constraints',
@@ -1779,13 +1797,15 @@ def __init__(self):
         trace_an_moduli = TextBox(
             name='an_modulo',
             label='Modulo',
-            example_span='5, 16')
+            example_span='5, 16',
+            is_constraint=an_modulo_is_constraint)
 
         trace_view = SelectBox(
             name='view_modp',
             label='View',
             options=[('', 'integers'),
-                     ('reductions', 'reductions')])
+                     ('reductions', 'reductions')],
+            is_constraint=False)
 
         self.browse_array = [
             [level, weight],

lmfdb/classical_modular_forms/test_cmf2.py

@@ -184,6 +184,36 @@ def test_traces(self):
         for elt in map(str,[17,0,-80,60,3780,-1200]):
             assert elt in page.get_data(as_text=True)
 
+    def test_traces_active_classes(self):
+        # Only the inputs that select which newforms are shown should be
+        # marked; the rest choose which columns of traces are displayed
+        url = '/ModularForm/GL2/Q/holomorphic/?level=11&search_type=Traces'
+        self.assertEqual(self.search_classes(url, 'level'),
+                         {'search_constraint', 'search_active'})
+        self.assertEqual(self.search_classes(url, 'weight'), {'search_constraint'})
+        # set_Trn defaults n_primality to primes on every trace search, so it
+        # would otherwise look filled in even when the user never touched it
+        for name in ['n', 'n_primality', 'view_modp', 'an_modulo']:
+            self.assertEqual(self.search_classes(url, name), set())
+
+        # The modulus does constrain the results once there is a trace
+        # constraint for it to be applied to
+        url = ('/ModularForm/GL2/Q/holomorphic/?level=244&weight=4&search_type=Traces'
+               '&an_constraints=a3%3D0&an_modulo=3')
+        for name in ['an_constraints', 'an_modulo']:
+            self.assertEqual(self.search_classes(url, name),
+                             {'search_constraint', 'search_active'})
+
+    def test_simult_select_classes(self):
+        # simult_select drives simult_change() in the CMF search template, and
+        # has to survive alongside the classes marking active constraints
+        url = '/ModularForm/GL2/Q/holomorphic/?level=11&weight=2'
+        page = self.tc.get(url, follow_redirects=True).get_data(as_text=True)
+        assert 'onchange="simult_change(event);"' in page
+        for name in ['weight_parity', 'char_parity']:
+            self.assertEqual(self.search_classes(url, name),
+                             {'simult_select', 'search_constraint'})
+
     def test_trivial_searches(self):
         from sage.all import Subsets
         for begin in [

lmfdb/hypergm/main.py

@@ -732,31 +732,31 @@ def __init__(self):
             label="Degree",
             knowl="hgm.degree",
             example="4",
-            extra=['class="family"'])
+            classes=["family"])
         weight = TextBox(
             name="weight",
             label="Weight",
             knowl="hgm.weight",
             example="3",
-            extra=['class="family"'])
+            classes=["family"])
         famhodge = TextBox(
             name="famhodge",
             label="Family Hodge vector",
             knowl="hgm.hodge_vector",
             example="[1,1,1,1]",
-            extra=['class="family"'])
+            classes=["family"])
         A = TextBox(
             name="A",
             label="$A$",
             knowl="hgm.defining_parameters",
             example="[3,2,2]",
-            extra=['class="family"'])
+            classes=["family"])
         B = TextBox(
             name="B",
             label="$B$",
             knowl="hgm.defining_parameters",
             example="[6,4]",
-            extra=['class="family"'])
+            classes=["family"])
         p = SelectBox(
             name="p",
             label="Prime $p$",
@@ -770,25 +770,25 @@ def __init__(self):
             label="$A_p$",
             knowl="hgm.defining_parameter_ppart",
             example="[2,2,1,1]",
-            extra=['class="family"'])
+            classes=["family"])
         Bp = TextBox(
             name="Bp",
             label="$B_p$",
             knowl="hgm.defining_parameter_ppart",
             example="[2,2,1,1]",
-            extra=['class="family"'])
+            classes=["family"])
         Apperp = TextBox(
             name="Apperp",
             label=r"$A^\perp_p$",
             knowl="hgm.defining_parameter_primetoppart",
             example="[2,2,1,1]",
-            extra=['class="family"'])
+            classes=["family"])
         Bpperp = TextBox(
             name="Bpperp",
             label=r"$B^\perp_p$",
             knowl="hgm.defining_parameter_primetoppart",
             example="[2,2,1,1]",
-            extra=['class="family"'])
+            classes=["family"])
         spacer = BasicSpacer("")
 
         conductor = TextBox(
@@ -797,27 +797,27 @@ def __init__(self):
             knowl="hgm.conductor",
             example="64",
             example_span="a value, like 32, a list, like 32,64, or a range like 1..10000",
-            extra=['class="motive"'])
+            classes=["motive"])
         hodge = TextBox(
             name="hodge",
             label="Hodge vector",
             knowl="hgm.hodge_vector",
             example="[1,1,1,1]",
-            extra=['class="motive"'])
+            classes=["motive"])
         t = TextBox(
             name="t",
             label="Specialization point $t$",
             knowl="hgm.specpoint",
             example="3/2",
             example_span="3/2 (1 has an associated degree drop and is always in the database)",
-            extra=['class="motive"'])
+            classes=["motive"])
         sign = TextBoxNoEg(
             name="sign",
             label=r"Root number $\epsilon$",
             knowl="lfunction.sign",
             example="-1",
             example_span="1 or -1, with -1 occurring only in the symplectic case",
-            extra=['class="motive"'])
+            classes=["motive"])
         # The following two boxes are not yet enabled
         # generic = YesNoBox(
         #    name="generic",

lmfdb/hypergm/test_hgm.py

@@ -64,6 +64,15 @@ def test_search_degree(self):
         self.check_args("/Motive/Hypergeometric/Q/?degree=4&search_type=Family", ["A5_B3.2.1","A10_B4.2.1"])
         self.not_check_args("/Motive/Hypergeometric/Q/?degree=4&search_type=Family", "A2_B1")
 
+    def test_search_active_classes(self):
+        # The family class drives the Enter-key behavior in hgm-index.html, so
+        # it has to survive alongside the classes marking active constraints
+        url = "/Motive/Hypergeometric/Q/?degree=4&search_type=Family"
+        self.assertEqual(self.search_classes(url, "degree"),
+                         {"family", "search_constraint", "search_active"})
+        self.assertEqual(self.search_classes(url, "weight"),
+                         {"family", "search_constraint"})
+
     def test_search_weight(self):
         self.check_args("/Motive/Hypergeometric/Q/?weight=3&search_type=Family", "A5_B6.6")
         self.not_check_args("/Motive/Hypergeometric/Q/?weight=3&search_type=Family", "A3_B4")

lmfdb/lfunctions/main.py

@@ -41,7 +41,11 @@
 from lmfdb.lfunctions import l_function_page
 from lmfdb.maass_forms.plot import paintSvgMaass
 from lmfdb.classical_modular_forms.web_newform import convert_newformlabel_from_conrey
-from lmfdb.classical_modular_forms.main import set_Trn, process_an_constraints
+from lmfdb.classical_modular_forms.main import (
+    an_modulo_is_constraint,
+    process_an_constraints,
+    set_Trn,
+)
 from lmfdb.artin_representations.main import parse_artin_label
 from lmfdb.utils.search_parsing import (
     parse_bool, parse_ints, parse_ints_to_list, parse_floats, parse_noop, parse_mod1,
@@ -616,24 +620,30 @@ def __init__(self, force_rational=False):
             self.refine_array += [[algebraic]]
 
         if force_rational:
+            # The columns shown in the trace and Euler factor tables, and how
+            # their entries are displayed, do not affect which L-functions
+            # match the search
             trace_coldisplay = TextBox(
                 name='n',
                 label='Columns to display',
                 example='1-40',
-                example_span='3,7,19, 40-90')
+                example_span='3,7,19, 40-90',
+                is_constraint=False)
 
             euler_coldisplay = TextBox(
                 name='n',
                 label='Columns to display',
                 example='2-11',
-                example_span='3,7,19')
+                example_span='3,7,19',
+                is_constraint=False)
 
             trace_primality = SelectBox(
                 name='n_primality',
                 label='Show',
                 options=[('', 'primes only'),
                          ('prime_powers', 'prime powers'),
-                         ('all', 'all')])
+                         ('all', 'all')],
+                is_constraint=False)
 
             trace_an_constraints = TextBox(
                 name='an_constraints',
@@ -650,13 +660,15 @@ def __init__(self, force_rational=False):
             trace_an_moduli = TextBox(
                 name='an_modulo',
                 label='Modulo',
-                example_span='5, 16')
+                example_span='5, 16',
+                is_constraint=an_modulo_is_constraint)
 
             trace_view = SelectBox(
                 name='view_modp',
                 label='View',
                 options=[('', 'integers'),
-                         ('reductions', 'reductions')])
+                         ('reductions', 'reductions')],
+                is_constraint=False)
 
             self.traces_array = [
                 RowSpacer(22),

lmfdb/lfunctions/test_lfunctions.py

@@ -614,6 +614,36 @@ def test_trace_search_mod_q(self):
         assert '2-37-1.1-c1-0-1' in L.get_data(as_text=True)
         assert '2-37-1.1-c1-0-0' not in L.get_data(as_text=True)
 
+    # ------------------------------------------------------
+    # Testing which inputs are marked as active constraints
+    # ------------------------------------------------------
+
+    def test_trace_active_classes(self):
+        # Only the inputs that select which L-functions are shown should be
+        # marked; the rest choose which columns of traces are displayed
+        url = '/L/rational?degree=2&search_type=Traces'
+        self.assertEqual(self.search_classes(url, 'degree'),
+                         {'search_constraint', 'search_active'})
+        for name in ['n', 'n_primality', 'view_modp', 'an_modulo']:
+            self.assertEqual(self.search_classes(url, name), set())
+
+        # The modulus does constrain the results once there is a trace
+        # constraint for it to be applied to, unlike the reductions view
+        url = ('L/rational?conductor=37&degree=2&search_type=Traces'
+               '&an_constraints=a11+%3D1&an_modulo=3&view_modp=reductions')
+        for name in ['conductor', 'an_constraints', 'an_modulo']:
+            self.assertEqual(self.search_classes(url, name),
+                             {'search_constraint', 'search_active'})
+        self.assertEqual(self.search_classes(url, 'view_modp'), set())
+
+    def test_euler_active_classes(self):
+        url = '/L/rational?degree=2&search_type=Euler&n=2-11'
+        self.assertEqual(self.search_classes(url, 'degree'),
+                         {'search_constraint', 'search_active'})
+        self.assertEqual(self.search_classes(url, 'n'), set())
+        self.assertEqual(self.search_classes(url, 'euler_constraints'),
+                         {'search_constraint'})
+
     # ------------------------------------------------------
     # Testing units not tested above
     # ------------------------------------------------------

lmfdb/templates/diagram_search_form.html

@@ -52,14 +52,4 @@ <h2 id='search_h2'>{{KNOWL('intro.search', search_header)}}
 
 $("input").on("input", set_fresh);
 $("select").on("change", set_fresh);
-
-function update_search_active() {
-  var box = $(this);
-  if (box.is("[type=checkbox]")) {
-    box.toggleClass("search_active", box.prop("checked"));
-  } else {
-    box.toggleClass("search_active", Boolean(box.val()));
-  }
-}
-$(".search_constraint").on("input change", update_search_active);
 </script>

lmfdb/templates/refine_search_form.html

@@ -41,15 +41,5 @@ <h2 id='search_h2'>{{KNOWL('intro.search', search_header)}}
 
 $("input").on("input", set_fresh);
 $("select").on("change", set_fresh);
-
-function update_search_active() {
-  var box = $(this);
-  if (box.is("[type=checkbox]")) {
-    box.toggleClass("search_active", box.prop("checked"));
-  } else {
-    box.toggleClass("search_active", Boolean(box.val()));
-  }
-}
-$(".search_constraint").on("input change", update_search_active);
 </script>
 

lmfdb/templates/style.css

@@ -2335,11 +2335,12 @@ button.search_fresh {
 }
 
 /* Highlight inputs that are actively constraining the displayed search results */
-input.search_active, select.search_active {
-  background: {{color.search_active_background}};
+input.search_active:not([type=checkbox]), select.search_active {
+  background-color: {{color.search_active_background}};
 }
-/* Checkboxes are rendered natively, so mark them with a ring instead */
+/* Checkboxes are rendered natively, so mark them with a ring instead.  This
+   uses box-shadow rather than outline so that the browser's keyboard focus
+   indicator, which outline would replace, stays visible. */
 input[type=checkbox].search_active {
-  outline: 3px solid {{color.search_active_background}};
-  outline-offset: 1px;
+  box-shadow: 0 0 0 2px {{color.search_active_ring}};
 }