Skip to content

Commit ac95323

Browse files
roed314claude
andcommitted
Lattices: replace index tab bar with collapsible sidebar submenu
Reviewer-requested changes on the lattice section revamp: - The site has moved from per-section tab bars to collapsible sidebar submenus, so give the Lattices sidebar entry a submenu (lattices, genera) following the Abstract groups pattern, drop the tabs macro from lattice-index.html and genus-index.html, and delete lattice-tabs.html. - Reword the two Eisenstein newspace comments in web_lattice.py: the Eisenstein branch IS part of alpha; the try/except is there so the lattices branch can also be deployed without it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 6c1d748 commit ac95323

5 files changed

Lines changed: 12 additions & 21 deletions

File tree

lmfdb/homepage/sidebar.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,12 @@
211211
url_for: "lattice.index"
212212
status: beta
213213
colspan: onecolumn
214+
collapsible: true
215+
part2:
216+
- title: "lattices"
217+
url_for: "lattice.index"
218+
- title: "genera"
219+
url_for: "lattice.genus_index"
214220
- title: Finite subgroups of
215221
part2:
216222
- title: $\GL(n,\F_q)$

lmfdb/lattice/templates/genus-index.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
{% extends "homepage.html" %}
22
{% block content %}
3-
{% from "lattice-tabs.html" import tabs %}
4-
5-
{{ tabs(("Lattices", ".index", false), ("Genera", ".genus_index", true)) }}
63

74
<div>
85
{{ info.stats.short_summary | safe }}

lmfdb/lattice/templates/lattice-index.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
{% extends "homepage.html" %}
22
{% block content %}
3-
{% from "lattice-tabs.html" import tabs %}
4-
5-
{{ tabs(("Lattices", ".index", true), ("Genera", ".genus_index", false)) }}
63

74
<div>
85
{{ info.stats.short_summary | safe }}

lmfdb/lattice/templates/lattice-tabs.html

Lines changed: 0 additions & 11 deletions
This file was deleted.

lmfdb/lattice/web_lattice.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -355,8 +355,9 @@ def friends(self):
355355
chi_orbit = 'a' if chi.is_trivial() else 'b'
356356
mf_space = f'{self.level}.{weight}.E.{chi_orbit}'
357357
try:
358-
# Eisenstein newspace labels are only supported once the CMF
359-
# Eisenstein branch is merged; skip the friend if not available.
358+
# The CMF code accepts Eisenstein (E) newspace labels only when
359+
# the Eisenstein branch is present (it is on alpha); degrade
360+
# gracefully so the lattices branch can also be deployed without it.
360361
friends.append(("Newspace " + mf_space, url_for_mf_label(mf_space)))
361362
except ValueError:
362363
pass
@@ -545,8 +546,9 @@ def friends(self):
545546
chi_orbit = 'a' if chi.is_trivial() else 'b'
546547
mf_space = f'{self.level}.{weight}.E.{chi_orbit}'
547548
try:
548-
# Eisenstein newspace labels are only supported once the CMF
549-
# Eisenstein branch is merged; skip the friend if not available.
549+
# The CMF code accepts Eisenstein (E) newspace labels only when
550+
# the Eisenstein branch is present (it is on alpha); degrade
551+
# gracefully so the lattices branch can also be deployed without it.
550552
friends.append(("Newspace " + mf_space, url_for_mf_label(mf_space)))
551553
except ValueError:
552554
pass

0 commit comments

Comments
 (0)