CI fixes for shimura_curves: lint, template collision, test wiring

- web_curve.py: drop f-prefix on placeholder-less f-string (pyflakes)
- rename lat_diagram_page.html -> shimcurve_lat_diagram_page.html (collided
  with modular_curves' template of the same name in the shared jinja namespace)
- test_home: browse page notation changed from X_0(N) to X(D;N)
- workflow: test-file count 44 -> 45; run shimura tests on devmirror in CI

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: roed314

.github/workflows/matrix_includes.json

@@ -108,5 +108,10 @@
         "files": "lmfdb/modular_curves/test_modular_curves.py",
         "folders": "modular_curves",
         "server": "devmirror"
+    },
+    {
+        "files": "lmfdb/shimura_curves/test_shimura_curves.py",
+        "folders": "shimura_curves",
+        "server": "devmirror"
     }
 ]

.github/workflows/python-package.yml

@@ -90,7 +90,7 @@ jobs:
     - name: checking that we didn't miss any test files
       shell: bash -l {0}
       # If this fails you need to update the file list above and file count
-      run: test $(find lmfdb -name 'test_*.py' -or -name '*_test.py' | wc -l) -eq 44
+      run: test $(find lmfdb -name 'test_*.py' -or -name '*_test.py' | wc -l) -eq 45
 
     - name: Config LMFDB to run tests against proddb
       if: matrix.files != 'lint' && matrix.server == 'proddb'

lmfdb/shimura_curves/main.py

@@ -162,7 +162,7 @@ def lat_diagram(label):
     info = {"dojs": dojs}
     info.update(display_opts)
     return render_template(
-        "lat_diagram_page.html",
+        "shimcurve_lat_diagram_page.html",
         dojs=dojs,
         info=info,
         title="Diagram of nearby Shimura curves for %s" % label,

…a_curves/templates/lat_diagram_page.html …emplates/shimcurve_lat_diagram_page.htmllmfdb/shimura_curves/templates/lat_diagram_page.html renamed to lmfdb/shimura_curves/templates/shimcurve_lat_diagram_page.html lmfdb/shimura_curves/templates/lat_diagram_page.html renamed to lmfdb/shimura_curves/templates/shimcurve_lat_diagram_page.html

@@ -9,4 +9,4 @@ def test_home(self):
         assert 'Browse' in L.get_data(as_text=True)
         assert 'Search' in L.get_data(as_text=True)
         assert 'Find' in L.get_data(as_text=True)
-        assert 'X_0(N)' in L.get_data(as_text=True)
+        assert 'X(D;N)' in L.get_data(as_text=True)

lmfdb/shimura_curves/test_shimura_curves.py

@@ -938,7 +938,7 @@ def rational_points_description(self):
             elif curve.genus > 1 or (curve.genus == 1 and curve.rank == 0):
                 desc = "This Shimura curve has finitely many rational points."
         else:
-            desc = fr'Local obstructions for rational points on this curve are not known.'
+            desc = 'Local obstructions for rational points on this curve are not known.'
         if (self.genus > 1 or self.genus == 1 and self.rank == 0) and self.db_rational_points:
             desc += "  The following are the known rational points on this Shimura curve (one row per $j$-invariant)."
         return desc