Merge remote-tracking branch 'upstream/main' into wt/ai/t23-group-hashes

Author: roed314

.github/workflows/generate-matrix.py

@@ -5,7 +5,7 @@
 "lmfdb/tests/test_dynamic_knowls.py lmfdb/tests/test_root.py lmfdb/hecke_algebras/test_hecke_algebras.py lmfdb/tests/test_homepage.py lmfdb/elliptic_curves/test_ell_curves.py lmfdb/elliptic_curves/test_browse_page.py",
 "lmfdb/sato_tate_groups/test_st.py lmfdb/hilbert_modular_forms/test_hmf.py lmfdb/tests/test_spelling.py lmfdb/tests/test_template_namespace.py lmfdb/tests/test_acknowlegments.py lmfdb/tests/test_tensor_products.py",
 "lmfdb/cluster_pictures/test_clusterpicture.py lmfdb/local_fields/test_localfields.py lmfdb/ecnf/test_ecnf.py lmfdb/ecnf/test_isog_class.py lmfdb/api/test_api.py lmfdb/characters/test_characters.py",
-"lmfdb/users/test_users.py lmfdb/lattice/test_lattice.py lmfdb/maass_forms/test_maass.py lmfdb/higher_genus_w_automorphisms/test_hgcwa.py lmfdb/belyi/test_belyi.py lmfdb/hypergm/test_hgm.py lmfdb/tests/test_utils.py",
+"lmfdb/users/test_users.py lmfdb/lattice/test_lattice.py lmfdb/maass_forms/test_maass.py lmfdb/higher_genus_w_automorphisms/test_hgcwa.py lmfdb/belyi/test_belyi.py lmfdb/hypergm/test_hgm.py lmfdb/tests/test_utils.py lmfdb/tests/test_connection_reset.py",
 "lmfdb/artin_representations/test_artin_representation.py lmfdb/genus2_curves/test_genus2_curves.py",
 "lmfdb/classical_modular_forms/test_cmf.py lmfdb/classical_modular_forms/test_cmf2.py",
     "lmfdb/lfunctions/test_lfunctions.py",

.github/workflows/matrix_includes.json

@@ -60,12 +60,12 @@
         "server": "devmirror"
     },
     {
-        "files": "lmfdb/users/test_users.py lmfdb/lattice/test_lattice.py lmfdb/maass_forms/test_maass.py lmfdb/higher_genus_w_automorphisms/test_hgcwa.py lmfdb/belyi/test_belyi.py lmfdb/hypergm/test_hgm.py lmfdb/tests/test_utils.py",
+        "files": "lmfdb/users/test_users.py lmfdb/lattice/test_lattice.py lmfdb/maass_forms/test_maass.py lmfdb/higher_genus_w_automorphisms/test_hgcwa.py lmfdb/belyi/test_belyi.py lmfdb/hypergm/test_hgm.py lmfdb/tests/test_utils.py lmfdb/tests/test_connection_reset.py",
         "folders": "belyi higher_genus_w_automorphisms hypergm lattice maass_forms tests users",
         "server": "proddb"
     },
     {
-        "files": "lmfdb/users/test_users.py lmfdb/lattice/test_lattice.py lmfdb/maass_forms/test_maass.py lmfdb/higher_genus_w_automorphisms/test_hgcwa.py lmfdb/belyi/test_belyi.py lmfdb/hypergm/test_hgm.py lmfdb/tests/test_utils.py",
+        "files": "lmfdb/users/test_users.py lmfdb/lattice/test_lattice.py lmfdb/maass_forms/test_maass.py lmfdb/higher_genus_w_automorphisms/test_hgcwa.py lmfdb/belyi/test_belyi.py lmfdb/hypergm/test_hgm.py lmfdb/tests/test_utils.py lmfdb/tests/test_connection_reset.py",
         "folders": "belyi higher_genus_w_automorphisms hypergm lattice maass_forms tests users",
         "server": "devmirror"
     },

.github/workflows/python-package.yml

@@ -90,7 +90,7 @@ jobs:
     - name: checking that we didn't miss any test files
       shell: bash -l {0}
       # If this fails you need to update the file list above and file count
-      run: test $(find lmfdb -name 'test_*.py' -or -name '*_test.py' | wc -l) -eq 43
+      run: test $(find lmfdb -name 'test_*.py' -or -name '*_test.py' | wc -l) -eq 44
 
     - name: Config LMFDB to run tests against proddb
       if: matrix.files != 'lint' && matrix.server == 'proddb'

Development.md

@@ -60,7 +60,7 @@ mathematician, or the wikipedia article of someone famous.
 
 An object's home page should provide a wide variety of information about the
 object. Basic information, of interest to both experts and non-experts,
-should appear ear the top. More specialized information should appear
+should appear near the top. More specialized information should appear
 near the bottom.
 
 In the upper right corner of each home page should be the "properties" box,
@@ -209,7 +209,7 @@ Here are some conventions the LMFDB uses:
 
 1. If X is the URL of an object, then L/X is the URL of its standard
    L-function. According to the Langlands program, other L-functions
-   associated to X may be written on the the form L(s, X, rho). Examples include
+   associated to X may be written in the form L(s, X, rho). Examples include
 
    - L(s, f, sym^2)
    - L(s, f, spin)
@@ -246,7 +246,7 @@ Here are some conventions the LMFDB uses:
    Qsqrt5 as a search parameter for the coefficient field.
 
    Note that number fields like Qsqrt5 has an "official name" as well as a
-   nickname. Many discussions have occurred for what appropriate labels for
+   nickname. Many discussions have occurred about what appropriate labels for
    objects should be. Examine the structure of existing objects in the
    LMFDB very closely to maintain correct labels and relationships.
 
@@ -269,9 +269,9 @@ Here are some conventions the LMFDB uses:
    - `/Motive/Hypergeometric/Q/\<label>`
    - `/NumberField/\<label>`
 
-In practice, prior to deciding on a labelling scheme for new objects, one
+In practice, prior to deciding on a labeling scheme for new objects, one
 should talk to the current LMFDB developers (who now have a lot of experience
-in considering labelling schemes).
+in considering labeling schemes).
 
 
 Templates
@@ -347,7 +347,7 @@ Testing
   ```
   It takes a few minutes. If sage or some additional parts are missing it may fail,
   consider updating
-  (see [Getting Started](https://github.com/LMFDB/lmfdb/wiki/GettingStarted) )
+  (see [Getting Started](https://github.com/LMFDB/lmfdb/wiki/GettingStarted))
 
 - New blueprints and features should include a `test_<name>.py` file
   which runs tests on all functions.
@@ -382,7 +382,7 @@ field:
 
 ### Snippet testing
 
-Sometimes computer algebra systems make breaking changes which render the code snippets invalid. To catch this, there's a testing system for snippets implemented in `lmfdb/tests/generate_snippet_tests.py`. This runs the code line by line in the various CAS-es, excluding magma. It does not test correctness of the results, only consistency, by comparing with previous results stored in the `lmfdb/tests/snippet_tests` directory. Normally (and at the time of writing), this is run automatically by Github Actions, which generates the relevant log files. However, it is possible to run it manually using the CLI tool
+Sometimes computer algebra systems make breaking changes which render the code snippets invalid. To catch this, there's a testing system for snippets implemented in `lmfdb/tests/generate_snippet_tests.py`. This runs the code line by line in the various CAS-es. It does not test correctness of the results, only consistency, by comparing with previous results stored in the `lmfdb/tests/snippet_tests` directory. Normally (and at the time of writing), this is run automatically by Github Actions, which generates the relevant log files. However, it is possible to run it manually using the CLI tool
 
 ```bash
 sage --python ./lmfdb/tests/generate_snippet_tests.py  -h
@@ -430,15 +430,15 @@ this puts you inside an interactive python debugger, where you can:
 - continue executing code using the `n` command.
 
 If you get lost, the command `bt` shows you exactly where you
-are, and `up` helps you to get on step up on the stack.
+are, and `up` helps you to get one step up on the stack.
 Of course, `help <command>` will tell you more.
 
 Git Tips
 =========
 
 Contributing to the LMFDB requires some familiarity with git, a popular version control system which LMFDB uses. The LMFDB code base is hosted on Github, which is a common hosting service owned by Microsoft.
 - [Official git tutorial](https://git-scm.com/docs/gittutorial) and [Github's git guide](https://github.com/git-guides)
-- Use a global .gitignore file to exclude temporary files like `.DS_store` or `main.py~`; [copy-paste ready instructions on github](https://help.github.com/articles/ignoring-files#global-gitignore).
+- Use a global .gitignore file to exclude temporary files like `.DS_Store` or `main.py~`; [copy-paste ready instructions on github](https://help.github.com/articles/ignoring-files#global-gitignore).
 - Configure your global .gitconfig for shortcuts or global configuration options; for example:
   ```
 [alias]

GettingStarted.md

@@ -46,7 +46,7 @@ Installation
  * Install dependencies.  This requires you to have write access to the
    Sage installation directory, so should be no problem on a personal
    machine, but if you are using a system-wide Sage install on a shared
-   machine, you will need ask a system administrator to do this step.
+   machine, you will need to ask a system administrator to do this step.
 
    ```
    sage -i gap_packages
@@ -76,13 +76,13 @@ Installation
      that). This problem does seem to be resolved for Sage 9.3beta, and it is currently
      unclear if the problem exists for Sage 9.0 or 9.1.
 
-   - In case the last step fails by is Mac OSX with the error
+   - In case the last step fails on Mac OSX with the error
 
      ```
      Error: pg_config executable not found.
      ```
 
-     we recommend to installing PostgreSQL by doing
+     we recommend installing PostgreSQL by doing
 
      ```
      brew install postgresql
@@ -104,9 +104,9 @@ Installation
    - [optional] Memcache.  *This step is not at all necessary and can
      safely be ignored!* Memcache speeds up recompilation of python
      modules during development.  Using it requires both installing the
-     appropriate package for your Operating System and installing an
+     appropriate package for your operating system and installing an
      additional python module.  The first line below needs to be run in
-     a Sage shell, and the for second you need to be a super-user to
+     a Sage shell, and for the second you need to be a super-user to
      install memcached if your machine does not have it.
 
      * `easy_install -U python-memcached`
@@ -141,7 +141,7 @@ Running
  * When running with `--debug`, whenever a python (*.py) file changes
    the server will reload automatically.  If you save while editing
    at a point where such a file is not syntactically correct, the
-   server will crash and you will need to `start_lmfdb` again.   Any
+   server will crash and you will need to `start-lmfdb` again.   Any
    changes to html files will not cause the server to restart, so
    you will need to reload the pages in your browser.  Changes in
    the yaml files which are read only once at startup will require
@@ -167,8 +167,8 @@ Running
 CoCalc
 ======
 
- * You can run the LMFDB inside a [CoCalc](https://www.cocalc.com) project by doing
-   following the above installation instructions on a terminal in your project (you may want to
+ * You can run the LMFDB inside a [CoCalc](https://www.cocalc.com) project by following
+   the above installation instructions on a terminal in your project (you may want to
    install the requirements using the `--user` flag).
    Explicitly,
 
@@ -194,7 +194,7 @@ Troubleshooting
 ===============
 
 [warning] Recently on some linux machines, users have had to install the
-contents of requirements.txt by manually.  If the above instructions do not
+contents of requirements.txt manually.  If the above instructions do not
 work, un-install the above packages and re-install them one at a time,
 including those in requirements.txt.
 
@@ -259,10 +259,10 @@ Code development and sharing your work
    branches upstream to be aware of: `web`, `dev` and `main`:
 
    - `web` is changed rarely and contains the code currently running at
-     [www.lmfdb.org](www.lmfdb.org)
+     [www.lmfdb.org](https://www.lmfdb.org)
 
    - `dev` is changed more often and contains the code currently running at
-     [beta.lmfdb.org](beta.lmfdb.org)
+     [beta.lmfdb.org](https://beta.lmfdb.org)
 
    - `main` is the development branch.
 
@@ -323,5 +323,5 @@ For anyone who would like to attempt it, the following steps should theoreticall
  * Now you need to run ssh-keygen within the Sage appliance and e-mail the result to Harald Schilly, Jonathan Bober or John Cremona (see above).
    Since copy-and-paste can be tricky from inside the virtual image, we suggest writing to a file shared by the host OS.
 
- * The instructions for Linux/OS X should now work.  You should be able to forward the mongo database and run `sage -python start-lmfdb.py` within the Sage appliance,
+ * The instructions for Linux/OS X should now work.  You should be able to run `sage -python start-lmfdb.py` within the Sage appliance,
    and access the resulting website from your host OS' web browser.