Harmless but wrong boolean operator

rogerbinns · rogerbinns · commit 1ab49df31d9f · 2025-11-05T09:43:29.000-08:00
Warning by clang on macos
diff --git a/src/connection.c b/src/connection.c
@@ -4634,7 +4634,7 @@ Connection_exit(PyObject *self_, PyObject *const *fast_args, Py_ssize_t fast_nar
   {
     res = OK;
     int i_did_commit = 0;
-    if (Py_IsNone(etype) || Py_IsNone(evalue) && Py_IsNone(etraceback))
+    if (Py_IsNone(etype) && Py_IsNone(evalue) && Py_IsNone(etraceback))
     {
       res = connection_context_manager_exec(self, "COMMIT", 0, 0);
       i_did_commit = 1;

Original file line number	Diff line number	Diff line change
`@@ -4634,7 +4634,7 @@ Connection_exit(PyObject self_, PyObject const *fast_args, Py_ssize_t fast_nar`
`4634`	`4634`	`{`
`4635`	`4635`	`res = OK;`
`4636`	`4636`	`int i_did_commit = 0;`
`4637`		`- if (Py_IsNone(etype) \|\| Py_IsNone(evalue) && Py_IsNone(etraceback))`
	`4637`	`+ if (Py_IsNone(etype) && Py_IsNone(evalue) && Py_IsNone(etraceback))`
`4638`	`4638`	`{`
`4639`	`4639`	`res = connection_context_manager_exec(self, "COMMIT", 0, 0);`
`4640`	`4640`	`i_did_commit = 1;`