Infinity is 9e999 not 1e999

Author: rogerbinns

apsw/__init__.pyi

@@ -305,7 +305,7 @@ def format_sql_value(value: SQLiteValue) -> str:
 
     Note that SQLite represents floating point `Nan
     <https://en.wikipedia.org/wiki/NaN>`__ as :code:`NULL`, infinity as
-    :code:`1e999` and loses the sign on `negative zero
+    :code:`9e999` and loses the sign on `negative zero
     <https://en.wikipedia.org/wiki/Signed_zero>`__."""
     ...
 

apsw/tests/__main__.py

@@ -1425,8 +1425,8 @@ def testFormatSQLValue(self):
             (wt[:77] + "'" + wt[77:], "'" + wt[:77] + "''" + wt[77:] + "'"),
             # SQLite doesn't understand 'inf', 'nan' or negative zero
             # so output what it does
-            (math.inf, "1e999"),
-            (-math.inf, "-1e999"),
+            (math.inf, "9e999"),
+            (-math.inf, "-9e999"),
             (math.nan, "NULL"),
             (-0.0, "0.0"),
         )
@@ -9138,7 +9138,7 @@ def __init__(self):
         def testnasty():
             reset()
             cmd("""create table if not exists nastydata(x,y);
-                 insert into nastydata values(x'', 1e999); -- see issue 482 for zero sized blob
+                 insert into nastydata values(x'', 9e999); -- see issue 482 for zero sized blob
                  insert into nastydata values(null,'xxx\\u1234\\uabcdyyy\r\n\t\"this is nasty\u0001stuff!');
                 """)
             s.cmdloop()

src/apsw.c

@@ -1401,7 +1401,7 @@ get_keywords(void)
 
   Note that SQLite represents floating point `Nan
   <https://en.wikipedia.org/wiki/NaN>`__ as :code:`NULL`, infinity as
-  :code:`1e999` and loses the sign on `negative zero
+  :code:`9e999` and loses the sign on `negative zero
   <https://en.wikipedia.org/wiki/Signed_zero>`__.
 */
 static PyObject *
@@ -1422,7 +1422,7 @@ formatsqlvalue(PyObject *Py_UNUSED(self), PyObject *value)
     if (isnan(d))
       return Py_NewRef(apst.sNULL);
     if (isinf(d))
-      return Py_NewRef(signbit(d) ? apst.s_1e999 : apst.s1e999);
+      return Py_NewRef(signbit(d) ? apst.s_9e999 : apst.s9e999);
     if (d == 0 && signbit(d))
       return Py_NewRef(apst.s0_0);
     return PyObject_Str(value);

src/stringconstants.c

@@ -6,9 +6,9 @@
 
 
 #undef closed
-#undef s_1e999
+#undef s_9e999
 #undef s0_0
-#undef s1e999
+#undef s9e999
 #undef no_change
 #undef Begin
 #undef BestIndex
@@ -92,9 +92,9 @@
 static struct _apsw_string_table
 {
     PyObject *closed;
-    PyObject *s_1e999;
+    PyObject *s_9e999;
     PyObject *s0_0;
-    PyObject *s1e999;
+    PyObject *s9e999;
     PyObject *no_change;
     PyObject *Begin;
     PyObject *BestIndex;
@@ -179,9 +179,9 @@ static void
 fini_apsw_strings(void)
 {
     Py_CLEAR(apst.closed);
-    Py_CLEAR(apst.s_1e999);
+    Py_CLEAR(apst.s_9e999);
     Py_CLEAR(apst.s0_0);
-    Py_CLEAR(apst.s1e999);
+    Py_CLEAR(apst.s9e999);
     Py_CLEAR(apst.no_change);
     Py_CLEAR(apst.Begin);
     Py_CLEAR(apst.BestIndex);
@@ -267,9 +267,9 @@ static int
 init_apsw_strings()
 {
     if ((!apst.closed && 0 == (apst.closed = PyUnicode_FromString("(closed)")))
-        || (!apst.s_1e999 && 0 == (apst.s_1e999 = PyUnicode_FromString("-1e999")))
+        || (!apst.s_9e999 && 0 == (apst.s_9e999 = PyUnicode_FromString("-9e999")))
         || (!apst.s0_0 && 0 == (apst.s0_0 = PyUnicode_FromString("0.0")))
-        || (!apst.s1e999 && 0 == (apst.s1e999 = PyUnicode_FromString("1e999")))
+        || (!apst.s9e999 && 0 == (apst.s9e999 = PyUnicode_FromString("9e999")))
         || (!apst.no_change && 0 == (apst.no_change = PyUnicode_FromString("<apsw.no_change>")))
         || (!apst.Begin && 0 == (apst.Begin = PyUnicode_FromString("Begin")))
         || (!apst.BestIndex && 0 == (apst.BestIndex = PyUnicode_FromString("BestIndex")))

tools/genstrings.py

@@ -39,7 +39,7 @@
 
 step final value inverse
 
-NULL 0.0 -1e999 1e999
+NULL 0.0 -9e999 9e999
 (closed)
 
 release UPDATE INSERT DELETE
@@ -52,8 +52,8 @@ def mangle(name):
     return {
         "NULL": "sNULL",
         "0.0": "s0_0",
-        "-1e999": "s_1e999",
-        "1e999": "s1e999",
+        "-9e999": "s_9e999",
+        "9e999": "s9e999",
         "(closed)": "closed",
         "<apsw.no_change>": "no_change",
     }.get(name, name)