Should these be -= instead of += as you intend to unsubscribe the events on Dispose?

[UnreachableCode]

Xamarin-Forms-Custom-Renderer-Samples/Droid/SearchPageRenderer.cs

Line 33 in 1e144d3

_searchView.QueryTextChange += searchView_QueryTextChange;

[rohitvipin]

Yes, that is right. Would you mind doing a PR

…

On Wed 2 May, 2018, 9:48 AM Charlie Finlayson, ***@***.***> wrote: https://github.com/rohitvipin/Xamarin-Forms-Custom-Renderer-Samples/blob/1e144d384cfa7e8f5ade440fdcc0f6814e12d01f/Droid/SearchPageRenderer.cs#L33 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK7Z6Hysilwb4cpaoPwuWTobz2eF-5zNks5tucdYgaJpZM4TvmX1> .