Skip to content

Commit ab734ed

Browse files
committed
bug: remove empty config in multus examples
Empty config in multus, empty multus config is created causing nodes to be in not ready state. Signed-off-by: Fred Rolland <[email protected]>
1 parent ab33ce2 commit ab734ed

10 files changed

+1
-11
lines changed

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ spec:
157157
repository: ghcr.io/k8snetworkplumbingwg
158158
version: v3.9.3
159159
# if config is missing or empty then multus config will be automatically generated from the CNI configuration file of the master plugin (the first file in lexicographical order in cni-conf-dir)
160-
config: ''
160+
# config: ''
161161
ipamPlugin:
162162
image: whereabouts
163163
repository: ghcr.io/k8snetworkplumbingwg
@@ -215,7 +215,6 @@ spec:
215215
image: multus-cni
216216
repository: ghcr.io/k8snetworkplumbingwg
217217
version: v3.9.3
218-
config: ''
219218
nvIpam:
220219
image: nvidia-k8s-ipam
221220
repository: ghcr.io/mellanox

example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-full.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ spec:
9191
image: multus-cni
9292
repository: ghcr.io/k8snetworkplumbingwg
9393
version: v4.1.0
94-
config: ''
9594
ipamPlugin:
9695
image: whereabouts
9796
repository: ghcr.io/k8snetworkplumbingwg

example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ipoib.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ spec:
6969
image: multus-cni
7070
repository: ghcr.io/k8snetworkplumbingwg
7171
version: v4.1.0
72-
config: ''
7372
ipamPlugin:
7473
image: whereabouts
7574
repository: ghcr.io/k8snetworkplumbingwg

example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-nvidia-ipam.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ spec:
6565
image: multus-cni
6666
repository: ghcr.io/k8snetworkplumbingwg
6767
version: v4.1.0
68-
config: ''
6968
nvIpam:
7069
image: nvidia-k8s-ipam
7170
repository: ghcr.io/mellanox

example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ spec:
6565
image: multus-cni
6666
repository: ghcr.io/k8snetworkplumbingwg
6767
version: v4.1.0
68-
config: ''
6968
ipamPlugin:
7069
image: whereabouts
7170
repository: ghcr.io/k8snetworkplumbingwg

example/dgx-helm-values.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ secondaryNetwork:
3838
repository: ghcr.io/k8snetworkplumbingwg
3939
version: v3.8
4040
imagePullSecrets: []
41-
config: ''
4241
ipamPlugin:
4342
deploy: true
4443
image: whereabouts

hack/templates/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-full.template

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ spec:
9191
image: {{ .Multus.Image }}
9292
repository: {{ .Multus.Repository }}
9393
version: {{ .Multus.Version }}
94-
config: ''
9594
ipamPlugin:
9695
image: {{ .IpamPlugin.Image }}
9796
repository: {{ .IpamPlugin.Repository }}

hack/templates/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ipoib.template

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ spec:
6969
image: {{ .Multus.Image }}
7070
repository: {{ .Multus.Repository }}
7171
version: {{ .Multus.Version }}
72-
config: ''
7372
ipamPlugin:
7473
image: {{ .IpamPlugin.Image }}
7574
repository: {{ .IpamPlugin.Repository }}

hack/templates/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-nvidia-ipam.template

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ spec:
6565
image: {{ .Multus.Image }}
6666
repository: {{ .Multus.Repository }}
6767
version: {{ .Multus.Version }}
68-
config: ''
6968
nvIpam:
7069
image: {{ .NvIPAM.Image }}
7170
repository: {{ .NvIPAM.Repository }}

hack/templates/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr.template

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ spec:
6565
image: {{ .Multus.Image }}
6666
repository: {{ .Multus.Repository }}
6767
version: {{ .Multus.Version }}
68-
config: ''
6968
ipamPlugin:
7069
image: {{ .IpamPlugin.Image }}
7170
repository: {{ .IpamPlugin.Repository }}

0 commit comments

Comments
 (0)