chore: check nic conf helm sub chart

Signed-off-by: Fred Rolland <[email protected]>

Author: rollandf

.github/workflows/checks.yaml

@@ -78,6 +78,20 @@ jobs:
         uses: actions/checkout@v4
       - name: check release-build
         run: make check-release-build
+  diff-helm-sub-charts:
+    name: check update-helm-sub-charts
+    runs-on: ubuntu-22.04
+    permissions:
+      contents: read
+    steps:
+      - name: Set up Go 1.x
+        uses: actions/setup-go@v5
+        with:
+          go-version: '1.23'
+      - name: checkout
+        uses: actions/checkout@v4
+      - name: check release-build
+        run: make check-update-helm-sub-charts
   unit-tests:
     name: Unit-tests
     runs-on: ubuntu-22.04

Makefile

@@ -21,6 +21,7 @@ CHART_PATH=$(CURDIR)/deployment/$(PACKAGE)
 TOOLSDIR=$(CURDIR)/hack/tools/bin
 MANIFESTDIR=$(CURDIR)/hack/manifests
 BUILDDIR=$(CURDIR)/build/_output
+HELM_CHART_DEP_CHECKDIR=$(CURDIR)/build/helmcharts
 GOFILES=$(shell find . -name "*.go" | grep -vE "(\/vendor\/)|(_test.go)")
 TESTPKGS=./...
 ENVTEST_K8S_VERSION=1.28
@@ -109,6 +110,9 @@ $(MANIFESTDIR):
 $(BUILDDIR): ; $(info Creating build directory...)
 	mkdir -p $@
 
+$(HELM_CHART_DEP_CHECKDIR):
+	mkdir -p $@
+
 build: generate $(BUILDDIR)/$(BINARY_NAME) ; $(info Building $(BINARY_NAME)...) @ ## Build executable file
 	$(info Done!)
 
@@ -238,11 +242,12 @@ lint-helm: $(HELM) ; $(info  running lint for helm charts...) @ ## Run helm lint
 .PHONY: check-manifests
 check-manifests: generate manifests
 	$(info checking for git diff after running 'make manifests')
-	git diff --quiet ; if [ $$? -eq 1 ] ; then echo "Please, commit manifests after running 'make manifests' and 'make generate' commands"; exit 1 ; fi
+	@git diff --quiet || (echo "Error: Please, commit manifests after running 'make manifests' and 'make generate' commands' command" && exit 1)
 
 .PHONY: check-go-modules
 check-go-modules: generate-go-modules
-	git diff --quiet HEAD go.sum; if [ $$? -eq 1 ] ; then echo "go.sum is out of date. Please commit after running 'make generate-go-modules' command"; exit 1; fi
+	$(info checking for git diff after running 'make generate-go-modules')
+	@git diff --quiet || (echo "Error: go.sum is out of date. Please commit after running 'make generate-go-modules' command" && exit 1)
 
 .PHONY: generate-go-modules
 generate-go-modules:
@@ -251,7 +256,13 @@ generate-go-modules:
 .PHONY: check-release-build
 check-release-build: release-build
 	$(info checking for git diff after running 'make release-build')
-	git diff --quiet ; if [ $$? -eq 1 ] ; then echo "Please, commit templates after running 'make release-build' command"; exit 1 ; fi
+	@git diff --quiet || (echo "Error: Please commit templates after running 'make release-build' command" && exit 1)
+
+.PHONY: check-update-helm-sub-charts
+check-update-helm-sub-charts: update-helm-sub-charts
+	$(info checking for git diff after running 'make update-helm-sub-charts')
+	@git diff --quiet || (echo "Error: Please commit Helm Chart changes after running 'make update-helm-sub-charts' command" && exit 1)
+
 
 TEST_TARGETS := test-default test-bench test-short test-verbose test-race
 .PHONY: $(TEST_TARGETS) test-xml check test tests
@@ -414,6 +425,17 @@ release-build:
 	cd hack && $(GO) run release.go --templateDir ./templates/values/ --outputDir ../deployment/network-operator/
 	cd hack && $(GO) run release.go --templateDir ./templates/config/manager --outputDir ../config/manager/
 
+.PHONY: helm-update-nic-configuration
+helm-update-nic-configuration: $(HELM) $(HELM_CHART_DEP_CHECKDIR)
+	rm -rf ./build/helmcharts/nic-configuration-operator-chart
+	@NIC_CONF_VERSION=$$(yq '.nicConfigurationOperator.version' hack/release.yaml | sed 's/^v//'); \
+	$(HELM) pull oci://ghcr.io/mellanox/nic-configuration-operator-chart  --version $$NIC_CONF_VERSION -d $(HELM_CHART_DEP_CHECKDIR) --untar
+	rsync -av --exclude='Chart.yaml' $(HELM_CHART_DEP_CHECKDIR)/nic-configuration-operator-chart deployment/network-operator/charts/
+
+.PHONY: update-helm-sub-charts
+update-helm-sub-charts: helm-update-nic-configuration
+
+
 # dev environment
 
 MINIKUBE_CLUSTER_NAME = net-op-dev