From c3f869e926d379ff1772e6d0b2d4af6c5f4f933b Mon Sep 17 00:00:00 2001 From: Matias Pequeno Date: Tue, 25 Mar 2025 11:28:21 -0300 Subject: [PATCH] Fixed warnings and hints before publishing --- rollbar_common/CHANGELOG.md | 2 ++ rollbar_common/lib/src/extension/function.dart | 2 +- rollbar_common/pubspec.yaml | 2 +- rollbar_common/test/table_set_test.dart | 4 ++-- rollbar_dart/CHANGELOG.md | 1 + rollbar_dart/pubspec.yaml | 2 +- 6 files changed, 8 insertions(+), 5 deletions(-) diff --git a/rollbar_common/CHANGELOG.md b/rollbar_common/CHANGELOG.md index 83afb450..66447de2 100644 --- a/rollbar_common/CHANGELOG.md +++ b/rollbar_common/CHANGELOG.md @@ -4,6 +4,8 @@ - Updated http library to '>=0.13.0 <2.0.0' - Updated uuid library to '^4.1.0' +- Updated sdk constraint to '>=2.17.0 <4.0.0' +- Fixed warnings about the value of 'identity' not being used. ## 1.1.0 diff --git a/rollbar_common/lib/src/extension/function.dart b/rollbar_common/lib/src/extension/function.dart index 4417b865..c49a3f4b 100644 --- a/rollbar_common/lib/src/extension/function.dart +++ b/rollbar_common/lib/src/extension/function.dart @@ -55,7 +55,7 @@ bool isNotNull(T? x) => x != null; /// ``` /// id := λx.x where x: bool ≡ bool isTrue(bool x) => x; /// ``` -const isTrue = identity; +bool isTrue(bool x) => x; /// Tests whether the given boolean argument [x] is false. /// diff --git a/rollbar_common/pubspec.yaml b/rollbar_common/pubspec.yaml index 0853fa6d..45f702dc 100644 --- a/rollbar_common/pubspec.yaml +++ b/rollbar_common/pubspec.yaml @@ -6,7 +6,7 @@ documentation: https://docs.rollbar.com/docs/flutter#dart repository: https://github.com/rollbar/rollbar-flutter environment: - sdk: '>=2.17.0 <3.0.0' + sdk: '>=2.17.0 <4.0.0' dependencies: http: '>=0.13.0 <2.0.0' diff --git a/rollbar_common/test/table_set_test.dart b/rollbar_common/test/table_set_test.dart index cf5e9c2d..c7a8c9c7 100644 --- a/rollbar_common/test/table_set_test.dart +++ b/rollbar_common/test/table_set_test.dart @@ -58,7 +58,7 @@ void main() { expect(payloadRecords.length, ++recordsCount); } - for (final record in payloadRecords.map(identity)) { + for (final record in payloadRecords.map((x) => x)) { expect(payloadRecords.remove(record), isTrue); expect(payloadRecords.record(id: record.id), isNull); expect(payloadRecords.length, --recordsCount); @@ -152,7 +152,7 @@ void main() { expect(payloadRecords.length, 16); final transformResult = payloadRecords.map(records.contains); - expect(transformResult.all(identity), isTrue); + expect(transformResult.all((x) => x), isTrue); for (final record in payloadRecords) { expect(records.contains(record), isTrue); diff --git a/rollbar_dart/CHANGELOG.md b/rollbar_dart/CHANGELOG.md index 1139a243..055ab25d 100644 --- a/rollbar_dart/CHANGELOG.md +++ b/rollbar_dart/CHANGELOG.md @@ -3,6 +3,7 @@ ## 1.3.2 - Updated http library to '>=0.13.0 <2.0.0' +- Updated sdk constraint to '>=2.17.0 <4.0.0' - Fixed usage of unsafe_html which was removed in Dart 3.7.0. ## 1.3.1 diff --git a/rollbar_dart/pubspec.yaml b/rollbar_dart/pubspec.yaml index 891de119..4ce6d84b 100644 --- a/rollbar_dart/pubspec.yaml +++ b/rollbar_dart/pubspec.yaml @@ -6,7 +6,7 @@ documentation: https://docs.rollbar.com/docs/flutter#dart repository: https://github.com/rollbar/rollbar-flutter environment: - sdk: '>=2.17.0 <3.0.0' + sdk: '>=2.17.0 <4.0.0' dependencies: http: '>=0.13.0 <2.0.0'