Open
Description
Steps to reproduce:
Try to add some scope with a false
value:
Rollbar.scoped(example: false) { Rollbar.error(Exception.new) }
Observed:
- the
example
key does not appear on the exception - If you use any other truthy value (including
true
, numbers, or anthing else other thannil
) it sends correctely
Desired:
false
andtrue
are treated the same way. Maybenil
is different?
Notes:
- The behavior comes from this line - that condition is falsy with
false
ornil
so nothing is done - Maybe the behavior of
false
andnil
should be thought about here? To mefalse
should be merged in like a normal value andnil
indicates that we want to remove that value in the merged hash. But maybe others feel differently?