fix(constants): bug in isValidLevel implementation fixed

eudaimos · eudaimos · commit 64c3b08c4f9b · 2021-04-16T15:13:53.000-07:00
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@rollbar/react",
-  "version": "0.7.1",
+  "version": "0.7.2",
   "description": "React features to enhance using Rollbar.js in React Applications",
   "main": "lib",
   "module": "dist",
diff --git a/src/utils.js b/src/utils.js
@@ -14,5 +14,6 @@ export function wrapValue(val, defaultAs) {
 }
 
 export function isValidLevel(level) {
-  return VALID_LEVELS[level] >= constants.LEVEL_DEBUG && VALID_LEVELS[level] <= constants.LEVEL_CRITICAL;
+  return VALID_LEVELS[level] >= VALID_LEVELS[constants.LEVEL_DEBUG]
+    && VALID_LEVELS[level] <= VALID_LEVELS[constants.LEVEL_CRITICAL];
 }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@rollbar/react",`
`3`		`- "version": "0.7.1",`
	`3`	`+ "version": "0.7.2",`
`4`	`4`	`"description": "React features to enhance using Rollbar.js in React Applications",`
`5`	`5`	`"main": "lib",`
`6`	`6`	`"module": "dist",`
Original file line number	Diff line number	Diff line change
`@@ -14,5 +14,6 @@ export function wrapValue(val, defaultAs) {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`export function isValidLevel(level) {`
`17`		`- return VALID_LEVELS[level] >= constants.LEVEL_DEBUG && VALID_LEVELS[level] <= constants.LEVEL_CRITICAL;`
	`17`	`+ return VALID_LEVELS[level] >= VALID_LEVELS[constants.LEVEL_DEBUG]`
	`18`	`+ && VALID_LEVELS[level] <= VALID_LEVELS[constants.LEVEL_CRITICAL];`
`18`	`19`	`}`