chore: workaround vite package build error

[hi-ogawa]

Description

In addition to rolldown/rolldown#1642, it looks like replaceConfusingTypeNames is messing with vite package build. I haven't checked the error in a detail, but maybe it's okay to skip it for starter?

I temporary included a patch for binding.d.ts type error in the PR to verify pnpm build succeeds.

[IWANABETHATGUY]

The latest rolldown should be 0.12.1

[hi-ogawa]

Thanks for the heads up! I'll test that with 0.12.1

[hi-ogawa]

Starting to check tests failure. Let me put some notes here

playground/external

EDIT: fixed by #31

before

//
// node_modules/.vite/deps/@vitejs_test-dep-that-requires.js?v=7ce498d7
//
import {
  require_vue
} from "/node_modules/.vite/deps/chunk-ACQTEB6D.js?v=d821959b";
import {
  require_slash
} from "/node_modules/.vite/deps/chunk-PNJKIXPP.js?v=d821959b";

// ../../node_modules/.pnpm/@vitejs+test-dep-that-requires@[email protected]/node_modules/@vitejs/test-dep-that-requires/index.js
var { version } = require_vue();
var slash3 = require_slash();
document.querySelector("#required-vue-version").textContent = version;
document.querySelector("#required-slash3-exists").textContent = !!slash3("foo/bar");
//# sourceMappingURL=@vitejs_test-dep-that-requires.js.map

//
// node_modules/.vite/deps/chunk-ACQTEB6D.js
//
import {
  __commonJS
} from "./chunk-PNJKIXPP.js";

// vite:cjs-external-facade:vue
import * as m from "vue";
var require_vue = __commonJS({
  "vite:cjs-external-facade:vue"(exports, module) {
    module.exports = m;
  }
});

export {
  require_vue
};

after

• require('vue') is failing on browser.
• rolldownCjsExternalPlugin.resolveId is not called for vue which is in external

import { require_slash_index } from "/node_modules/.vite/deps/slash_index--Dt2Pc4V.js?v=31538b99";

//#region ../../node_modules/.pnpm/@vitejs+test-dep-that-requires@[email protected]/node_modules/@vitejs/test-dep-that-requires/index.js
const { version } = require('vue');
const slash3 = require_slash_index();
document.querySelector('#required-vue-version').textContent = version;
document.querySelector('#required-slash3-exists').textContent = !!slash3('foo/bar');

//#endregion
//# sourceMappingURL=@vitejs_test-dep-that-requires.js.map

---

playground/dynamic-import

(EDIT: reported upstream rolldown/rolldown#1723)

vite/playground/dynamic-import/pkg/index.js

Line 1 in bf3d711

import('./pkg.css')

before

// node_modules/.vite/deps/@vitejs_test-pkg.js
import("/home/hiroshi/code/others/vite/node_modules/.pnpm/@vitejs+test-pkg@file+playground+dynamic-import+pkg/node_modules/@vitejs/test-pkg/pkg.css");

after

// node_modules/.vite/deps/@vitejs_test-pkg.js
// not transformed
import('./pkg.css');

// then after vite import analysis rewrite
import("/node_modules/.vite/deps/pkg.css?v=b4888b04")

---

playground/ssr-noexternal

(EDIT: fixed by rolldown/rolldown#1655)

Error during ssr optimizeDeps. It looks like this is because of banner function. () => Promise<string> works but () => string fails.

Error: Rolldown internal error: InvalidArg, UNKNOWN_RETURN_VALUE. Cannot convert unknown to `Option<String>` in ThreadsafeFunction<RenderedChunk, Either<Either<Promise<Option<String>>, Option<String>>, UnknownReturnValue>, RenderedChunk, false>

---

playground/ssr-deps

Probably a same error as playground/ssr-noexternal above.

---

playground/tsconfig-json

Rolldown is throwing an error during deps scan since it uses esbuild's transform here but without user tsconfig which enables experimentalDecorators (cf. vitejs#15206).
See also #24 (comment).

vite/packages/vite/src/node/optimizer/scan.ts

Lines 1023 to 1025 in 9fdf94a

	if (loader !== 'js') {
	contents = (await transform(contents, { loader })).code
	}

---

playground/alias

(EDIT: reported upstream rolldown/rolldown#1722)

There's an error during deps optimization bundle.write.

thread 'tokio-runtime-worker' panicked at crates/rolldown/src/utils/chunk/render_chunk_exports.rs:29:53:
no entry found for key
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

It seems this alias is the problem.

vite/playground/alias/vite.config.js

Lines 25 to 26 in c5f38bf

	// aliasing one unoptimized dep to an optimized dep
	{ find: 'foo', replacement: 'vue' },

  flatIdDeps: {
    '@vue_shared': '/home/hiroshi/code/others/vite/node_modules/.pnpm/@[email protected]/node_modules/@vue/shared/dist/shared.cjs.prod.js',
    'aliased-module_index__js': '/home/hiroshi/code/others/vite/node_modules/.pnpm/@vitejs+test-aliased-module@file+playground+alias+dir+module/node_modules/@vitejs/test-aliased-module/index.js',
    vue: '/home/hiroshi/code/others/vite/node_modules/.pnpm/[email protected][email protected]/node_modules/vue/dist/vue.esm-bundler.js',
    foo: '/home/hiroshi/code/others/vite/node_modules/.pnpm/[email protected][email protected]/node_modules/vue/dist/vue.runtime.esm-bundler.js'
  },

[hi-ogawa]

I made separate PRs to fix playground/external (#31) and fix playground/tsconfig-json (#32).

playground/ssr-noexternal and playground/ssr-deps are fixed in rolldown rolldown/rolldown#1655

For the remaining issues, I made a repro on rolldown repo: playground/dynamic-import (rolldown/rolldown#1723) and playground/alias (rolldown/rolldown#1722).

I'm closing this PR since the same change is included in other PR.