484-fix: Course pages info duplication #853
Conversation
github-actions
bot
changed the title
YuliaDemir
changed the title
YulikK
added
⚔️padawans
feature
|
Lighthouse Report:
|
|
Lighthouse Report:
|
| The course | ||
| {' '} | ||
| <LinkCustom | ||
| href={COURSE_SCHEDULE_LINKS[courseName]?.toString()} |
There was a problem hiding this comment.
I have doubts about the implementation of processing both a string and an array of strings as a reference for the href. I understand that my current option is bad, but the array option seems to me to be a rather unique case and I haven't figured out how to do it better in the general case. Should i store each link as an single-element array?
dev-data/about-course.data.tsx
Outdated
| <Paragraph> | ||
| All materials are publicly available on the | ||
| {' '} | ||
| <LinkCustom href="https://www.youtube.com/c/RSschool" external> |
There was a problem hiding this comment.
this canal for JS EN. For other courses we can use this link https://www.youtube.com/c/RollingScopesSchool
And lets use constant here, maybe communityGroups
There was a problem hiding this comment.
The Russian versions do not have a section about materials. Do I need to create a constant about materials for the Russian?
|
Lighthouse Report:
|
|
Lighthouse Report:
|
YuliaDemir
force-pushed
the
fix/484-course-pages-info-duplication
branch
from
2c84853 to
06d859a
Compare
|
Lighthouse Report:
|
YulikK
changed the title
|
Lighthouse Report:
|
|
Lighthouse Report:
|
What type of PR is this? (select all that apply)
Description
Related Tickets & Documents
Screenshots, Recordings
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?