873-feat: Update jetbrans logo #878

chmdln · 2025-05-07T19:03:00Z

What type of PR is this? (select all that apply)

Description

This PR request updates the jetBrains logo in "Partnered with" section of the site.

Related Tickets & Documents

Related Issue #
Closes Update jetBrains logo #873

Screenshots, Recordings

Added/updated tests?

👌 Yes
🙅‍♂️ No, because they aren't needed
🙋‍♂️ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Summary by CodeRabbit

Enhancements
- The JetBrains, AWS, and GitHub logos are now clickable links to their respective websites.
- The JetBrains logo displays with a fixed width and grayscale styling for a refined appearance.
- The partners section layout supports a wider display for improved logo presentation.

coderabbitai · 2025-05-07T19:05:00Z

📝 Walkthrough

"""

Walkthrough

The JetBrains, AWS, and GitHub logos were updated to be wrapped in external links using LinkCustom. The JetBrains logo image received grayscale and contrast styling and an explicit width. The partners container max-width in the partnered widget styles was increased from 500px to 600px. The resolveIcon function in link-custom.tsx had its case order adjusted for icon resolution priority.

Changes

File(s)	Change Summary
src/shared/icons/jetbrains.tsx	Added grayscale and contrast styles and explicit width to JetBrains logo image.
src/shared/icons/aws.tsx, src/shared/icons/github.tsx	Reformatted JSX; no functional changes to AWS and GitHub logo components.
src/widgets/partnered/partnered.tsx	Wrapped JetBrains, AWS, and GitHub logos in `LinkCustom` components linking to their official sites with `icon={null}`.
src/widgets/partnered/partnered.scss	Increased max-width of `.partners` container from 500px to 600px.
src/shared/ui/link-custom/link-custom.tsx	Reordered cases in `resolveIcon` function to prioritize explicit `icon` prop over external text link icon.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Update JetBrains logo in Partners widget (#873)	✅

Possibly related PRs

remove epam logo #775: Wraps partner logos in links similar to this PR but focuses on removing the Epam logo.

Suggested reviewers

andron13
dzmitry-varabei
SpaNb4
Quiddlee
"""

Tip

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 667f258 and 90915f3.

📒 Files selected for processing (1)

src/shared/icons/github.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/shared/icons/github.tsx

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-05-07T19:49:51Z

Lighthouse Report:

Performance: 71 / 100
Accessibility: 96 / 100
Best Practices: 100 / 100
SEO: 100 / 100

View detailed report

src/shared/icons/jetbrains.tsx

github-actions · 2025-05-08T08:34:30Z

Lighthouse Report:

Performance: 80 / 100
Accessibility: 96 / 100
Best Practices: 100 / 100
SEO: 100 / 100

View detailed report

github-actions · 2025-05-08T09:02:26Z

Lighthouse Report:

Performance: 56.99999999999999 / 100
Accessibility: 96 / 100
Best Practices: 100 / 100
SEO: 100 / 100

View detailed report

src/shared/icons/jetbrains.tsx

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/shared/icons/github.tsx (1)
13-13: Fix unnecessary space in alt text

There's an extra space at the beginning of the alt text.
-      <Image src={github} alt=" github icon" />
+      <Image src={github} alt="GitHub icon" />

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9a926b and 39b478d.

⛔ Files ignored due to path filters (1)

src/shared/assets/svg/jetbrains.svg is excluded by !**/*.svg

📒 Files selected for processing (4)

src/shared/icons/aws.tsx (1 hunks)
src/shared/icons/github.tsx (1 hunks)
src/shared/icons/jetbrains.tsx (1 hunks)
src/shared/ui/link-custom/link-custom.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/shared/icons/jetbrains.tsx

🧰 Additional context used

🧬 Code Graph Analysis (2)

src/shared/ui/link-custom/link-custom.tsx (1)

src/shared/icons/text-link-icon.tsx (1)

TextLinkIcon (5-15)

src/shared/icons/github.tsx (1)

src/shared/ui/link-custom/link-custom.tsx (1)

LinkCustom (45-92)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Build rs.school
GitHub Check: CI

🔇 Additional comments (3)

src/shared/icons/aws.tsx (1)

4-15: Improved AWS logo by making it clickable

The AWS logo now links to the AWS website, matching the behavior of other partner logos. Setting icon={null} prevents the external link icon from appearing.

src/shared/ui/link-custom/link-custom.tsx (1)

60-61: Improved icon resolution priority

This change ensures that explicitly provided icons (including null) take precedence over the automatic external link icon. This is essential for the logos that need external linking without additional icons.

src/shared/icons/github.tsx (1)

4-15: Enhanced GitHub logo with link functionality

The GitHub logo now links to the GitHub website, providing consistent behavior with other partner logos. Setting icon={null} properly prevents the external link icon from being displayed.

github-actions · 2025-05-10T10:28:45Z

Lighthouse Report:

Performance: 69 / 100
Accessibility: 96 / 100
Best Practices: 100 / 100
SEO: 100 / 100

View detailed report

src/shared/ui/link-custom/link-custom.tsx

src/shared/icons/aws.tsx

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/widgets/partnered/partnered.tsx (1)
13-37: Consider adding explicit aria-labels for improved accessibility

While the image components have alt text, adding explicit aria-labels to the LinkCustom components would further enhance accessibility.
 <LinkCustom
   href="https://www.jetbrains.com"
   external
   icon={null}
+  aria-label="Visit JetBrains website"
 >

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39b478d and 667f258.

📒 Files selected for processing (4)

src/shared/icons/aws.tsx (1 hunks)
src/shared/icons/github.tsx (1 hunks)
src/shared/icons/jetbrains.tsx (1 hunks)
src/widgets/partnered/partnered.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

src/shared/icons/github.tsx
src/shared/icons/aws.tsx
src/shared/icons/jetbrains.tsx

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/widgets/partnered/partnered.tsx (4)

src/shared/ui/link-custom/link-custom.tsx (1)

LinkCustom (45-92)

src/shared/icons/jetbrains.tsx (1)

JetBrainsLogo (5-14)

src/shared/icons/aws.tsx (1)

AwsLogo (5-9)

src/shared/icons/github.tsx (1)

GithubLogo (5-9)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Build rs.school
GitHub Check: CI

🔇 Additional comments (4)

src/widgets/partnered/partnered.tsx (4)

2-2: Added import for LinkCustom component

The import is correctly added to support the new functionality of making partner logos clickable.

13-19: JetBrains logo now wrapped in clickable link

The JetBrains logo is now properly wrapped in a LinkCustom component, making it a clickable external link to the official JetBrains website. Setting icon={null} appropriately removes the default external link icon.

22-28: AWS logo now wrapped in clickable link

The AWS logo has been wrapped in a LinkCustom component, consistent with the approach used for the JetBrains logo.

31-37: GitHub logo now wrapped in clickable link

The GitHub logo has been wrapped in a LinkCustom component, maintaining consistency with the other partner logos.

github-actions · 2025-05-10T12:22:22Z

Lighthouse Report:

Performance: 97 / 100
Accessibility: 96 / 100
Best Practices: 100 / 100
SEO: 100 / 100

View detailed report

src/shared/icons/github.tsx

src/widgets/partnered/partnered.scss

Co-authored-by: Yuliya Kursevich <[email protected]>

chmdln added 3 commits May 7, 2025 22:26

feat: 873 - update jetBrains logo in partners widget

db8266d

feat: 873 - add link to jetBrains website

a98a7d0

feat: 873 - fix typo

c417482

chmdln self-assigned this May 7, 2025

chmdln requested review from andron13, dzmitry-varabei, SpaNb4, Quiddlee, ansivgit and natanchik as code owners May 7, 2025 19:03

github-actions bot changed the title ~~Feat/873 update jetbrans logo~~ 873-feat: Update jetbrans logo May 7, 2025

github-actions bot added the preview label May 7, 2025

feat: 873 - apply grayscale and lower contrast to JetBrains logo

a9a926b

apalchys requested a deployment to pr878 May 7, 2025 19:41 In progress

apalchys temporarily deployed to pr878 May 7, 2025 19:48 Inactive

SpaNb4 reviewed May 8, 2025

View reviewed changes

src/shared/icons/jetbrains.tsx Outdated Show resolved Hide resolved

feat: 873 - update logo type to mono black

42066ee

apalchys requested a deployment to pr878 May 8, 2025 08:32 In progress

apalchys temporarily deployed to pr878 May 8, 2025 08:33 Inactive

feat: 873 - merge main into current branch

238e3d4

apalchys requested a deployment to pr878 May 8, 2025 09:00 In progress

apalchys temporarily deployed to pr878 May 8, 2025 09:01 Inactive

YulikK reviewed May 8, 2025

View reviewed changes

src/shared/icons/jetbrains.tsx Outdated Show resolved Hide resolved

chmdln added 3 commits May 10, 2025 14:58

refactor: 873 - use link-custom component

9d501c1

feat: 873 - add link to aws website

76a1c97

feat: 873 - add link to github website

39b478d

apalchys requested a deployment to pr878 May 10, 2025 10:27 In progress

coderabbitai bot reviewed May 10, 2025

View reviewed changes

apalchys temporarily deployed to pr878 May 10, 2025 10:27 Inactive

SpaNb4 reviewed May 10, 2025

View reviewed changes

src/shared/ui/link-custom/link-custom.tsx Show resolved Hide resolved

src/shared/icons/aws.tsx Outdated Show resolved Hide resolved

refactor: 873 - wrap the logos in links inside the Partnered component

667f258

apalchys requested a deployment to pr878 May 10, 2025 12:20 In progress

coderabbitai bot reviewed May 10, 2025

View reviewed changes

apalchys deployed to pr878 May 10, 2025 12:21 View deployment

SpaNb4 approved these changes May 10, 2025

View reviewed changes

YulikK reviewed May 11, 2025

View reviewed changes

src/shared/icons/github.tsx Outdated Show resolved Hide resolved

src/widgets/partnered/partnered.scss Show resolved Hide resolved

Update src/shared/icons/github.tsx

90915f3

Co-authored-by: Yuliya Kursevich <[email protected]>

YulikK approved these changes May 14, 2025

View reviewed changes

Uh oh!

873-feat: Update jetbrans logo #878

Are you sure you want to change the base?

873-feat: Update jetbrans logo #878

Uh oh!

Conversation

chmdln commented May 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this? (select all that apply)

Description

Related Tickets & Documents

Screenshots, Recordings

Added/updated tests?

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions bot commented May 7, 2025

Uh oh!

Uh oh!

github-actions bot commented May 8, 2025

Uh oh!

github-actions bot commented May 8, 2025

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 10, 2025

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chmdln commented May 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 7, 2025 •

edited

Loading