fix issues, close channels

Author: pthmas

pkg/rpc/core/blocks.go

@@ -277,9 +277,6 @@ func BlockchainInfo(ctx *rpctypes.Context, minHeight, maxHeight int64) (*ctypes.
 
 	blocks := make([]*cmttypes.BlockMeta, 0, maxHeight-minHeight+1)
 	for _, block := range BlockIterator(maxHeight, minHeight) {
-		if err != nil {
-			return nil, err
-		}
 		if block.header != nil && block.data != nil {
 			cmblockmeta, err := common.ToABCIBlockMeta(block.header, block.data)
 			if err != nil {

pkg/rpc/core/utils.go

@@ -170,6 +170,8 @@ func BlockIterator(start int64, end int64) []BlockResponse {
 	if err != nil {
 		return blocks
 	}
+	defer rHeader.Close() //nolint:errcheck
+	defer rData.Close()   //nolint:errcheck
 
 	//we need to match the data to the header using the height, for that we use a map
 	headerMap := make(map[uint64]*rlktypes.SignedHeader)