Merge pull request #4 from romangolev/dev

fix: convert double value when filling data back in double
fix 'Section for Wall' button and show remote version in info

Author: romangolev

lib/core/__init__.py

@@ -1,18 +1,14 @@
 # extension library file
 
-import os
-import sys
 import os.path as op
 import urllib2
-import selectionhelpers
 
 from pyrevit import EXEC_PARAMS
 from pyrevit import script
-from pyrevit import forms
 from pyrevit.loader import sessionmgr
 from pyrevit.loader import sessioninfo
 
-class Core :
+class Core(object):
    """
    Extension Coreclass
    """
@@ -22,8 +18,6 @@ def return_ext_dir():
       return A_EXT_DIR
 
 
-
-
 def get_local_version():
     with open(op.join(op.dirname(__file__), 'version'), 'r') as version_file:
        version = version_file.read()

lib/core/unitsconverter.py

@@ -10,7 +10,7 @@
 class UnitConverter:
 
      @staticmethod
-     def convertDouble(uiapp, doubleValue,units):
+     def convertDouble(uiapp, doubleValue, units):
 
           versionNumber = uiapp.Application.VersionNumber
           value_converted = ''

lib/core/version

@@ -1 +1 @@
-1.1.2
+1.1.3

pyArchitect.tab/Main.panel/Info.pushbutton/info-script.py

@@ -12,16 +12,23 @@
 
 __context__ = 'zero-doc'
 
+try:
+    remote_version = core.get_git_version()
+except:
+    remote_version = 'Not available'
+
 # Handle Language versions
 if HOST_APP.language == LanguageType.Russian:
     user = "Имя пользователя"
     Rvers = "Версия Ревит"
-    Bvers = "Версия расширения"
+    Bvers = "Версия установленного расширения"
+    Bvers_remote = "Последняя доступная версия"
     lang = "RU"
 else:
     user = "Username"
     Rvers = "Revit Version"
     Bvers = "Extension version"
+    Bvers_remote = "Latest available version"
     lang = "EN"
 dir_path = op.dirname(op.realpath(__file__))
 style = 'img {max-width: 589px; padding: 25px 0} span {display: block; text-align: center;}'
@@ -36,6 +43,7 @@
 print(str(Rvers) + ' : {}'.format(HOST_APP.version_name + HOST_APP.build))
 print(str(Rvers) + ' : {}'.format(HOST_APP.subversion))
 print(str(Bvers) + ' : {}'.format(core.get_local_version()))
+print(str(Bvers_remote) + ' : {}'.format(remote_version))
 
-out.print_html('<a href="https://github.com/romangolev/pyArchitect">pyArchitect repository</a>')
-out.print_html('<a href="https://www.romangolev.com">Roman Golev</a>')
+out.print_html('<a href="https://github.com/romangolev/pyArchitect">pyArchitect GitHub repository</a>')
+out.print_html('<a href="https://www.romangolev.com">Roman Golev</a><a> </a><a href="https://www.linkedin.com/in/romangolev/">LinkedIn</a><a>, 2024</a>')

pyArchitect.tab/Tools.panel/CopyParameterValues.pushbutton/script.py

@@ -213,15 +213,16 @@ def runLogic(self):
                     return "Error"
           elif storageTypeFrom == StorageType.Double:
                if self.param_to.StorageType == StorageType.Integer:
-                    try:                    
+                    try:
                          value_converted = UnitConverter.convertDouble(uiapp, value, units)
                          self.setValueTo(round(value_converted))
                          return "Success"
                     except:
                          return "Skipped"                       
                elif self.param_to.StorageType == StorageType.Double:
                     try:
-                         self.setValueTo(value)
+                         value_converted = UnitConverter.convertDouble(uiapp, value, units)
+                         self.setValueTo(round(value_converted))
                          return "Success"
                     except:
                          return "Skipped"                       

pyArchitect.tab/Tools.panel/tools1.stack/CreateSectionBasedOnWall.pushbutton/script.py

@@ -2,30 +2,20 @@
 # pylint: skip-file
 # by Roman Golev 
 
-
-
-#Load Revit API
-import clr
-clr.AddReference("RevitAPI")
-import Autodesk
-from Autodesk.Revit.DB import *
-from Autodesk.Revit.UI import *
-
 import sys
+import Autodesk.Revit.DB as DB
+from Autodesk.Revit.DB import BuiltInParameter, XYZ, Transform, BoundingBoxXYZ, \
+                                ViewSection, ViewFamilyType, FilteredElementCollector, \
+                                ViewFamily
 
-import pyrevit
 from pyrevit import forms
 from core.selectionhelpers import CustomISelectionFilterByIdInclude, ID_WALLS
 from Autodesk.Revit.UI.Selection import ObjectType
 
-doc = __revit__.ActiveUIDocument.Document
-uidoc = __revit__.ActiveUIDocument
-uiapp = __revit__
-app = uiapp.Application
-t = Autodesk.Revit.DB.Transaction(doc)
-tg = Autodesk.Revit.DB.TransactionGroup(doc)
-
-
+doc = __revit__.ActiveUIDocument.Document # type: ignore
+uidoc = __revit__.ActiveUIDocument # type: ignore
+transaction = DB.Transaction(doc)
+transaction_group = DB.TransactionGroup(doc)
 
 # Get unput: selected by user elements
 def get_selection():
@@ -40,8 +30,8 @@ def get_selection():
      return selection
 
 
-def create_section_by_wall(el, doc, viewFamilyTypeId, t, flip):
-    offset = units(100)
+def create_section_by_wall(el, doc, viewFamilyTypeId, transaction, flip):
+    offset = 100/304.8 # 100mm offset as Double
     wall = doc.GetElement(el)
     # Determine section box
     lc = wall.Location
@@ -61,11 +51,8 @@ def create_section_by_wall(el, doc, viewFamilyTypeId, t, flip):
     w = v.GetLength()
     h = maxZ - minZ
     d = wall.WallType.Width
-    # wallBaseOffset = units(float(wall.get_Parameter(BuiltInParameter.WALL_BASE_OFFSET).AsString()))
-    # wallUnconnectedHeight = units(float(wall.get_Parameter(BuiltInParameter.WALL_USER_HEIGHT_PARAM).AsString()))
-    wallBaseOffset = builtInParam(wall, BuiltInParameter.WALL_BASE_OFFSET)
-    wallUnconnectedHeight = builtInParam(wall, BuiltInParameter.WALL_USER_HEIGHT_PARAM)
-
+    wallBaseOffset = wall.get_Parameter(BuiltInParameter.WALL_BASE_OFFSET).AsDouble()
+    wallUnconnectedHeight = wall.get_Parameter(BuiltInParameter.WALL_USER_HEIGHT_PARAM).AsDouble()
 
     # XYZ(min/max section line length, min/max height of the section box, min/max far clip)
     min = XYZ(-0.5*w - offset, wallBaseOffset - offset, - offset - 0.5*d)
@@ -95,35 +82,25 @@ def create_section_by_wall(el, doc, viewFamilyTypeId, t, flip):
     sectionBox.Min = min # scope box bottom
     sectionBox.Max = max # scope box top
 
-    t.Start('Create Section')
     # Create wall section view
-    newSection = ViewSection.CreateSection(doc, viewFamilyTypeId, sectionBox)
-    t.Commit()
-    return newSection
-
-
-def units(mmToFeets):
+    transaction.Start('Create Section')
     try:
-        # R19, R20, R21
-        dut = DisplayUnitType.DUT_MILLIMETERS
-        return UnitUtils.ConvertToInternalUnits(mmToFeets, dut)
-    except:
-        # R22, R22, R23 and later
-        return mmToFeets/304.8
-
+        newSection = ViewSection.CreateSection(doc, viewFamilyTypeId, sectionBox)
+        transaction.Commit()
+        return newSection
+    except Exception as e:
+        transaction.RollBack()
+        transaction.Dispose()
+        print(e)
 
 
-def builtInParam(wall, wallParam):
-    return units(float(wall.get_Parameter(wallParam).AsValueString()))
-
 def main():
     # Get selection
-    # sel = uidoc.Selection.GetElementIds()
     sel = get_selection()
 
     # Check selected elements
     if not sel:
-        forms.alert("Please, select wall","Section For Wall")
+        forms.alert("Please, select wall", "Section For Wall")
         sys.exit()
     for element in sel:
         if doc.GetElement(element).Category.Id.ToString() != "-2000011":
@@ -157,13 +134,12 @@ def main():
 
     #Make section(s)
     if len(sel) == 1:
-        create_section_by_wall(sel[0], doc, viewFamilyTypeId, t, sw["Flip section"])
+        create_section_by_wall(sel[0], doc, viewFamilyTypeId, transaction, sw["Flip section"])
     elif len(sel) > 1:
-        tg.Start("Create multiple sections")
+        transaction_group.Start("Create multiple sections")
         for el in sel:
-            create_section_by_wall(el, doc, viewFamilyTypeId, t, sw["Flip section"])
-        tg.Assimilate()
-
+            create_section_by_wall(el, doc, viewFamilyTypeId, transaction, sw["Flip section"])
+        transaction_group.Assimilate()
 
 if __name__ == '__main__':
     main()