fix: respect configured IGDB region priority

Generated-By: PostHog Code
Task-Id: 6764d95b-659d-4e11-a5c5-28e65431d944

Author: gantoine

backend/handler/metadata/igdb_handler.py

@@ -353,22 +353,32 @@ def derive_player_count(
 
 
 def get_igdb_preferred_locale(rom: Rom | None = None) -> str | None:
-    """Get IGDB locale, preferring the rom's own region tag when available.
+    """Get IGDB locale from the ROM's prioritized regions when available.
 
     Maps region priority codes to IGDB's game_localizations region identifiers.
-    Checks the rom's tagged regions first, then falls back to scan.priority.region.
+    Prioritizes the ROM's tagged regions by scan.priority.region, then falls
+    back to scan.priority.region.
 
     Returns:
         IGDB region identifier (e.g., "ja-JP", "EU") or None for default
     """
+    config = cm.get_config()
+    priority = config.SCAN_REGION_PRIORITY
+
     if rom is not None and isinstance(rom.regions, list):
+        rom_codes: list[str] = []
         for region_name in rom.regions:
             code = region_name_to_provider_shortcode(region_name)
             if code and code in REGION_TO_IGDB_LOCALE:
-                return REGION_TO_IGDB_LOCALE[code]
+                rom_codes.append(code)
 
-    config = cm.get_config()
-    for region in config.SCAN_REGION_PRIORITY:
+        rom_codes.sort(
+            key=lambda code: priority.index(code) if code in priority else len(priority)
+        )
+        if rom_codes:
+            return REGION_TO_IGDB_LOCALE[rom_codes[0]]
+
+    for region in priority:
         if region.lower() in REGION_TO_IGDB_LOCALE:
             return REGION_TO_IGDB_LOCALE[region.lower()]
 

backend/tests/handler/metadata/test_igdb_handler.py

@@ -1,6 +1,6 @@
 """Tests for the IGDB metadata handler."""
 
-from unittest.mock import AsyncMock, patch
+from unittest.mock import AsyncMock, MagicMock, patch
 
 import pytest
 
@@ -13,6 +13,7 @@
     IGDBHandler,
     _build_platforms_where,
     _platform_igdb_ids_with_twin,
+    get_igdb_preferred_locale,
 )
 
 GENESIS_IGDB_ID = 29
@@ -62,6 +63,19 @@ def _make_game(
     }
 
 
+class TestGetIGDBPreferredLocale:
+    def test_multi_region_rom_respects_user_priority(self):
+        """The configured priority wins over filename tag order."""
+        rom = MagicMock()
+        rom.regions = ["Japan", "USA"]
+        config = MagicMock(SCAN_REGION_PRIORITY=["us", "jp"])
+
+        with patch("handler.metadata.igdb_handler.cm.get_config", return_value=config):
+            locale = get_igdb_preferred_locale(rom)
+
+        assert locale is None
+
+
 class TestSearchRomGameTypeFilter:
     """Tests for _search_rom game_type filtering."""