refactor(v2): move provider ratings from header to metadata tab

wadiebs · wadiebs · commit 3fe29407e75f · 2026-08-05T13:58:52.000+02:00
- Remove ratings display from GameHeader component
- Move rating logic (formatRating, normalizeToTen, RatingChip type) to MetadataTab
- Add new 'Ratings' section in metadata tab (between Verification and Provider links)
- Display ratings with provider logos (16×16px) and formatted values
- Add 'ratings-label' translation key to all 18 locale files
- Improve organization: ratings now grouped with provider metadata instead of header
diff --git a/frontend/src/locales/bg_BG/rom.json b/frontend/src/locales/bg_BG/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Публични бележки",
   "qr-scan-to-download": "Сканирай, за да свалиш",
   "rating": "Оценка",
+  "ratings-label": "Оценки",
   "redownload": "Свали отново",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Презапиши метаданните от всички избрани източници",
diff --git a/frontend/src/locales/cs_CZ/rom.json b/frontend/src/locales/cs_CZ/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Veřejné poznámky",
   "qr-scan-to-download": "Naskenujte pro stažení",
   "rating": "Hodnocení",
+  "ratings-label": "Hodnocení",
   "redownload": "Znovu stáhnout",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Přepsat metadata ze všech vybraných poskytovatelů",
diff --git a/frontend/src/locales/de_DE/rom.json b/frontend/src/locales/de_DE/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Öffentliche Notizen",
   "qr-scan-to-download": "Scannen zum Herunterladen",
   "rating": "Bewertung",
+  "ratings-label": "Bewertungen",
   "redownload": "Erneut herunterladen",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Metadaten aller ausgewählten Anbieter überschreiben",
diff --git a/frontend/src/locales/en_GB/rom.json b/frontend/src/locales/en_GB/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Public notes",
   "qr-scan-to-download": "Scan to download",
   "rating": "Rating",
+  "ratings-label": "Ratings",
   "redownload": "Re-download",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Overwrite metadata from all selected providers",
diff --git a/frontend/src/locales/en_US/rom.json b/frontend/src/locales/en_US/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Public notes",
   "qr-scan-to-download": "Scan to download",
   "rating": "Rating",
+  "ratings-label": "Ratings",
   "redownload": "Re-download",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Overwrite metadata from all selected providers",
diff --git a/frontend/src/locales/es_ES/rom.json b/frontend/src/locales/es_ES/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Notas públicas",
   "qr-scan-to-download": "Escanear para descargar",
   "rating": "Valoración",
+  "ratings-label": "Valoraciones",
   "redownload": "Volver a descargar",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Sobrescribir metadatos de todos los proveedores seleccionados",
diff --git a/frontend/src/locales/fr_FR/rom.json b/frontend/src/locales/fr_FR/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Notes publiques",
   "qr-scan-to-download": "Scanner pour télécharger",
   "rating": "Note",
+  "ratings-label": "Notes",
   "redownload": "Retélécharger",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Écraser les métadonnées de tous les fournisseurs sélectionnés",
diff --git a/frontend/src/locales/hu_HU/rom.json b/frontend/src/locales/hu_HU/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Publikus jegyzetek",
   "qr-scan-to-download": "Olvasd be a letöltéshez",
   "rating": "Értékelés",
+  "ratings-label": "Értékelések",
   "redownload": "Újraletöltés",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Az összes kiválasztott szolgáltató metaadatainak felülírása",
diff --git a/frontend/src/locales/it_IT/rom.json b/frontend/src/locales/it_IT/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Note pubbliche",
   "qr-scan-to-download": "Scansiona per scaricare",
   "rating": "Valutazione",
+  "ratings-label": "Valutazioni",
   "redownload": "Riscarica",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Sovrascrivi i metadati da tutti i provider selezionati",
diff --git a/frontend/src/locales/ja_JP/rom.json b/frontend/src/locales/ja_JP/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "公開メモ",
   "qr-scan-to-download": "スキャンしてダウンロード",
   "rating": "レーティング",
+  "ratings-label": "レーティング",
   "redownload": "再ダウンロード",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "選択したすべてのプロバイダからメタデータを上書きします",
diff --git a/frontend/src/locales/ko_KR/rom.json b/frontend/src/locales/ko_KR/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "공개 노트",
   "qr-scan-to-download": "스캔하여 다운로드",
   "rating": "평가",
+  "ratings-label": "평가",
   "redownload": "다시 다운로드",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "선택한 모든 제공자의 메타데이터로 덮어씁니다",
diff --git a/frontend/src/locales/pl_PL/rom.json b/frontend/src/locales/pl_PL/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Notatki publiczne",
   "qr-scan-to-download": "Zeskanuj, aby pobrać",
   "rating": "Ocena",
+  "ratings-label": "Oceny",
   "redownload": "Pobierz ponownie",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Nadpisz metadane od wszystkich wybranych dostawców",
diff --git a/frontend/src/locales/pt_BR/rom.json b/frontend/src/locales/pt_BR/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Notas públicas",
   "qr-scan-to-download": "Escaneie para baixar",
   "rating": "Avaliação",
+  "ratings-label": "Avaliações",
   "redownload": "Baixar novamente",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Sobrescrever metadados de todos os provedores selecionados",
diff --git a/frontend/src/locales/ro_RO/rom.json b/frontend/src/locales/ro_RO/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Notițe publice",
   "qr-scan-to-download": "Scanează pentru a descărca",
   "rating": "Evaluare",
+  "ratings-label": "Evaluări",
   "redownload": "Redescarcă",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Suprascrie metadatele de la toți furnizorii selectați",
diff --git a/frontend/src/locales/ru_RU/rom.json b/frontend/src/locales/ru_RU/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Публичные заметки",
   "qr-scan-to-download": "Отсканируйте для скачивания",
   "rating": "Рейтинг",
+  "ratings-label": "Оценки",
   "redownload": "Перезагрузить",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "Перезаписать метаданные от всех выбранных провайдеров",
diff --git a/frontend/src/locales/tr_TR/rom.json b/frontend/src/locales/tr_TR/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "Herkese açık notlar",
   "qr-scan-to-download": "İndirmek için tarat",
   "rating": "Puan",
+  "ratings-label": "Puanlar",
   "redownload": "Yeniden indir",
   "redownload-manual": "Taranmış kılavuzu yeniden indir",
   "refresh-complete-desc": "Seçili tüm sağlayıcılardan meta veriyi üzerine yaz",
diff --git a/frontend/src/locales/zh_CN/rom.json b/frontend/src/locales/zh_CN/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "公共笔记",
   "qr-scan-to-download": "扫码下载",
   "rating": "评分",
+  "ratings-label": "评分",
   "redownload": "重新下载",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "从所有选定来源覆盖元数据",
diff --git a/frontend/src/locales/zh_TW/rom.json b/frontend/src/locales/zh_TW/rom.json
@@ -295,6 +295,7 @@
   "public-notes": "公共筆記",
   "qr-scan-to-download": "掃描以下載",
   "rating": "評分",
+  "ratings-label": "評分",
   "redownload": "重新下載",
   "redownload-manual": "Re-download scraped manual",
   "refresh-complete-desc": "覆寫所有所選提供商的元數據",
diff --git a/frontend/src/v2/components/GameDetails/GameHeader.vue b/frontend/src/v2/components/GameDetails/GameHeader.vue
@@ -9,13 +9,11 @@
 // Metadata-provider links live in the Metadata tab, not the header.
 // Genre/franchise belong in the Overview tab info grid.
 import { RIcon, RPlatformIcon, RTag, RTooltip } from "@v2/lib";
-import { computed } from "vue";
 import { useI18n } from "vue-i18n";
 import type { DetailedRom } from "@/stores/roms";
 import GameActions from "@/v2/components/GameActions/GameActions.vue";
 import MainSiblingToggle from "@/v2/components/GameDetails/MainSiblingToggle.vue";
 import PrevNextNav from "@/v2/components/GameDetails/PrevNextNav.vue";
-import { PROVIDERS } from "@/v2/components/GameDetails/providers";
 import VersionSwitcher from "@/v2/components/GameDetails/VersionSwitcher.vue";
 import { useGameActions } from "@/v2/composables/useGameActions";
 
@@ -35,84 +33,6 @@ const props = defineProps<{
 }>();
 
 const actions = useGameActions(() => props.rom);
-
-type RatingChip = {
-  key: "igdb_id" | "ss_id" | "moby_id" | "launchbox_id" | "hltb_id";
-  name: string;
-  logo: string;
-  value: string;
-};
-
-function formatRating(value: number, options?: { percent?: boolean }): string | null {
-  if (!Number.isFinite(value)) return null;
-  const rounded = value >= 10 ? value.toFixed(0) : value.toFixed(1);
-  const formatted = rounded.replace(/\.0$/, "");
-  return options?.percent ? `${formatted}%` : formatted;
-}
-
-function normalizeToTen(value: number): number {
-  if (!Number.isFinite(value)) return Number.NaN;
-  return value > 10 ? value / 10 : value;
-}
-
-function providerByKey(key: RatingChip["key"]) {
-  return PROVIDERS.find((p) => p.key === key) ?? null;
-}
-
-const ratingChips = computed<RatingChip[]>(() => {
-  const rom = props.rom;
-
-  const values: Array<{ key: RatingChip["key"]; value: string | null }> = [
-    {
-      key: "igdb_id",
-      value: formatRating(
-        normalizeToTen(parseFloat(rom.igdb_metadata?.total_rating ?? "")),
-      ),
-    },
-    {
-      key: "ss_id",
-      value: formatRating(parseFloat(rom.ss_metadata?.ss_score ?? "") * 10, {
-        percent: true,
-      }),
-    },
-    {
-      key: "moby_id",
-      value: formatRating(parseFloat(rom.moby_metadata?.moby_score ?? "") * 10, {
-        percent: true,
-      }),
-    },
-    {
-      key: "launchbox_id",
-      value: formatRating(
-        (rom.launchbox_metadata?.community_rating ?? Number.NaN) * 20,
-        { percent: true },
-      ),
-    },
-    {
-      key: "hltb_id",
-      value: formatRating(rom.hltb_metadata?.review_score ?? Number.NaN, {
-        percent: true,
-      }),
-    },
-  ];
-
-  const out: RatingChip[] = [];
-
-  for (const entry of values) {
-    if (!entry.value) continue;
-    const provider = providerByKey(entry.key);
-    if (!provider || !provider.logo) continue;
-
-    out.push({
-      key: entry.key,
-      name: provider.name,
-      logo: provider.logo,
-      value: entry.value,
-    });
-  }
-
-  return out;
-});
 </script>
 
 <template>
@@ -189,21 +109,6 @@ const ratingChips = computed<RatingChip[]>(() => {
         <RTag v-for="t in tags" :key="`t-${t}`" :text="t" size="small" />
       </span>
 
-      <span v-if="ratingChips.length" class="r-v2-det-header__ratings">
-        <span
-          v-for="chip in ratingChips"
-          :key="chip.key"
-          class="r-v2-det-header__rating-inline"
-          :aria-label="`${chip.name} rating ${chip.value}`"
-        >
-          <img
-            class="r-v2-det-header__rating-logo"
-            :src="chip.logo"
-            :alt="`${chip.name} logo`"
-          />
-          <span class="r-v2-det-header__rating-value">{{ chip.value }}</span>
-        </span>
-      </span>
     </div>
 
     <div v-if="rom.sibling_roms.length > 0" class="r-v2-det-header__versions">
@@ -279,35 +184,6 @@ const ratingChips = computed<RatingChip[]>(() => {
   gap: 6px;
 }
 
-.r-v2-det-header__ratings {
-  display: inline-flex;
-  align-items: center;
-  flex-wrap: wrap;
-  gap: 6px;
-  flex-basis: 100%;
-}
-
-.r-v2-det-header__rating-inline {
-  display: inline-flex;
-  align-items: center;
-  gap: 4px;
-  color: inherit;
-}
-
-.r-v2-det-header__rating-logo {
-  inline-size: 20px;
-  block-size: 20px;
-  object-fit: contain;
-  flex-shrink: 0;
-}
-
-.r-v2-det-header__rating-value {
-  font-variant-numeric: tabular-nums;
-  color: inherit;
-  font-weight: inherit;
-  font-size: inherit;
-}
-
 .r-v2-det-header__versions {
   display: flex;
   align-items: center;
diff --git a/frontend/src/v2/components/GameDetails/MetadataTab.vue b/frontend/src/v2/components/GameDetails/MetadataTab.vue
