fix(migrations): revert 0014 idempotency guard

The guard was both unreachable and unsafe. For platforms.id to exist on
a rerun, the first attempt must have already run the atomic ADD COLUMN
id ... PRIMARY KEY, which means it passed the unguarded
drop_constraint("fk_platform_roms") at the top of upgrade(). That FK
drop has no IF EXISTS, so any rerun fails there before reaching the
guard. And if it were reachable, the preceding primary-key drop would
leave id unkeyed once the ADD COLUMN was skipped.

Keep the genuinely correct fixes (0084, 0033); leave 0014 as-is.

Generated-By: PostHog Code
Task-Id: 87d70ab6-f915-48c0-afa7-55064c97d1a5

Author: gantoine

backend/alembic/versions/0014_asset_files.py

@@ -168,18 +168,13 @@ def upgrade() -> None:
         batch_op.drop_constraint(constraint_name=pk_constraint_name, type_="primary")
         batch_op.drop_column("n_roms", if_exists=True)
 
-    # Switch to new id column as platform primary key. Raw DDL has no portable
-    # "IF NOT EXISTS", so guard it to stay idempotent on a partial-failure rerun.
-    platform_columns = {
-        column["name"] for column in sa.inspect(connection).get_columns("platforms")
-    }
-    if "id" not in platform_columns:
-        if is_postgresql(connection):
-            op.execute("ALTER TABLE platforms ADD COLUMN id SERIAL PRIMARY KEY")
-        else:
-            op.execute(
-                "ALTER TABLE platforms ADD COLUMN id INTEGER(11) NOT NULL AUTO_INCREMENT PRIMARY KEY"
-            )
+    # Switch to new id column as platform primary key
+    if is_postgresql(connection):
+        op.execute("ALTER TABLE platforms ADD COLUMN id SERIAL PRIMARY KEY")
+    else:
+        op.execute(
+            "ALTER TABLE platforms ADD COLUMN id INTEGER(11) NOT NULL AUTO_INCREMENT PRIMARY KEY"
+        )
 
     # Add new columns to roms table
     with op.batch_alter_table("roms", schema=None) as batch_op: