Skip to content

Commit 7caa3f1

Browse files
committed
fix(ui): remove cover-art attribution link on details pages
The "Cover art provided by X" line linked to rom.url_cover, which for ScreenScraper contains a media download URL with embedded credentials. Render the source name as plain text so credentials are not exposed in the UI, while the URL stays stored in the database unchanged. Fixes #3612 Generated-By: PostHog Code Task-Id: 038e1de3-16ac-4f2b-8ae0-b4dade2f8ef9
1 parent 167f08f commit 7caa3f1

2 files changed

Lines changed: 4 additions & 22 deletions

File tree

frontend/src/components/Details/Info/GameInfo.vue

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -364,16 +364,8 @@ function getFilterValues(path: string): string[] {
364364
</span> </template
365365
>.
366366
</div>
367-
<div v-if="rom.url_cover && coverImageSource" class="mt-1">
368-
Cover art provided by
369-
<a
370-
:href="rom.url_cover"
371-
target="_blank"
372-
rel="noopener noreferrer"
373-
style="color: inherit"
374-
>
375-
{{ coverImageSource }}</a
376-
>.
367+
<div v-if="coverImageSource" class="mt-1">
368+
Cover art provided by {{ coverImageSource }}.
377369
</div>
378370
</v-col>
379371
</v-row>

frontend/src/v2/components/GameDetails/OverviewTab.vue

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -338,19 +338,9 @@ const coverSource = computed(() => {
338338
>
339339
</template>
340340
</i18n-t>
341-
<i18n-t
342-
v-if="coverSource && rom.url_cover"
343-
keypath="rom.cover-art-provided-by"
344-
tag="div"
345-
>
341+
<i18n-t v-if="coverSource" keypath="rom.cover-art-provided-by" tag="div">
346342
<template #source>
347-
<a
348-
class="overview-tab__attribution-link"
349-
:href="rom.url_cover"
350-
target="_blank"
351-
rel="noopener"
352-
>{{ coverSource }}</a
353-
>
343+
<span>{{ coverSource }}</span>
354344
</template>
355345
</i18n-t>
356346
</div>

0 commit comments

Comments
 (0)