Merge pull request #3549 from rommapp/feat/screenshot-CRUD-endpoints

feat: User screenshots support + dropzone refactor

Author: zurdi15

backend/alembic/versions/0085_rom_category_screenshot.py

@@ -0,0 +1,81 @@
+"""Update rom_file.category column enum to include screenshots.
+
+Revision ID: 0085_rom_category_screenshot
+Revises: 0084_add_roms_search_index
+Create Date: 2026-06-17 00:00:00.000000
+
+"""
+
+import sqlalchemy as sa
+from alembic import op
+
+from utils.database import is_postgresql
+
+# revision identifiers, used by Alembic.
+revision = "0085_rom_category_screenshot"
+down_revision = "0084_add_roms_search_index"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    connection = op.get_bind()
+
+    if is_postgresql(connection):
+        # `ALTER TYPE ... ADD VALUE` must run outside a transaction in PostgreSQL.
+        # autocommit_block breaks out of alembic's wrapping transaction for
+        # exactly this operation.
+        with op.get_context().autocommit_block():
+            op.execute(
+                "ALTER TYPE romfilecategory ADD VALUE IF NOT EXISTS 'SCREENSHOT'"
+            )
+    else:
+        rom_file_category_enum = sa.Enum(
+            "GAME",
+            "DLC",
+            "HACK",
+            "MANUAL",
+            "PATCH",
+            "UPDATE",
+            "MOD",
+            "DEMO",
+            "TRANSLATION",
+            "PROTOTYPE",
+            "CHEAT",
+            "SOUNDTRACK",
+            "SCREENSHOT",
+            name="romfilecategory",
+        )
+        with op.batch_alter_table("rom_files", schema=None) as batch_op:
+            batch_op.alter_column(
+                "category", type_=rom_file_category_enum, nullable=True
+            )
+
+
+def downgrade() -> None:
+    # PostgreSQL cannot remove enum values, so the downgrade is a no-op there.
+    # On other backends, narrow the enum back to its pre-screenshot set. Any
+    # rows still holding the new value would block this, but the upload flow
+    # is additive and a re-upgrade is a no-op.
+    connection = op.get_bind()
+
+    if is_postgresql(connection):
+        return
+
+    rom_file_category_enum = sa.Enum(
+        "GAME",
+        "DLC",
+        "HACK",
+        "MANUAL",
+        "PATCH",
+        "UPDATE",
+        "MOD",
+        "DEMO",
+        "TRANSLATION",
+        "PROTOTYPE",
+        "CHEAT",
+        "SOUNDTRACK",
+        name="romfilecategory",
+    )
+    with op.batch_alter_table("rom_files", schema=None) as batch_op:
+        batch_op.alter_column("category", type_=rom_file_category_enum, nullable=True)

backend/alembic/versions/0086_screenshot_visibility.py

@@ -0,0 +1,49 @@
+"""Add is_gallery + is_public flags to screenshots for per-user community
+gallery screenshots (distinct from auto-captured save/state thumbnails).
+
+Revision ID: 0086_screenshot_visibility
+Revises: 0085_rom_category_screenshot
+Create Date: 2026-06-18 00:00:00.000000
+
+"""
+
+import sqlalchemy as sa
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision = "0086_screenshot_visibility"
+down_revision = "0085_rom_category_screenshot"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    op.add_column(
+        "screenshots",
+        sa.Column(
+            "is_gallery",
+            sa.Boolean(),
+            nullable=False,
+            server_default=sa.text("false"),
+        ),
+        if_not_exists=True,
+    )
+    op.add_column(
+        "screenshots",
+        sa.Column(
+            "is_public",
+            sa.Boolean(),
+            nullable=False,
+            server_default=sa.text("false"),
+        ),
+        if_not_exists=True,
+    )
+    op.create_index(
+        "idx_screenshots_public", "screenshots", ["is_public"], if_not_exists=True
+    )
+
+
+def downgrade() -> None:
+    op.drop_index("idx_screenshots_public", table_name="screenshots", if_exists=True)
+    op.drop_column("screenshots", "is_public", if_exists=True)
+    op.drop_column("screenshots", "is_gallery", if_exists=True)

backend/endpoints/responses/assets.py

@@ -30,7 +30,15 @@ class BaseAsset(BaseModel):
 
 
 class ScreenshotSchema(BaseAsset):
-    pass
+    is_gallery: bool = False
+    is_public: bool = False
+
+
+class UserScreenshotSchema(ScreenshotSchema):
+    """A gallery screenshot enriched with its owner's username, for the
+    community (My / Community) view. Mirrors UserNoteSchema."""
+
+    username: str
 
 
 class SaveSchema(BaseAsset):

backend/endpoints/responses/rom.py

@@ -8,7 +8,12 @@
 from fastapi import Request
 from pydantic import ConfigDict, Field, computed_field, field_validator
 
-from endpoints.responses.assets import SaveSchema, ScreenshotSchema, StateSchema
+from endpoints.responses.assets import (
+    SaveSchema,
+    ScreenshotSchema,
+    StateSchema,
+    UserScreenshotSchema,
+)
 from handler.metadata.flashpoint_handler import FlashpointMetadata
 from handler.metadata.gamelist_handler import GamelistMetadata
 from handler.metadata.hasheous_handler import HasheousMetadata
@@ -460,6 +465,7 @@ class DetailedRomSchema(RomSchema):
     user_saves: list[SaveSchema]
     user_states: list[StateSchema]
     user_screenshots: list[ScreenshotSchema]
+    all_user_screenshots: list[UserScreenshotSchema]
     user_collections: list[UserCollectionSchema]
     all_user_notes: list[UserNoteSchema]
 
@@ -524,6 +530,27 @@ def from_orm_with_request(cls, db_rom: Rom, request: Request) -> DetailedRomSche
         all_notes.sort(key=lambda x: x.updated_at, reverse=True)
         db_rom.all_user_notes = all_notes  # type: ignore[assignment]
 
+        # Gallery screenshots visible to this user: own (public + private) plus
+        # other users' public ones. Mirrors the notes flow above. Excludes the
+        # auto-captured save/state thumbnails (is_gallery == False).
+        from handler.database import db_screenshot_handler
+
+        gallery_screenshots = db_screenshot_handler.get_rom_gallery_screenshots(
+            rom_id=db_rom.id, user_id=user_id
+        )
+        db_rom.all_user_screenshots = [  # type: ignore[assignment]
+            UserScreenshotSchema.model_validate(
+                {
+                    **{
+                        field: getattr(s, field)
+                        for field in ScreenshotSchema.model_fields
+                    },
+                    "username": s.user.username,
+                }
+            )
+            for s in gallery_screenshots
+        ]
+
         return cls.model_validate(db_rom)
 
     @field_validator("user_saves")

backend/endpoints/roms/__init__.py

@@ -75,6 +75,7 @@
 from .files import router as files_router
 from .manual import router as manual_router
 from .notes import router as notes_router
+from .screenshot import router as screenshot_router
 from .soundtrack import router as soundtrack_router
 from .upload import router as upload_router
 
@@ -86,6 +87,7 @@
 router.include_router(files_router)
 router.include_router(manual_router)
 router.include_router(soundtrack_router)
+router.include_router(screenshot_router)
 router.include_router(notes_router)