GMS-like Wedding + Scissors of Karma + Maple Life + Buyback

Properly developed the Marriage feature in the source.
Added TRAVEL_RATE server flag, a modifier for the travel frequency rate.
Corrected stance for players in 3rd party view when entering a map to work similarly as GMS.
Fixed mobs spamming skills incoherently.
Added code support for old GMS-like PQ NPCs, where party leaders just need to click once to start a new PQ.
Implemented podium system for the Hall of Fame PlayerNPCs.
Improved character load-out system, now using way less queries to the DB in the process.
Fixed birthday field for accounts not being read correctly.
Further implemented the incomplete yet-existing Scissors of Karma mechanic.
Fixed Duey not propagating item flags when packaging an item.
Added a custom buyback system.
Refactored the character creation system, now offering support for Maple Life.
Fixed some issues with the PlayerNPC positioning system.
Added server flag allowing AP assignment for novices (beginners under level 11).
Fixed Strategy Time (GPQ) announcement being sent twice to guilds in certain cases.
Tweaked mount EXP system now awarding it accordingly with the amount of tiredness healed.
Removed the randomness aspect of closeness gain when feeding the pet, now acting accordingly with amount of fullness gained.
Fixed an exploit with Arwen script.
Fixed travel-back from Florina forcefully sending players to Lith Harbor in certain situations.
Thoroughly reviewed job skill questlines for Explorers and Aran.
Localhost edit: removed MTS block in certain maps (useful for the buyback system).
Localhost edit: removed party blocks for novices.
Localhost edit: removed AP assigning block for novices.
Localhost edit: removed speed cap.
Localhost edit: removed Maker block popping up when inputting ATK gems on non-weapons.

Author: ronancpl

README.md

@@ -5,11 +5,11 @@
 
 Credits are to be given too to Nexon(Duh!), the original MapleSolaxia staff and other colaborators, as just some changes/patches on the game were applied by myself, in which some of them diverged from the original v83 patch contents.
 
-Regarding distributability and usage of the code presented here: like it was before, this MapleStory server is open-source. By that, it is meant that anyone is free to install, use, modify and redistribute the contents, as long as there is no kind of commercial trading involved and the credits to the original creators are maintained within the codes.
+Regarding distributability and usage of the code presented here: like it was before, this MapleStory server is open-source. By that, it is meant that anyone is **free to install, use, modify and redistribute the contents**, as long as there is **no kind of commercial trading involved** and the **credits to the original creators are maintained** within the codes.
 
 This is a NetBeans 8.0.2 Project, that MUST be built and run under JDK/JRE 7 in order to run properly. This means that it's easier to install the project via opening the server project folder inside NetBeans' IDE. Once installed, build this project on your machine and run the server using the "launch.bat" application.
 
-In this project, many gameplay-wise issues generated from either the original WZ files and the server sources have been partially or completely solved. Considering the use of the provided edited WZ's and server-side wz.xml files should be of the greatest importance when dealing with this instance of private server, in order to perceive it at it's full potential. My opinion, though! Refer to "README_wzchanges.txt" for more information on what has been changed from Nexon's v83 WZ files.
+In this project, many gameplay-wise issues generated from either the original WZ files and the server source have been partially or completely solved. Considering the use of the provided edited WZ's and server-side wz.xml files should be of the greatest importance when dealing with this instance of private server, in order to perceive it at it's full potential. My opinion, though! Refer to "README_wzchanges.txt" for more information on what has been changed from Nexon's v83 WZ files.
 
 The main objective of this project is to try as best as possible to recreate what once was the original MapleStory v83, while adding up some flavors that spices up the gameplay. In other words, aim to get the best of the MapleStory of that era.
 
@@ -22,37 +22,55 @@ Client files & general tools: https://drive.google.com/drive/folders/0BzDsHSr-0V
 
 **Important note about localhosts**: these executables are red-flagged by antivirus tools as __potentially malicious softwares__, this happens due to the reverse engineering methods that were applied onto these software artifacts. Those depicted here have been put to use for years already and posed no harm so far, so they are soundly assumed to be safe.
 
-Recommended localhost: https://hostr.co/MluJQNtzAnV9
+Recommended localhost: https://hostr.co/m2bVtnizCtmD
 
 **Change log:**
 
+  * Removed block on applying attack-based strengthening gems on non-weapon equipments.
+
+  * Set a higher cap for SPEED.
+
+  * Removed the AP assigning block for beginners below level 10. https://hostr.co/AHAHzneCti9B
+
+  * Removed block on party for beginners level 10 or below. https://hostr.co/JZq53mMtToCz
+
+  * Removed block on MTS entering in some maps, rendering the buyback option available.
+
   * Removed "AP excess" popup and limited actions on Admin/MWLB, credits to kevintjuh93.
 
   * Removed "You've gained a level!" popup, credits to PrinceReborn.
 
-  * Removed caps for WATK, WDEF, MDEF, ACC, AVOID
+  * Removed caps for WATK, WDEF, MDEF, ACC, AVOID.
 
-  * 'n' problem fixed
+  * 'n' problem fixed.
 
   * Fraysa's https://hostr.co/gJbLZITRVHmv
 
-  * MapleSilver's starting on window-mode
+  * MapleSilver's starting on window-mode.
 
 ---
-### Support us
+### Development status
 
-Feel free to __root for us__ on our endeavour at our Discord channel, or even actively **help us improve** the server by issuing pull requests with informative details about what's changing.
+Status: <span style="color:green">__Released__</span>.
 
-Also, if you liked this project, please don't forget to __star__ the repo ;) .
+HeavenMS development achieved an acceptable state-of-art and will get into a halt. A heartfelt thanks for everyone that contributed in some way for the progress of this server!
 
-Discord: https://discord.gg/Q7wKxHX
+Although development is halted, support for fixing features that were implemented here is still up. You can still actively help us improve the server by issuing pull requests with informative details about what's changing.
+
+If you liked this project, please don't forget to __star__ the repo ;) .
+
+Our Discord channel is still available on: https://discord.gg/Q7wKxHX
 
 ### Donation
 
 If you REALLY liked what you have seen on the project, please feel free to donate a little something as a helping hand for my contributions towards Maple development. Also remember to **support Nexon**!
 
 Paypal: https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=3K8KVTWRLFBQ4
 
+### Note about public server
+
+HeavenMS staff has __no current intention__ to publicly open a server with this source, if that ever comes to happen this note will be lifted. __Don't be scammed!__
+
 ---
 ### Preparing the ambient 
 

docs/area_bosses/BossEvent.js

@@ -0,0 +1,33 @@
+// @Author: Resinate
+
+var towns = new Array(800020120, 251010102, 260010201, 107000300, 200010300, 100040105, 100040106, 261030000, 110040000, 250010504, 240040401, 104000400, 222010310, 230040420, 230040420, 230020100, 105090310, 101030404, 250010304, 220050100, 220050000, 220050200, 221040301);
+var spawns = new Array(6090002, 5220004, 3220001, 6220000, 8220000, 5220002, 5220002, 8220002, 5220001, 7220002, 8220003, 2220000, 7220001, 8510000, 8520000, 4220001, 8220008, 3220000, 7220000, 5220003, 5220003, 5220003, 6220001);
+var x = new Array(560, 560, 645, 90, 208, 456, 474, -300, 200, 400, 0, 400, 0, 527, 138, 0, -626, 800, -300, -300, 0, 0, -4224);
+var y = new Array(50, 50, 275, 119, 83, 278, 278, 180, 140, 540, 1125, 455, 33, -437, 138, 520, -604, 1280, 390, 1030, 1030, 1030, 776);
+var mapObj;
+var mobObj;
+
+function init() {
+    scheduleNew();
+}
+
+function scheduleNew() {
+    setupTask = em.schedule("start", 0);
+}
+
+function cancelSchedule() {
+    if (setupTask != null)
+        setupTask.cancel(true);
+}
+
+function start() {
+	var time = (Math.floor(Math.random() * 10) + 10) * (60 * 1000);
+	for(var i = 0; i < towns.length; i++) {
+		mapObj = em.getChannelServer().getMapFactory().getMap(towns[i]);
+		mobObj = Packages.server.life.MapleLifeFactory.getMonster(spawns[i]);
+		if(mapObj.getMonsterById(spawns[i]) == null) {
+			mapObj.spawnMonsterOnGroundBelow(mobObj, new Packages.java.awt.Point(x[i],y[i]));
+		}
+	}
+	em.schedule("start", time);
+}

docs/feature_list.md

@@ -22,7 +22,7 @@ Feature list:
 
 PQs:
 
-* HPQ/KPQ/LPQ/LMPQ/OPQ/EllinPQ/PiratePQ/MagatiaPQ/HorntailPQ/AmoriaPQ/TreasurePQ.
+* HPQ/KPQ/LPQ/LMPQ/OPQ/EllinPQ/PiratePQ/MagatiaPQ/HorntailPQ/AmoriaPQ/TreasurePQ/ElnathPQ.
 * CWKPQ as Expedition-based event.
 * Expeditions: Scarga/Horntail/Showa/Balrog/Zakum/Pinkbean.
 * GuildPQ + Guild queue with multi-lobby systems available.
@@ -32,7 +32,7 @@ PQs:
 
 Skills:
 
-* Some skills behaving oddly have been patched, such as Venomous Star/Stab and Mystic Doors.
+* Some skills behaving oddly have been patched, such as Steal, Venomous Star/Stab and Mystic Doors.
 * Maker skill features properly developed.
 * Server is using heuristics to calculate fee costs for the Maker (errors sums up to 8k mesos, reagent errors stacks up comformant with it's level).
 * New skill: Chair Mastery (max lv 1) - Players having this passive skill can gain a significant boost of HP/MP recovery when sitting on a field/map chair.
@@ -44,18 +44,23 @@ Quests:
 * Quest rewards according to jobs works properly.
 * Reward selection and randomed reward works properly.
 * Loads of quests have been patched.
+* Meso requirement for starting/completing quests now must be met by the player.
 * Lots of job questlines (rewarding skills) have been patched/implemented.
-* Enchanced rewarding system: checks for stacking opportunities on the inventory before checking for new slots.
+* Enhanced rewarding system: checks for stacking opportunities on the inventory before checking for new slots.
+* Improved the quest expiration system, one of the tweaks making the clock UI disappear when completing/expiring quests.
+* Reviewed Aran questline.
+* Reviewed 4th job skill questlines as a whole.
 * Complete overhaul on the 3rd job quiz (explorers), with all 40-question pool now made available.
 
 Player Social Network:
 
 * Guild and Alliance system fully functional.
+* Implemented Marriage system from the ground-up (excluding character packet encoding parts that were already present, proper credits given throughout the source files).
 * Beginners can create and join a "beginner-only" party (characters up to level 10).
 * Enhanced synchronization on Player Shops and Hired Merchants. Transactions made are instantly informed to the owner.
 * Game minirooms such as match cards and omok now has semi-functional password system.
 * Item pickup cooldown on non-owned/non-partyowned items functional.
-* Further improved the server's ranking system, to now display properly daily player ranking movement.
+* Further improved the server's ranking system, now displaying properly daily player ranking movement.
 * Automated support for Player NPCs and Hall of Fame.
 
 Cash & Items:
@@ -66,12 +71,14 @@ Cash & Items:
 * New scroll: antibanish. For use only in cases where bosses send a player back to town.
 * Inventory system properly checks for item slot free space and ownership.
 * Storage with "Arrange Items" feature functional.
+* Spikes on shoes.
 * Vega's spell.
 * Owl of Minerva.
 * Pet item ignore.
 * New Year's card (New Year effect sometimes d/c's a player).
 * Kite.
 * Cash Shop Surprise.
+* Maple Life.
 
 Monsters, Maps & Reactors:
 
@@ -80,12 +87,18 @@ Monsters, Maps & Reactors:
 * Monsterbook displays drop data info conformant with the underlying DB (needs custom wz). See more on the MobBookUpdate feature.
 * Every skill/mastery book is now droppable by mobs.
 * Mobs now can drop more than one of the same equipment (number of possible drops defined at droptime, uses the minimum/maximum quantity fields on DB).
+* Improved map bounding checks for item drop points, assuring most of the items dropped will be available to pickup inside the accessible map area.
+* Limited item count on maps, smartly expiring oldest registered items, preventing potential item flooding.
+* Implemented Zombify disease status.
 * Added Boss HP Bar for dozens of bosses (needs provided custom wz).
 * If multiple bosses are on the same area, client will prioritize Boss HP bar of the target of the player.
 * Boats, elevator and other travelling mechanics fully working.
+* HP decreasing overtime on maps and mechanics to prevent them (consumables, equips) fully functional.
 * Crimson Balrog boat approaching visual effect made functional.
 * PQs, Taxis and other event-driven situations warps players at random spawnpoints, GMS-like.
-* Some reactors (PQ bonus boxes) now sprays items on the map, instead of dropping everything at once.
+* Some reactors (PQ bonus boxes) spraying items on the map, instead of dropping everything at once.
+* Reactors pick items up smartly, checking for an option to pick up on many-items-nearby scenario.
+* Updated many scripted portals not implementing SFX properly.
 * Updated Crimsonwood, World Tour, Nihal Desert and Neo City, enabling quest completion and game progression in these areas.
 * Giant Cake (anniversary-themed boss) drops Maple equipments, Maple scrolls, summoning bags and many more interesting items.
 
@@ -110,16 +123,20 @@ Server potentials:
 * Enhanced auto-pot system: pet uses as many potions as necessary to reach the desired threshold.
 * Enhanced buff system: smartly checks for the best available buff effects to be active on the player.
 * Enhanced AP auto-assigner: exactly matches AP with the needed for the player's current level, surplus assigned to the primary attribute.
+* Tweaked pet/mount hunger: calculations for fullness/tiredness takes active time of the subject into account.
+* NPC crafters (equips, plates/jewels, etc) now won't take items freely if the requirement conditions are not properly met.
 * Pet item pickup now gives preference to player attacks rather than forcing attack disables when automatically picking up.
 * Channel capacity bar functional and world servers with max capacity checks.
 * Disease status are now visible for other players, even when changing maps.
 * Poison damage value are now visible for other players.
 * Mastery book announcer displays droppers of needed books of a player, by reading underlying DB.
 * Custom jail system (needs provided custom wz).
+* Custom buyback system.
 * Delete Character (requires ENABLE_PIC activated).
 * Autosaver (periodically saves on DB current state of every player in-game).
 * Both fixed and randomized versions of HP/MP growth rate available, regarding player job (enable one at ServerConstants). Placeholder for HP/MP washing feature.
 * Reallocated mapobjectids utilization throughout the source, preventing issues such as "NPC disappearing mysteriously after some server time" from happening.
+* Implemented old GMS statup mechanic for novices level 10 or below. Usage of the edited localhost is mandatory on this.
 * Accounts can be created automatically when trying to login on an inexistent account -- credits to shavit.
 * Usage of Bcrypt (up-to-date) as the main password hashing algorithm, replacing old SHA's -- credits to shavit.
 
@@ -157,6 +174,7 @@ Project:
 * Fixed/added some missing packets for MoveEnvironment, summons and others.
 * Uncovered many Send/Recv opcodes throughout the source.
 * Reviewed many Java object aspects that needed concurrency protection.
+* Usage of HikariCP to improve the DB connection management.
 * Protected many flaws with login management system.
 * Heavily reviewed future task management inside the project. Way less trivial schedules are spawned now, relieving task overload on the TimerManager.
 * ThreadTracker: embedded auditing tool for run-time deadlock scanning throughout the server source (relies heavily on memory usage, designed only for debugging purposes).
@@ -174,5 +192,17 @@ Localhost:
 * Removed caps for MATK, WDEF, MDEF, ACC and AVOID.
 * Removed "AP excess" popup and "Admin/MWLB" action block, original credits to kevintjuh93.
 * Removed "You've gained a level!" popup, original credits to PrinceReborn.
+* Removed "Cannot enter MTS from this map." popup on maps that blocks transitions (such change channel, CS/MTS), rendering the buyback option now available for all maps.
+* Removed a check for players wishing to create/join a party being novices under level 10.
+* Set a new high cap for SPEED.
+* Removed the AP assign block for novices.
+* Removed a block that would show up when trying to apply an attack gem on equipments that aren't weapons.
+
+Custom NPCs:
+
+* Agent E: Accessory crafter.
+* Donation Box: Instant-sell NPC.
+* Ace of Hearts & Coco: C. scroll crafter.
+* Spiegelmann: Instant-ore refiner NPC.
 
 ---------------------------

docs/issues.txt

@@ -10,18 +10,22 @@ Known issues:
 - Passwords on minirooms are not encoded for players entering/logging into the map.
 - Some criticals (e.g. from Aran skills) will not show up as crit for other players.
 - Deadlocks may start appearing if the server stays online long enough with many players logged in.
+- If there are multiple bosses that shows HPBar on the map, if a player hits more than one the HPBar may start flickering on the screen.
 ---------------------------
 
 ---------------------------
 Missing features list:
 - Miniroom tooltips (such as number of players in store/host awaiting game) not showing up properly.
+- Change name/World transfer.
+- Some pirate skills doesn't work for 3rd parties.
+- Medal quests.
 ---------------------------
 
 
 ---------------------------
 ** Others **
-- Marriage
 - Family system
+- MTS
 ---------------------------