Feature branch for tiles xy-to-quadkey conversion #1
Conversation
|
Rebase with squash to 1 commit please |
…nd quadkey - add new functionality and a whole bunch of unit tests - add polygon refinement functionality - add polygon refinement and polygon to map test
beauof
force-pushed
the
feature-tiles-xy-quadkey
branch
from
6c81ecb to
1a3ca83
Compare
| * Get flood filled image | ||
| * | ||
| */ | ||
| public int[][] getFloodFill(){ |
There was a problem hiding this comment.
if i run
floodFill f = new floodFill();
int[][] ff = f.getFloodFill();
int a = ff.length; //-> NullPointerException.Always return useful values for public access methods or state what to expect. what needs to be called first before this contains useful values? et
There was a problem hiding this comment.
The first line will cause a compile-time error because there's not constructor without arguments. So this should never happen? I've added a comment in the constructor that we expect a non-empty image to be supplied.
| import java.util.Map; | ||
| import java.util.stream.IntStream; | ||
|
|
||
| public class polygon { |
There was a problem hiding this comment.
CamelCase! -> Polygon.
Also, if this is a polygon composed of NDSCoordinates, it should be named "NDSPolygon"
also, it has a main method. add a separate Class "NDSPolyFillDemo" with it, and put the polygon logic into the NDSPolygon class
There was a problem hiding this comment.
I've moved the demo away from the class - still not sure if that's organized well. Might have to revisit the files later.
| } | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
What is the test coverage of these tests?
There was a problem hiding this comment.
NDSTile - 94 %.
nds-tiles repo - 82.9 %.
rondiplomatico
left a comment
rondiplomatico
left a comment
There was a problem hiding this comment.
Repeated Review with current rebase
beauof
force-pushed
the
feature-tiles-xy-quadkey
branch
from
b7423fb to
e82a2b5
Compare
2 participants
This feature branch implements functionality to convert tile x/y indices to quadkey and vice-versa.
More features: