[ZH] Fix compiler warnings for uninitialised variables in copy constructors (TheSuperHackers#534)

Author: Bart Roossien

GeneralsMD/Code/GameEngine/Include/Common/GlobalData.h

@@ -531,9 +531,14 @@ class GlobalData : public SubsystemInterface
 	GlobalData *newOverride( void );		/** create a new override, copy data from previous
 																			override, and return it */
 
-
+	// TheSuperHackers @compilerwarning fix Mauller 28/03/2025 incomplete copy constructors causing uninitialised variable warnings in compilation.
+	#if defined(_MSC_VER) && _MSC_VER < 1300
 	GlobalData(const GlobalData& that) { DEBUG_CRASH(("unimplemented")); }
 	GlobalData& operator=(const GlobalData& that) { DEBUG_CRASH(("unimplemented")); return *this; }
+    #else
+	GlobalData(const GlobalData& that) = delete;
+	GlobalData& operator=(const GlobalData& that) = default;	//Copy constructor is actually used by the new override function.
+	#endif
 
 };
 

GeneralsMD/Code/GameEngine/Include/Common/ThingTemplate.h

@@ -351,10 +351,16 @@ class ThingTemplate : public Overridable
 	MEMORY_POOL_GLUE_WITH_USERLOOKUP_CREATE(ThingTemplate, "ThingTemplatePool" )		
 
 private:
+
+	// TheSuperHackers @compilerwarning fix Mauller 28/03/2025 incomplete copy constructors causing uninitialised variable warnings in compilation.
+	#if defined(_MSC_VER) && _MSC_VER < 1300
 	ThingTemplate(const ThingTemplate& that) : m_geometryInfo(that.m_geometryInfo) 
 	{ 
 		DEBUG_CRASH(("This should never be called\n")); 
 	}
+	#else
+	ThingTemplate(const ThingTemplate& that) = delete;
+	#endif
 
 public:
 

GeneralsMD/Code/GameEngine/Source/Common/GlobalData.cpp

@@ -1129,6 +1129,7 @@ Bool GlobalData::setTimeOfDay( TimeOfDay tod )
 //-------------------------------------------------------------------------------------------------
 GlobalData *GlobalData::newOverride( void )
 {
+	// TheSuperHackers @info This copy is not implemented in VS6 builds
 	GlobalData *override = NEW GlobalData;
 
 	// copy the data from the latest override (TheWritableGlobalData) to the newly created instance