docs(stats): finish scrubbing development-process references from comments

The earlier comment cleanup swept server/ and webapp/src/ but missed
webapp/e2e/, the plik client tests, and task numbers written as words.
Comments now carry their rationale inline instead of referencing decision
IDs, task numbers, or review-finding codes that exist only in uncommitted
planning documents. Also drops a stale mention of a deleted retry symbol
and the registry's removed add closures.

Author: ca.mathieu

plik/client_test.go

@@ -240,9 +240,9 @@ func TestUploadFiles(t *testing.T) {
 // This uploads ~30 files onto one shared Upload concurrently; each file status
 // write takes server/metadata's canonical upload-row lock (lockUploadRow) before
 // touching the file row. It was historically flaky (~17% over 60 runs) because
-// the old fixed retry budget (maxStatsRetryAttempts) could exhaust under SQLite
-// write contention and surface a 500 ("database is locked"). Task 24 removed the
-// retry apparatus and instead opens SQLite transactions with the write lock held
+// a fixed transaction-retry budget could exhaust under SQLite write contention
+// and surface a 500 ("database is locked"). That retry apparatus is gone:
+// SQLite transactions are instead opened with the write lock held
 // from BEGIN (_txlock=immediate, see metadata.sqliteConnectionString) plus a
 // busy_timeout, so concurrent writers serialize as bounded lock waits rather than
 // racing to upgrade a deferred read into a writer and deadlocking. The retry

plik/z4_e2e_client_concurrent_test.go

@@ -134,8 +134,8 @@ func TestMultipleFilesInParallel(t *testing.T) {
 // a process-killing panic, so it was historically sensitive to the same SQLite
 // write contention as TestUploadMultipleFiles (client_test.go): concurrent
 // uploads onto one shared Upload could exhaust the old fixed retry budget on the
-// upload-row lock. Task 24 removed the retry apparatus and opens SQLite
-// transactions IMMEDIATE (metadata.sqliteConnectionString), so writers serialize
+// upload-row lock. That retry apparatus is gone: SQLite transactions now open
+// IMMEDIATE (metadata.sqliteConnectionString), so writers serialize
 // as bounded busy_timeout lock waits instead of deadlocking on a deferred-read
 // upgrade. -race shows no data races.
 func TestMultipleFilesInParallelBusyLoop(t *testing.T) {

server/handlers/get_file.go

@@ -313,7 +313,7 @@ func GetFile(ctx *context.Context, resp http.ResponseWriter, req *http.Request)
 			// file, so every GET is a complete download — applying the
 			// byte-0 range policy here would let a Range header evade
 			// counting a one-shot/stream file that was fully consumed. The
-			// event is therefore always counted (Task 7 behavior); recording
+			// event is therefore always counted; recording
 			// happens after streaming so the bytes served are captured too.
 			cw := newCountingResponseWriter(resp)
 

server/handlers/get_file_test.go

@@ -508,8 +508,8 @@ func TestGetOneShotFileRangedRequestCounts(t *testing.T) {
 	require.Equal(t, int64(1), f.DownloadCount, "invalid download count")
 
 	// The one-shot/stream branch ignores Range and streams the full file, so the
-	// full file content length is recorded as bytes served (Task 7 behavior
-	// preserved). file.Size is not set in this fixture, so compare to len(data).
+	// full file content length is recorded as bytes served. file.Size is not set
+	// in this fixture, so compare to len(data).
 	fileDownloads, fileBytes, found := dailyDownloadStatsFor(t, ctx, common.DownloadStatsEntityFile, file.ID)
 	require.True(t, found)
 	require.Equal(t, int64(1), fileDownloads, "one-shot ranged GET still counts one event")

server/metadata/stats_counters_test.go

@@ -34,7 +34,7 @@ func gormColumnName(tag string) string {
 // this test; production paths iterate the registry directly.
 //
 // This only checks that the column *names* match set-for-set; it says nothing
-// about whether each counterSpec's get/add/set closures are wired to the right
+// about whether each counterSpec's get/set closures are wired to the right
 // usageDelta/common.UsageStats field. That correctness is covered elsewhere, by
 // the agreement/exactness tests (e.g. TestBackend_ImportBackfillLifetimeCounterAgreement
 // and the various "...IsExact" tests in stats_test.go) that exercise real

webapp/ARCHITECTURE.md

@@ -579,7 +579,7 @@ Extracted so the current/lifetime stats dashboard is defined once and reused per
 | `StatsUsagePanel` | Composite. Given the canonical `usage` object it renders the current/lifetime tile columns, one merged **Activity** card, and the six side-by-side distribution cards (feature / TTL / file-size). The Activity card has a 4-metric segmented selector — Downloads / Uploads / Downloaded data / Uploaded data — that drives BOTH the window tiles (Today / 7 days / 30 days / **Lifetime**) and the `ActivityChart` for the selected metric. Count-metric windows come from the `usage` object (`downloads`/`uploads` today/last7Days/last30Days + total); byte-metric windows are summed from `dailySeries` (Lifetime from `usage.*.bytes`), so a null series leaves byte windows at 0 while Lifetime still renders. Scope-specific bits are props/slots: `currentTiles`/`lifetimeTiles`, `showActivity` (scopes without windows/series), a `#storage` slot (admin-only), and `dailySeries` (the 30-day activity series; `null`/empty omits the chart but keeps the tiles). The "since {date}" is printed once, in the lifetime column title. |
 | `ActivityChart` | Presentational 30-day activity column chart. It is **controlled** by the panel: the measure is a `metric` prop (`downloads` \| `uploads` \| `downloadedBytes` \| `uploadedBytes`) — the segmented selector lives on the Activity card, not inside the chart. Props: `series` (`[{day, downloads, downloadedBytes, uploads, uploadedBytes}]`) and `metric`. Bars use a single accent token, axis/tooltip text use `surface-*` ink, gridlines a recessive surface token; y-axis starts at 0 with ~3 gridlines, x-axis labels every 7th UTC day, values humanized per metric — counts (`1.2k`) for download/upload metrics, byte sizes (`1.5 MB`) for the `*Bytes` metrics. Per-column hover shows a day+value tooltip (edge-flipped so it never clips); all-zero data draws the axis + a quiet empty-state line; the grow-in animation respects `prefers-reduced-motion`. Pure scale/tick/label helpers live in `chart-utils.js` (unit-tested), including `isByteMetric()` which classifies the four metric keys. |
 
-> `StatsUsagePanel` owns the `statsPanel.*` i18n namespace (period titles, the Activity metric-selector labels, window-tile labels, distribution labels, and the `ActivityChart` empty/aria strings). Distribution bar colours are intentionally a single accent token pending the colour-finalisation task.
+> `StatsUsagePanel` owns the `statsPanel.*` i18n namespace (period titles, the Activity metric-selector labels, window-tile labels, distribution labels, and the `ActivityChart` empty/aria strings). Distribution bar colours are intentionally a single accent token; per-category tinting is a possible future refinement.
 >
 > `ActivityChart` is a hand-rolled SVG in a Vue SFC with **no charting dependency** — a bar chart this small needs only `<rect>`/`<path>` plus a handful of pure geometry helpers, so adding a library (and its bundle/theming/maintenance cost) would not pay for itself; theme reactivity comes for free from the `--color-*` tokens the SVG references.
 

webapp/e2e/stats-ui.spec.js

@@ -81,7 +81,7 @@ test.describe('Stats UI', () => {
         // Genuinely binary content (NUL bytes) — the server sniffs actual bytes
         // to set isText, regardless of filename/declared content-type. A real
         // .bin file must not be auto-previewed by DownloadView, or the "Never
-        // downloaded yet" baseline below wouldn't hold (D2: previews count).
+        // downloaded yet" baseline below wouldn't hold (previews count as downloads).
         const binaryContent = '\x00'.repeat(32)
         const never = await createAuthenticatedUploadWithFile(page, 'stats-download-never.bin', binaryContent)
         await page.goto(`/#/?id=${never.upload.id}`)
@@ -155,9 +155,10 @@ test.describe('Stats UI', () => {
     })
 
     test('sidebar download count reflects the auto-preview immediately after an in-app upload (no stale count)', async ({ authenticatedPage: page }) => {
-        // D2: owner self-downloads and previews count as downloads. Uploading a
-        // single text file through the UI auto-opens its preview, which fetches
-        // the file content and — per D2 — is itself counted as a download.
+        // Owner self-downloads and previews count as downloads (they are real
+        // served traffic). Uploading a single text file through the UI auto-opens
+        // its preview, which fetches the file content and is itself counted as a
+        // download.
         // Regression check for the stale-count fix: without any reload, the
         // sidebar must reflect that download, not the pre-preview count.
         await uploadTestFile(page, 'stats-stale-count.txt', 'stale count regression content')
@@ -229,7 +230,7 @@ test.describe('Stats UI', () => {
 
         // Trending window chips use the same Today/7 days/30 days/Lifetime
         // vocabulary as the Activity tiles (not the raw 1d/7d/30d/all API values,
-        // and not the "All time" wording those tiles retired — B1/audit-tech F1).
+        // and not the retired "All time" wording).
         const trendingCard = page.locator('.glass-card').filter({ hasText: 'Trending Uploads' })
         await expect(trendingCard.getByRole('button', { name: 'Today', exact: true })).toBeVisible()
         await expect(trendingCard.getByRole('button', { name: '7 days', exact: true })).toBeVisible()
@@ -276,7 +277,7 @@ test.describe('Stats UI', () => {
         await expect(bytesToggle).toBeVisible()
 
         // Default sort (downloads): every row shows BOTH a downloads figure and a
-        // humanized bytes figure (T27 — the toggle emphasizes, never hides, the
+        // humanized bytes figure (the toggle emphasizes, never hides, the
         // other metric).
         await expect(trendingCard.getByText(/\d+ downloads/).first()).toBeVisible()
         await expect(trendingCard.getByText(/[\d.]+\s*(B|KB|MB|GB)/).first()).toBeVisible()
@@ -303,7 +304,7 @@ test.describe('Stats UI', () => {
         await expect(page.getByText('Current Usage')).toBeVisible()
         await expect(page.getByText('Lifetime Usage')).toBeVisible()
 
-        // D9: Home renders through the same shared StatsUsagePanel as Admin, scoped
+        // Home renders through the same shared StatsUsagePanel as Admin, scoped
         // to this user — distribution cards and the downloads windows row included.
         await expect(page.getByText('Current Feature Usage')).toBeVisible()
         await expect(page.getByText('Lifetime Feature Usage')).toBeVisible()
@@ -316,10 +317,10 @@ test.describe('Stats UI', () => {
         await expect(activityPanel.getByText('Lifetime', { exact: true })).toBeVisible()
 
         // Privacy: no admin/server-scope-only data leaks onto the user's Home page.
-        // T27 adds a SELF-scoped Trending Uploads panel to Home (this user's own
+        // Home carries a SELF-scoped Trending Uploads panel (this user's own
         // uploads only, dedicated test below) — so a blanket "no Trending at all"
-        // check no longer holds; what must still never appear is the admin-only,
-        // cross-user Trending Files card (D18: no self-scoped files endpoint) and
+        // check would not hold; what must still never appear is the admin-only,
+        // cross-user Trending Files card (deliberately no self-scoped files endpoint) and
         // the owner/anonymous chips that only make sense server-wide.
         await expect(page.getByText('Server Statistics')).not.toBeVisible()
         await expect(page.getByText('Trending Files')).not.toBeVisible()
@@ -406,7 +407,7 @@ test.describe('Stats UI', () => {
         await expect(tooltip).toContainText(/\d/)
 
         // Switching to a byte metric swaps the tooltip to a byte value. Scoped to
-        // the Activity card specifically (T27 added a second, unrelated
+        // the Activity card specifically (there is a second, unrelated
         // "Downloaded data" toggle on this page — the Trending Uploads metric
         // toggle — so an unscoped lookup is now ambiguous).
         const activityPanel = page.locator('.glass-card').filter({ hasText: 'Activity' }).filter({ hasText: 'Lifetime' })

webapp/src/__tests__/locales.test.js

@@ -329,7 +329,7 @@ describe('locale suspicious-identical-to-English check', () => {
         })
 
         it(`${file}'s allowlist has no stale entries`, () => {
-            // Keeps the allowlist honest (task requirement: pass because things
+            // Keeps the allowlist honest (the suite must pass because strings
             // are translated, not because the allowlist is bloated) — an
             // allowlisted key whose value no longer matches en.json (translated
             // since, or the English source changed) should be removed from the