Skip to content

Commit a73f11d

Browse files
committed
[CMake] Don't check if Python headers are found in RootBuildOptions
This is a followup to 5e424e4, where the Python finding was moved into `SearchInstalledSoftware.cmake`. However, what I missed is that there was a check in `RootBuildOptions` that disabled PyROOT by default if Python is not found, which is now not the case at that point! Therefore, ROOT builds won't have PyROOT by default anymore, which is a bad mistake. Fortunately, the check is entirely redundant and this commit suggests to remove it. There is already a check in `SearchInstalledSoftware` where PyROOT (and `tmva-pymva`) are disabled when the Python development headers where not found.
1 parent f2dd53a commit a73f11d

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

cmake/modules/RootBuildOptions.cmake

-6
Original file line numberDiff line numberDiff line change
@@ -314,12 +314,6 @@ elseif(APPLE)
314314
set(x11_defvalue OFF)
315315
endif()
316316

317-
# Pyroot requires Python development package; force to OFF if it was not found
318-
if(NOT Python3_Development_FOUND)
319-
set(pyroot_defvalue OFF)
320-
set(tmva-pymva_defvalue OFF)
321-
endif()
322-
323317
# Current limitations for modules:
324318
#---Modules are disabled on aarch64 platform (due ODR violations)
325319
if(CMAKE_SYSTEM_PROCESSOR MATCHES aarch64)

0 commit comments

Comments
 (0)