Skip to content

Commit c303cd3

Browse files
committed
[df][NFC] Adapt unittest to changes
1 parent a2d2f39 commit c303cd3

File tree

1 file changed

+23
-19
lines changed

1 file changed

+23
-19
lines changed

Diff for: bindings/experimental/distrdf/test/test_ranges.py

+23-19
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66

77
import ROOT
88

9+
from collections import namedtuple
10+
11+
# Use a dummy execution identifier to test for TTree-based clustered ranges
12+
Dummy = namedtuple("Dummy", ["rdf_uuid"])
913

1014
def emptysourceranges_to_tuples(ranges):
1115
"""Convert EmptySourceRange objects to tuples with the shape (start, end)"""
@@ -34,11 +38,11 @@ def test_nentries_multipleOf_npartitions(self):
3438
npartitions_large = 10
3539

3640
# First case
37-
rng = Ranges.get_balanced_ranges(nentries_small, npartitions_small, exec_id=None)
41+
rng = Ranges.get_balanced_ranges(nentries_small, npartitions_small, exec_id=Dummy("dummy"))
3842
ranges_small = emptysourceranges_to_tuples(rng)
3943

4044
# Second case
41-
rng = Ranges.get_balanced_ranges(nentries_large, npartitions_large, exec_id=None)
45+
rng = Ranges.get_balanced_ranges(nentries_large, npartitions_large, exec_id=Dummy("dummy"))
4246
ranges_large = emptysourceranges_to_tuples(rng)
4347

4448
ranges_small_reqd = [(0, 2), (2, 4), (4, 6), (6, 8), (8, 10)]
@@ -70,12 +74,12 @@ def test_nentries_not_multipleOf_npartitions(self):
7074

7175
# Example in which fractional part of
7276
# (nentries/npartitions) >= 0.5
73-
rng = Ranges.get_balanced_ranges(nentries_1, npartitions, exec_id=None)
77+
rng = Ranges.get_balanced_ranges(nentries_1, npartitions, exec_id=Dummy("dummy"))
7478
ranges_1 = emptysourceranges_to_tuples(rng)
7579

7680
# Example in which fractional part of
7781
# (nentries/npartitions) < 0.5
78-
rng = Ranges.get_balanced_ranges(nentries_2, npartitions, exec_id=None)
82+
rng = Ranges.get_balanced_ranges(nentries_2, npartitions, exec_id=Dummy("dummy"))
7983
ranges_2 = emptysourceranges_to_tuples(rng)
8084

8185
# Required output pairs
@@ -94,7 +98,7 @@ def test_nentries_greater_than_npartitions(self):
9498
nentries = 5
9599
npartitions = 7
96100

97-
rng = Ranges.get_balanced_ranges(nentries, npartitions, exec_id=None)
101+
rng = Ranges.get_balanced_ranges(nentries, npartitions, exec_id=Dummy("dummy"))
98102
ranges = emptysourceranges_to_tuples(rng)
99103

100104
ranges_reqd = [(0, 1), (1, 2), (2, 3), (3, 4), (4, 5)]
@@ -157,7 +161,7 @@ def test_clustered_ranges_with_one_cluster(self):
157161
filenames = ["backend/Slimmed_ntuple.root"]
158162
npartitions = 1
159163

160-
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=None)
164+
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
161165
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
162166

163167
ranges = treeranges_to_tuples(clusteredranges)
@@ -180,7 +184,7 @@ def test_npartitions_greater_than_clusters(self):
180184
filenames = ["backend/Slimmed_ntuple.root"]
181185
npartitions = 2
182186

183-
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=None)
187+
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
184188
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
185189

186190
# We return one task per partition
@@ -204,7 +208,7 @@ def test_clustered_ranges_with_two_clusters_two_partitions(self):
204208
filenames = ["backend/2clusters.root"]
205209
npartitions = 2
206210

207-
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=None)
211+
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
208212
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
209213
ranges = treeranges_to_tuples(clusteredranges)
210214

@@ -227,7 +231,7 @@ def test_rdataframe_with_treename_and_filename_with_globbing(self):
227231
expected_inputfiles = ["backend/2clusters.root"]
228232
extracted_inputfiles = rdf.inputfiles
229233

230-
percranges = Ranges.get_percentage_ranges([treename], extracted_inputfiles, npartitions, friendinfo=None, exec_id=None)
234+
percranges = Ranges.get_percentage_ranges([treename], extracted_inputfiles, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
231235
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
232236
ranges = treeranges_to_tuples(clusteredranges)
233237

@@ -258,7 +262,7 @@ def test_rdataframe_with_notreename_and_chain_with_subtrees(self):
258262
extracted_filenames = rdf.inputfiles
259263

260264
percranges = Ranges.get_percentage_ranges(
261-
extracted_subtreenames, extracted_filenames, npartitions, friendinfo=None, exec_id=None)
265+
extracted_subtreenames, extracted_filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
262266
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
263267
ranges = treeranges_to_tuples(clusteredranges)
264268

@@ -281,7 +285,7 @@ def test_clustered_ranges_with_four_clusters_four_partitions(self):
281285
filenames = ["backend/4clusters.root"]
282286
npartitions = 4
283287

284-
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=None)
288+
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
285289
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
286290

287291
ranges = treeranges_to_tuples(clusteredranges)
@@ -304,7 +308,7 @@ def test_clustered_ranges_with_many_clusters_four_partitions(self):
304308
filenames = ["backend/1000clusters.root"]
305309
npartitions = 4
306310

307-
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=None)
311+
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
308312
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
309313

310314
ranges = treeranges_to_tuples(clusteredranges)
@@ -327,7 +331,7 @@ def test_clustered_ranges_with_many_clusters_many_partitions(self):
327331
filenames = ["backend/1000clusters.root"]
328332
npartitions = 1000
329333

330-
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=None)
334+
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
331335
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
332336

333337
ranges = treeranges_to_tuples(clusteredranges)
@@ -349,7 +353,7 @@ def test_clustered_ranges_with_two_files(self):
349353
filenames = ["backend/2clusters.root", "backend/4clusters.root"]
350354
npartitions = 2
351355

352-
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=None)
356+
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
353357
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
354358

355359
ranges = treeranges_to_tuples(clusteredranges)
@@ -366,7 +370,7 @@ def test_three_files_one_partition(self):
366370
filenames = [f"distrdf_unittests_file_{i}.root" for i in range(nfiles)]
367371
npartitions = 1
368372

369-
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=None)
373+
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
370374
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
371375

372376
ranges = treeranges_to_tuples(clusteredranges)
@@ -382,7 +386,7 @@ def test_three_files_one_partition_per_file(self):
382386
filenames = [f"distrdf_unittests_file_{i}.root" for i in range(nfiles)]
383387
npartitions = nfiles
384388

385-
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=None)
389+
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
386390
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
387391

388392
ranges = treeranges_to_tuples(clusteredranges)
@@ -398,7 +402,7 @@ def test_three_files_two_partitions_per_file(self):
398402
treenames = [f"tree_{i}" for i in range(nfiles)]
399403
filenames = [f"distrdf_unittests_file_{i}.root" for i in range(nfiles)]
400404
npartitions = nfiles * 2
401-
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=None)
405+
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
402406
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
403407

404408
ranges = treeranges_to_tuples(clusteredranges)
@@ -425,7 +429,7 @@ def test_three_files_partitions_equal_clusters(self):
425429
filenames = [f"distrdf_unittests_file_{i}.root" for i in range(nfiles)]
426430
npartitions = nfiles * 10 # trees have 10 clusters
427431

428-
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=None)
432+
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
429433
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
430434

431435
ranges = treeranges_to_tuples(clusteredranges)
@@ -473,7 +477,7 @@ def test_three_files_partitions_greater_than_clusters(self):
473477
filenames = [f"distrdf_unittests_file_{i}.root" for i in range(nfiles)]
474478
npartitions = 42
475479

476-
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=None)
480+
percranges = Ranges.get_percentage_ranges(treenames, filenames, npartitions, friendinfo=None, exec_id=Dummy("dummy"))
477481
clusteredranges = [Ranges.get_clustered_range_from_percs(percrange)[0] for percrange in percranges]
478482

479483
# We return one task per partition

0 commit comments

Comments
 (0)