Skip to content

Changed install location for builtins #8732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Changed install location for builtins #8732

wants to merge 1 commit into from

Conversation

AdvaitDhingra
Copy link
Contributor

This Pull request:

Changes or fixes:

Changes the builtins install location to ${CMAKE_INSTALL_PREFIX}/include/ROOT_builtins}

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #8655

@AdvaitDhingra AdvaitDhingra requested a review from bellenot as a code owner July 26, 2021 10:55
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-07-26T11:01:03.596Z] FAILED: /usr/bin/ccache /usr/bin/c++ -I/mnt/build/workspace/root-pullrequests-build/root/net/davix/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/unix/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/foundation/v7/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/base/v7/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clingutils/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/textinput/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/thread/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/zip/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/rint/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clib/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/meta/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/gui/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/cont/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/foundation/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/base/inc -Iginclude -I/mnt/build/workspace/root-pullrequests-build/root/net/net/inc -I/mnt/build/workspace/root-pullrequests-build/root/io/io/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clib/res -I/mnt/build/workspace/root-pullrequests-build/root/builtins -Ibuiltins/davix/DAVIX-prefix/include/davix -fdiagnostics-color=always -std=c++14 -pipe -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -O3 -fPIC -Wno-deprecated-declarations -std=c++14 -MD -MT net/davix/CMakeFiles/RDAVIX.dir/src/TDavixSystem.cxx.o -MF net/davix/CMakeFiles/RDAVIX.dir/src/TDavixSystem.cxx.o.d -o net/davix/CMakeFiles/RDAVIX.dir/src/TDavixSystem.cxx.o -c /mnt/build/workspace/root-pullrequests-build/root/net/davix/src/TDavixSystem.cxx
  • [2021-07-26T11:01:03.596Z] /mnt/build/workspace/root-pullrequests-build/root/net/davix/src/TDavixSystem.cxx:42:21: fatal error: davix.hpp: No such file or directory
  • [2021-07-26T11:01:03.596Z] FAILED: /usr/bin/ccache /usr/bin/c++ -I/mnt/build/workspace/root-pullrequests-build/root/net/davix/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/unix/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/foundation/v7/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/base/v7/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clingutils/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/textinput/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/thread/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/zip/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/rint/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clib/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/meta/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/gui/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/cont/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/foundation/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/base/inc -Iginclude -I/mnt/build/workspace/root-pullrequests-build/root/net/net/inc -I/mnt/build/workspace/root-pullrequests-build/root/io/io/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clib/res -I/mnt/build/workspace/root-pullrequests-build/root/builtins -Ibuiltins/davix/DAVIX-prefix/include/davix -fdiagnostics-color=always -std=c++14 -pipe -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -O3 -fPIC -Wno-deprecated-declarations -std=c++14 -MD -MT net/davix/CMakeFiles/RDAVIX.dir/src/TDavixFile.cxx.o -MF net/davix/CMakeFiles/RDAVIX.dir/src/TDavixFile.cxx.o.d -o net/davix/CMakeFiles/RDAVIX.dir/src/TDavixFile.cxx.o -c /mnt/build/workspace/root-pullrequests-build/root/net/davix/src/TDavixFile.cxx
  • [2021-07-26T11:01:03.596Z] /mnt/build/workspace/root-pullrequests-build/root/net/davix/src/TDavixFile.cxx:49:21: fatal error: davix.hpp: No such file or directory
  • [2021-07-26T11:01:03.855Z] FAILED: /usr/bin/ccache /usr/bin/c++ -I/mnt/build/workspace/root-pullrequests-build/root/net/davix/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/unix/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/foundation/v7/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/base/v7/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clingutils/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/textinput/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/thread/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/zip/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/rint/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clib/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/meta/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/gui/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/cont/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/foundation/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/base/inc -Iginclude -I/mnt/build/workspace/root-pullrequests-build/root/net/net/inc -I/mnt/build/workspace/root-pullrequests-build/root/io/io/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clib/res -I/mnt/build/workspace/root-pullrequests-build/root/builtins -Ibuiltins/davix/DAVIX-prefix/include/davix -fdiagnostics-color=always -std=c++14 -pipe -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -O3 -fPIC -Wno-deprecated-declarations -std=c++14 -MD -MT net/davix/CMakeFiles/RDAVIX.dir/src/RRawFileDavix.cxx.o -MF net/davix/CMakeFiles/RDAVIX.dir/src/RRawFileDavix.cxx.o.d -o net/davix/CMakeFiles/RDAVIX.dir/src/RRawFileDavix.cxx.o -c /mnt/build/workspace/root-pullrequests-build/root/net/davix/src/RRawFileDavix.cxx
  • [2021-07-26T11:01:03.855Z] /mnt/build/workspace/root-pullrequests-build/root/net/davix/src/RRawFileDavix.cxx:20:21: fatal error: davix.hpp: No such file or directory

bellenot
bellenot reviewed Jul 26, 2021
View reviewed changes
Copy link
Member

@bellenot bellenot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but I don't think it's good enough. Some header files have to be found by ROOT, and there are quite a few more packages than those two IIRC...

@AdvaitDhingra
Copy link
Contributor Author

I don't think it's good enough. Some header files have to be found by ROOT, and there are quite a few more packages than those two IIRC...

Yeah, this wont be as simple as I thought it would be 😅 . I'll come up with a solution.

@AdvaitDhingra
Copy link
Contributor Author

After some trial and error I've realized that this task is too hard for me 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellenot bellenot bellenot left review comments

Assignees

@bellenot bellenot

Labels
improvement in:Build System priority:default
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Build system] ROOT installs its builtins directly into CMAKE_INSTALL_PREFIX.
3 participants
@AdvaitDhingra @phsft-bot @bellenot