Skip to content

Commit 271d22a

Browse files
authored
🩹 fix(minor): ensure unique compiler name in cache service (#2666)
Fixes warnings related to child instances not having a unique cache identity. ## Type of change **PATCH: backwards compatible change**
1 parent cce6155 commit 271d22a

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

sources/@roots/bud-cache/src/service.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ export default class Cache extends Service implements BudCache {
7777
*/
7878
public get name(): string {
7979
const fallback = join(
80+
this.app.label,
8081
this.app.mode,
8182
...Object.values(this.app.context._ ?? {}),
8283
)

sources/@roots/bud-cache/test/service.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ describe(`@roots/bud-cache`, () => {
6969
expect.arrayContaining([bud.path(`@modules`)]),
7070
)
7171
// @ts-ignore
72-
expect(cache.configuration?.name).toEqual(`production`)
72+
expect(cache.configuration?.name).toEqual(`@tests/project/production`)
7373
// @ts-ignore
7474
expect(cache.configuration?.profile).toEqual(false)
7575
// @ts-ignore

sources/@roots/wordpress-theme-json-webpack-plugin/src/theme.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1176,9 +1176,9 @@ export interface RefComplete {
11761176
*/
11771177
export interface StylesElementsPropertiesComplete {
11781178
button?: {
1179-
[k: string]: unknown
1180-
} &
1181-
StylesElementsPseudoSelectorsProperties & StylesProperties
1179+
[k: string]: unknown
1180+
} & StylesElementsPseudoSelectorsProperties &
1181+
StylesProperties
11821182
caption?: StylesPropertiesComplete
11831183
cite?: StylesPropertiesComplete
11841184
h1?: StylesPropertiesComplete
@@ -1189,9 +1189,9 @@ export interface StylesElementsPropertiesComplete {
11891189
h6?: StylesPropertiesComplete
11901190
heading?: StylesPropertiesComplete
11911191
link?: {
1192-
[k: string]: unknown
1193-
} &
1194-
StylesElementsPseudoSelectorsProperties & StylesProperties
1192+
[k: string]: unknown
1193+
} & StylesElementsPseudoSelectorsProperties &
1194+
StylesProperties
11951195
}
11961196
export interface StylesElementsPseudoSelectorsProperties {
11971197
':active'?: StylesPropertiesComplete

0 commit comments

Comments
 (0)