Fix lint warnings and repository ignores

Author: rootverdict

.gitignore

@@ -3,6 +3,7 @@ __pycache__/
 *.py[cod]
 *.so
 .pytest_cache/
+.ruff_cache/
 .mypy_cache/
 .coverage
 htmlcov/
@@ -19,6 +20,7 @@ dist/
 
 # Local generated handbook (large, not intended for GitHub)
 MALFORGE_COMPLETE_PROJECT_HANDBOOK.md
+.codex-handbook-deps/
 
 # Generated project outputs
 output/sigma/*

converters/wazuh_converter.py

@@ -8,10 +8,12 @@
 from typing import MutableMapping
 import xml.etree.ElementTree as ET
 
-from core.constants import SIGMA_TO_WAZUH_LEVEL, WAZUH_CUSTOM_RULE_ID_RANGE, WAZUH_RULE_ID_END, WAZUH_RULE_ID_START
+from core.constants import SIGMA_TO_WAZUH_LEVEL, WAZUH_CUSTOM_RULE_ID_RANGE
 from core.models import SigmaRule, WazuhRule
 
 DEFAULT_GROUP_NAME = "malware_behavior_detection_generator,"
+WAZUH_RULE_ID_START = WAZUH_CUSTOM_RULE_ID_RANGE.start
+WAZUH_RULE_ID_END = WAZUH_CUSTOM_RULE_ID_RANGE.stop - 1
 
 WINDOWS_LOGSOURCE_MAPPING = {
     "process_creation": {"group": "sysmon,process_creation,", "decoded_as": None, "if_sid": 61603},

quality/validator.py

@@ -98,7 +98,7 @@ def validate_sigma_rules(rules: list[SigmaRule] | None) -> list[ValidationResult
     rule_list = rules or []
     results = [validate_sigma_rule(rule) for rule in rule_list]
     duplicate_ids = {rule_id for rule_id, count in Counter(rule.rule_id for rule in rule_list).items() if count > 1}
-    for rule, result in zip(rule_list, results):
+    for rule, result in zip(rule_list, results, strict=True):
         if rule.rule_id in duplicate_ids:
             result.errors.append(f"Duplicate Sigma rule ID: {rule.rule_id}.")
             result.is_valid = False
@@ -173,7 +173,7 @@ def validate_wazuh_rules(rules: list[WazuhRule] | None) -> list[ValidationResult
     rule_list = rules or []
     results = [validate_wazuh_rule(rule) for rule in rule_list]
     duplicate_ids = {rule_id for rule_id, count in Counter(rule.rule_id for rule in rule_list).items() if count > 1}
-    for rule, result in zip(rule_list, results):
+    for rule, result in zip(rule_list, results, strict=True):
         if rule.rule_id in duplicate_ids:
             result.errors.append(f"Duplicate Wazuh rule ID: {rule.rule_id}.")
             result.is_valid = False

review/reviewer.py

@@ -3,7 +3,6 @@
 from __future__ import annotations
 
 from dataclasses import replace
-from typing import Any
 
 from core.models import SigmaRule, WazuhRule
 

review/versioner.py

@@ -4,7 +4,7 @@
 
 import hashlib
 import json
-from dataclasses import asdict, replace
+from dataclasses import replace
 from datetime import datetime, timezone
 from typing import Any
 

tests/test_reporting.py

@@ -13,8 +13,6 @@
 from generators.sigma_generator import generate_sigma_rules
 from ioc.ioc_extractor import extract_all_iocs
 from ingestion.anyrun import parse_report as parse_anyrun_report
-from ingestion.cape import parse_report as parse_cape_report
-from ingestion.cuckoo import parse_report as parse_cuckoo_report
 from quality.risk_scorer import score_rule
 from quality.validator import validate_sigma_rules, validate_wazuh_rules
 from reporting.report_generator import generate_markdown_report
@@ -133,4 +131,4 @@ def test_missing_hashes_are_called_out_in_summary_and_report() -> None:
     assert summary["sample"]["hash_status"]["complete"] is False
     assert summary["sample"]["hash_status"]["missing"] == ["md5", "sha1", "sha256"]
     assert "## Source Data Limitations" in report
-    assert "Missing payload hashes: md5, sha1, sha256" in report
+    assert "Missing payload hashes: md5, sha1, sha256" in report

tests/test_repository_metadata.py

@@ -49,7 +49,11 @@ def test_generated_handbook_is_ignored() -> None:
         if line.strip() and not line.lstrip().startswith("#")
     }
 
-    assert "MALFORGE_COMPLETE_PROJECT_HANDBOOK.md" in ignored_entries
+    assert {
+        "MALFORGE_COMPLETE_PROJECT_HANDBOOK.md",
+        ".codex-handbook-deps/",
+        ".ruff_cache/",
+    } <= ignored_entries
 
 
 def test_repository_has_an_mit_license() -> None: