Skip to content

Commit 1d52515

Browse files
author
Anatoly Tsyplenkov
committed
update cran comments
1 parent 7343871 commit 1d52515

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
- Fix compilation with `STRICT_R_HEADERS` by replacing R memory allocation macros with standard C functions in `src/get_jenkbreaks.c`.
55
- Fix broken or redirected URLs in the package vignettes.
66
- Reduce `show_shareplot()` example runtime by wrapping heavier examples in `\donttest{}`.
7+
- Add missing value documentation for `theme_nlm()` and `util_writeESRI()`.
8+
- Replace `\dontrun{}` examples with `\donttest{}` or runnable examples.
79

810
## MAINTENANCE
911
- New package maintainer -- Anatoly Tsyplenkov (#48).

cran-comments.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ In response to the incoming pre-test feedback on 0.6.3:
88

99
- Quoted package/software names (`'tibble'`, `'landscapetools'`) and class abbreviations (`'rasterstacks'`, `'-bricks'`) in `DESCRIPTION` to avoid the spell-check NOTE.
1010
- Reduced the `show_shareplot()` example runtime by keeping a minimal runnable example and wrapping the heavier, raster-dependent examples in `\donttest{}`.
11+
- Added missing `\value{}` documentation for `theme_nlm.Rd` and `util_writeESRI.Rd`.
12+
- Replaced `\dontrun{}` examples with `\donttest{}` where the examples are executable but longer-running, and made the `util_writeESRI()` example runnable with a temporary file.
1113

1214
## Test environments
1315

@@ -19,16 +21,18 @@ In response to the incoming pre-test feedback on 0.6.3:
1921
local Arch Linux (`--as-cran --no-manual`):
2022

2123
```
22-
0 errors | 0 warnings | 0 notes
24+
0 errors | 0 warnings | 2 notes
2325
```
2426

27+
The local NOTEs are the expected CRAN incoming feasibility message for a new submission of a previously archived package and local non-portable compiler flags from the Arch Linux R build.
28+
2529
win-builder R-devel:
2630

2731
```
2832
0 errors | 0 warnings | 1 note
2933
```
3034

31-
The single NOTE is the expected CRAN incoming feasibility message for a new submission of a previously archived package.
35+
The win-builder NOTE is the expected CRAN incoming feasibility message for a new submission of a previously archived package.
3236

3337
## Reverse dependencies
3438

0 commit comments

Comments
 (0)